-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point at the span for the definition of crate foreign ADTs #65912
Conversation
@petrochenkov I'd like to attempt to merge this (if approved) to see if the errors I feared would trigger actually do. |
@bors r+ |
📌 Commit ff609eedf42600e32fd1e0c3d736cade35897086 has been approved by |
@bors rollup=never |
⌛ Testing commit ff609eedf42600e32fd1e0c3d736cade35897086 with merge d58c437eea8b08eb42f0eabf32d54ec730ed6bca... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - checks-azure |
☔ The latest upstream changes (presumably #66208) made this pull request unmergeable. Please resolve the merge conflicts. |
Ping from triage: |
@JohnCSimon it is. |
#67334 is merged, marking as unblocked. |
Ping from Triage: any updates @estebank? |
ff609ee
to
be219a5
Compare
@joelpalmer I was out last week. I have rebased and added the appropriate platform specific test ignores. @petrochenkov I believe this is ready for final review. |
@bors r=petrochenkov |
📌 Commit eef0a2f42a93eedd6fdb1ab879b3c464af602519 has been approved by |
☔ The latest upstream changes (presumably #68078) made this pull request unmergeable. Please resolve the merge conflicts. |
eef0a2f
to
38a3506
Compare
@bors r=petrochenkov |
📌 Commit 38a3506 has been approved by |
⌛ Testing commit 38a3506 with merge 64e2c1c3d9d1e2ec396d5fa5bc9c26dbab585aa8... |
@bors retry yielding to r0llup. |
⌛ Testing commit 38a3506 with merge 700abe4f38fc08f36dfe85814f0730e7e9f61008... |
@bors retry yielding... |
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☀️ Test successful - checks-azure |
Follow up to #65421. Partially addresses #65386. Blocked on #53081.