Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information on rustdoc search #65842

Merged
merged 1 commit into from
Oct 26, 2019

Conversation

GuillaumeGomez
Copy link
Member

Fixes #65735.

r? @kinnison

Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny (optional) tweak, otherwise 👍

your request: <code>\"string\"</code>\
</p>\
<p>\
Look for items inside another one by searching a path: <code>vec::Vec</code>\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Look for items inside another one by searching a path: <code>vec::Vec</code>\
Look for items inside another one by searching for a path: <code>vec::Vec</code>\

@GuillaumeGomez
Copy link
Member Author

Updated.

Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JohnTitor
Copy link
Member

r? @Dylan-DPC
or someone from rustdoc team

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2019
@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 26, 2019

📌 Commit 1f25fd7 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 26, 2019
…ion, r=Dylan-DPC

Add more information on rustdoc search

Fixes rust-lang#65735.

r? @kinnison
bors added a commit that referenced this pull request Oct 26, 2019
Rollup of 8 pull requests

Successful merges:

 - #65743 (rustc_typeck: don't record direct callees in generator_interior.)
 - #65761 (libsyntax: Enhance documentation of the AST module)
 - #65772 (Remove the last remaining READMEs)
 - #65773 (Increase spacing for suggestions in diagnostics)
 - #65791 (Adding doc on keyword continue)
 - #65824 (rustc: make DefPathData (and friends) Copy (now that it uses Symbol).)
 - #65828 (Derive Eq and Hash for SourceInfo again)
 - #65842 (Add more information on rustdoc search)

Failed merges:

 - #65825 (rustc: use IndexVec<DefIndex, T> instead of Vec<T>.)

r? @ghost
@bors bors merged commit 1f25fd7 into rust-lang:master Oct 26, 2019
@GuillaumeGomez GuillaumeGomez deleted the more-search-information branch October 27, 2019 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add doc tip with '?' for exact search (within double quotes)
5 participants