Rollup of 13 pull requests #65368
Merged
Rollup of 13 pull requests #65368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor is private, not the type. Idea credit to @petrochenkov, discussed at rust-lang#65153
…r=GuillaumeGomez Document missing deny by default lints
Implement Clone::clone_from for VecDeque See rust-lang#28481. For simple data types with the target much longer than the source, this implementation can be significantly slower than the default (probably due to the use of truncate). However, it should be substantially faster when cloning from nested data structures with similar shapes or when cloning from VecDeques with similar lengths, hopefully more common use cases for clone_from.
Improve docs on some char boolean methods simple revival of rust-lang#61794 (also rustfmt on rest of file :) Documentation for `is_xid_start()` and `is_xid_continue()` couldn't be improved since both methods got remove from this repository r? @dtolnay cc @JohnCSimon
Suggest `if let` on `let` refutable binding Fix rust-lang#58385.
…nkov resolve: fix error title regarding private constructors One reason is that constructors can be private while their types can be public. Idea credit to @petrochenkov, discussed at rust-lang#65153
Move diagnostics code out of the critical path Follow up to rust-lang#65077. r? @nnethercote
Report `CONST_ERR` lint in external macros fixes rust-lang#65300 fixes rust-lang#61058 r? @oli-obk
…r=petrochenkov replace the hand-written binary search with the library one
do not reference LLVM for our concurrency memory model Fixes rust-lang#65282
…h-ascription, r=davidtwco syntax: simplify maybe_annotate_with_ascription Split out from rust-lang#65324. r? @estebank
simplify maybe_stage_features Extracted from rust-lang#65324. r? @estebank
simplify integer_lit Extracted from rust-lang#65324. r? @davidtwco
mbe: reduce panictry! uses. Extracted from rust-lang#65324. r? @petrochenkov
|
@bors r+ p=13 rollup=never |
|
📌 Commit b828591 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 13, 2019
Rollup of 13 pull requests Successful merges: - #65039 (Document missing deny by default lints) - #65069 (Implement Clone::clone_from for VecDeque) - #65165 (Improve docs on some char boolean methods) - #65248 (Suggest `if let` on `let` refutable binding) - #65250 (resolve: fix error title regarding private constructors) - #65295 (Move diagnostics code out of the critical path) - #65320 (Report `CONST_ERR` lint in external macros) - #65327 (replace the hand-written binary search with the library one) - #65339 (do not reference LLVM for our concurrency memory model) - #65357 (syntax: simplify maybe_annotate_with_ascription) - #65358 (simplify maybe_stage_features) - #65359 (simplify integer_lit) - #65360 (mbe: reduce panictry! uses.) Failed merges: r? @ghost
|
☀️ Test successful - checks-azure |
This was referenced Oct 13, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
if letonletrefutable binding #65248 (Suggestif letonletrefutable binding)CONST_ERRlint in external macros #65320 (ReportCONST_ERRlint in external macros)Failed merges:
r? @ghost