Remove implicit dependencies on syntax::pprust #65363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead just use `pprust::path_to_string(..)` where needed. This has two benefits: a) The AST definition is now independent of printing it. (Therefore we get closer to extracting a data-crate.) b) Debugging should be easier as program flow is clearer.
Centril
changed the title
JohnTitor
added
the
S-waiting-on-review
|
Historically I've looked at doing this but didn't see it as immediately actionable. Seems like pprust is still just as coupled with this commit. But I don't mind it, I guess, since it should make further decoupling easier (since you can handle each case separately, vs. an unknown number of cases through a Display/Debug impl). |
|
(iirc there were rather few dependencies on pprust left in libsyntax after #65324 so in a larger context this should bring us closer to that goal.) |
|
@bors r+ Changes look correct to me, and it seems to be passing CI. Some of the debug output is probably technically worse now but not in a way that seems immediately bad to me so we can probably leave it be for the time being. |
|
📌 Commit ab8105e has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 14, 2019
Remove implicit dependencies on syntax::pprust Part of rust-lang#65324. The main goal here is to facilitate the eventual move of pprust out from libsyntax and because an AST definition typically should not depend on its pretty printer. r? @estebank
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 14, 2019
Remove implicit dependencies on syntax::pprust Part of rust-lang#65324. The main goal here is to facilitate the eventual move of pprust out from libsyntax and because an AST definition typically should not depend on its pretty printer. r? @estebank
bors
added a commit
that referenced
this pull request
Oct 14, 2019
Rollup of 7 pull requests Successful merges: - #65215 (Add long error explanation for E0697) - #65292 (Print lifetimes with backticks) - #65362 (syntax: consolidate function parsing in item.rs) - #65363 (Remove implicit dependencies on syntax::pprust) - #65379 (refactor session::config::build_session_options_and_crate_config) - #65392 (Move `Nonterminal::to_tokenstream` to parser & don't rely directly on parser in lowering) - #65395 (Add some tests for fixed ICEs) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Oct 14, 2019
Rollup of 7 pull requests Successful merges: - #65215 (Add long error explanation for E0697) - #65292 (Print lifetimes with backticks) - #65362 (syntax: consolidate function parsing in item.rs) - #65363 (Remove implicit dependencies on syntax::pprust) - #65379 (refactor session::config::build_session_options_and_crate_config) - #65392 (Move `Nonterminal::to_tokenstream` to parser & don't rely directly on parser in lowering) - #65395 (Add some tests for fixed ICEs) Failed merges: r? @ghost
calebcartwright
added a commit
to calebcartwright/rustfmt
that referenced
this pull request
Jan 16, 2020
implicit pprust dependencies were removed and now require explicit usage rust-lang/rust#65363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #65324.
The main goal here is to facilitate the eventual move of pprust out from libsyntax and because an AST definition typically should not depend on its pretty printer.
r? @estebank