When encountering chained operators use heuristics to recover from bad turbofish #64909

estebank · 2019-09-30T02:08:28Z

No description provided.

rust-highfive · 2019-09-30T02:08:31Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

src/libsyntax/parse/diagnostics.rs

estebank · 2019-09-30T19:20:07Z

r? @Centril

src/libsyntax/parse/diagnostics.rs

src/test/ui/parser/require-parens-for-chained-comparison.rs

src/libsyntax/parse/diagnostics.rs

Centril · 2019-10-01T01:09:13Z

Since @varkor has done some work in this area it would be good if they could take a look as well.

src/libsyntax/parse/diagnostics.rs

Centril · 2019-10-01T21:53:51Z

src/test/ui/parser/require-parens-for-chained-comparison.stderr

+error: chained comparison operators require parentheses
+  --> $DIR/require-parens-for-chained-comparison.rs:22:21
+   |
+LL |     let _ = identity<u8>;
+   |                     ^^^^
+   |
+   = help: use the "turbofish" `::<...>` instead of `<...>` to specify type arguments
+   = help: or use `(...)` if you meant to specify fn arguments
+


Possible heuristic: look-ahead to see if we have ; -- at that point we can be sure it should be turbofish.

This fails with let _: Box<('a) + Trait>;.

But that's in a type context not expression context?
(Can always follow up...)

src/libsyntax/parse/diagnostics.rs

Centril · 2019-10-03T13:20:38Z

r=me with reference to "turbofish" removed (per #64909 (comment)) and optionally #64909 (comment) and #64909 (comment) implemented.

…d turbofish

src/librustc_errors/diagnostic.rs

src/librustc_errors/emitter.rs

estebank · 2019-10-04T17:58:54Z

@bors r=Centril

bors · 2019-10-04T17:58:55Z

📌 Commit 76456e7 has been approved by Centril

bors · 2019-10-04T18:07:48Z

⌛ Testing commit 76456e7 with merge 9b1ac2dd83494262a26554e0bf08c9b6407d43b6...

When encountering chained operators use heuristics to recover from bad turbofish

Mark-Simulacrum · 2019-10-04T18:17:05Z

@bors retry yielding to rollup including this PR #65109

@ghost

Rollup of 7 pull requests Successful merges: - #64909 (When encountering chained operators use heuristics to recover from bad turbofish) - #65020 (Always mark rust and rust-call abi's as unwind) - #65064 (permit asyncawait-ondeck to be added by anyone) - #65066 ([const-prop] Fix ICE when trying to eval polymorphic promoted MIR) - #65100 (Replace GeneratorSubsts with SubstsRef) - #65101 (Upgrade librustc_macros dependencies) - #65105 (Split out some passes from librustc) Failed merges: r? @ghost

When encountering chained operators use heuristics to recover from bad turbofish

@ghost

Rollup of 8 pull requests Successful merges: - #64708 (Stabilize `Option::as_deref` and `Option::as_deref_mut`) - #64909 (When encountering chained operators use heuristics to recover from bad turbofish) - #65011 (Do not ICE when dereferencing non-Copy raw pointer) - #65064 (permit asyncawait-ondeck to be added by anyone) - #65066 ([const-prop] Fix ICE when trying to eval polymorphic promoted MIR) - #65100 (Replace GeneratorSubsts with SubstsRef) - #65105 (Split out some passes from librustc) - #65106 (Allow unused attributes to avoid incremental bug) Failed merges: r? @ghost

bors · 2019-10-05T14:32:54Z

⌛ Testing commit 76456e7 with merge 58914e7...

When encountering chained operators use heuristics to recover from bad turbofish

bors · 2019-10-05T18:47:54Z

💥 Test timed out

estebank · 2019-10-05T21:01:47Z

@bors retry

When encountering chained operators use heuristics to recover from bad turbofish

@ghost

Rollup of 18 pull requests This contains changes from all the successful runs that bors marked as timed out, plus a revert of #63649 which appears to be the immediate cause of the timeouts. Successful merges: - #64708 (Stabilize `Option::as_deref` and `Option::as_deref_mut`) - #64728 (Stabilize UdpSocket::peer_addr) - #64765 (std: Reduce checks for `feature = "backtrace"`) - #64909 (When encountering chained operators use heuristics to recover from bad turbofish) - #65011 (Do not ICE when dereferencing non-Copy raw pointer) - #65064 (permit asyncawait-ondeck to be added by anyone) - #65066 ([const-prop] Fix ICE when trying to eval polymorphic promoted MIR) - #65100 (Replace GeneratorSubsts with SubstsRef) - #65105 (Split out some passes from librustc) - #65106 (Allow unused attributes to avoid incremental bug) - #65113 (Fix lonely backtick) - #65116 (Remove unneeded visit_statement definition) - #65118 (Update the documented default of -Z mutable-noalias) - #65123 (Account for macro invocation in `let mut $pat` diagnostic.) - #65124 (Replace some instances of `as *[const | mut] _` with `.cast()`) - #65126 (Fix typo on `now()` comments) - #65130 (lint: extern non-exhaustive types are improper) - #65151 (Revert #63649 - "Upgrade Emscripten targets to use upstream LLVM backend") Failed merges: r? @ghost

rust-highfive assigned eddyb Sep 30, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2019

This comment has been minimized.

Sign in to view

Centril reviewed Sep 30, 2019

View reviewed changes

src/libsyntax/parse/diagnostics.rs Outdated Show resolved Hide resolved

estebank force-pushed the turbofish-reloaded branch from ee2838b to 8cd314b Compare September 30, 2019 04:54

rust-highfive assigned Centril and unassigned eddyb Sep 30, 2019

estebank force-pushed the turbofish-reloaded branch from 12ef2af to b9f8c53 Compare September 30, 2019 19:21

Centril reviewed Oct 1, 2019

View reviewed changes

Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2019

Centril reviewed Oct 1, 2019

View reviewed changes

src/libsyntax/parse/diagnostics.rs Outdated Show resolved Hide resolved

Centril reviewed Oct 1, 2019

View reviewed changes

src/libsyntax/parse/diagnostics.rs Outdated Show resolved Hide resolved

estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 2, 2019

eddyb reviewed Oct 3, 2019

View reviewed changes

src/libsyntax/parse/diagnostics.rs Outdated Show resolved Hide resolved

Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2019

estebank added 7 commits October 3, 2019 11:55

When encountering chained operators use heuristics to recover from ba…

ed60cf2

…d turbofish

review comments

6c9f298

Account for missing turbofish in paths too

d7dceaa

Prove bad turbofish parser recovery in test

d27683a

review comments

dfdc369

review comments

f1499a8

review comments

02f57f8

Centril reviewed Oct 3, 2019

View reviewed changes

src/librustc_errors/diagnostic.rs Outdated Show resolved Hide resolved

Centril reviewed Oct 3, 2019

View reviewed changes

src/librustc_errors/emitter.rs Outdated Show resolved Hide resolved

review comments

76456e7

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2019

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Oct 4, 2019

Rollup merge of rust-lang#64909 - estebank:turbofish-reloaded, r=Centril

c4ec53f

When encountering chained operators use heuristics to recover from bad turbofish

Mark-Simulacrum mentioned this pull request Oct 4, 2019

Rollup of 7 pull requests #65109

Closed

Centril added a commit to Centril/rust that referenced this pull request Oct 4, 2019

Rollup merge of rust-lang#64909 - estebank:turbofish-reloaded, r=Centril

db4ad42

When encountering chained operators use heuristics to recover from bad turbofish

Centril mentioned this pull request Oct 4, 2019

Rollup of 8 pull requests #65115

Closed

bors added a commit that referenced this pull request Oct 5, 2019

Auto merge of #64909 - estebank:turbofish-reloaded, r=Centril

58914e7

When encountering chained operators use heuristics to recover from bad turbofish

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 5, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2019

tmandry added the A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) label Oct 6, 2019

tmandry added a commit to tmandry/rust that referenced this pull request Oct 6, 2019

Rollup merge of rust-lang#64909 - estebank:turbofish-reloaded, r=Centril

c7d7e37

When encountering chained operators use heuristics to recover from bad turbofish

tmandry mentioned this pull request Oct 6, 2019

Rollup of 18 pull requests #65152

Merged

bors merged commit 76456e7 into rust-lang:master Oct 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When encountering chained operators use heuristics to recover from bad turbofish #64909

When encountering chained operators use heuristics to recover from bad turbofish #64909

estebank commented Sep 30, 2019

rust-highfive commented Sep 30, 2019

This comment has been minimized.

estebank commented Sep 30, 2019

Centril commented Oct 1, 2019

Centril Oct 1, 2019

estebank Oct 3, 2019

Centril Oct 3, 2019 •

edited

Loading

Centril commented Oct 3, 2019

estebank commented Oct 4, 2019

bors commented Oct 4, 2019

bors commented Oct 4, 2019

Mark-Simulacrum commented Oct 4, 2019

bors commented Oct 5, 2019

bors commented Oct 5, 2019

estebank commented Oct 5, 2019

When encountering chained operators use heuristics to recover from bad turbofish #64909

When encountering chained operators use heuristics to recover from bad turbofish #64909

Conversation

estebank commented Sep 30, 2019

rust-highfive commented Sep 30, 2019

This comment has been minimized.

estebank commented Sep 30, 2019

Centril commented Oct 1, 2019

Centril Oct 1, 2019

Choose a reason for hiding this comment

estebank Oct 3, 2019

Choose a reason for hiding this comment

Centril Oct 3, 2019 • edited Loading

Choose a reason for hiding this comment

Centril commented Oct 3, 2019

estebank commented Oct 4, 2019

bors commented Oct 4, 2019

bors commented Oct 4, 2019

Mark-Simulacrum commented Oct 4, 2019

bors commented Oct 5, 2019

bors commented Oct 5, 2019

estebank commented Oct 5, 2019

Centril Oct 3, 2019 •

edited

Loading