Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exempt extern "Rust" from improper_ctypes #64641

Merged
merged 1 commit into from
Sep 21, 2019

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Sep 20, 2019

It should be fine for Rust ABIs to involve any Rust type.

Fixes #64593.

It should be fine for Rust ABIs to involve any Rust type.
@cuviper
Copy link
Member Author

cuviper commented Sep 20, 2019

Hmm, no bot? How about...
r? @estebank

@cuviper cuviper added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 20, 2019
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Sep 21, 2019

📌 Commit 9f374da has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Sep 21, 2019
Exempt extern "Rust" from improper_ctypes

It should be fine for Rust ABIs to involve any Rust type.

Fixes rust-lang#64593.
Centril added a commit to Centril/rust that referenced this pull request Sep 21, 2019
Exempt extern "Rust" from improper_ctypes

It should be fine for Rust ABIs to involve any Rust type.

Fixes rust-lang#64593.
Centril added a commit to Centril/rust that referenced this pull request Sep 21, 2019
Exempt extern "Rust" from improper_ctypes

It should be fine for Rust ABIs to involve any Rust type.

Fixes rust-lang#64593.
bors added a commit that referenced this pull request Sep 21, 2019
Rollup of 9 pull requests

Successful merges:

 - #64010 (Stabilize `param_attrs` in Rust 1.39.0)
 - #64136 (Document From trait for LhsExpr in parser)
 - #64342 (factor out pluralisation remains after #64280)
 - #64347 (Add long error explanation for E0312)
 - #64621 (Add Compatibility Notes to RELEASES.md for 1.38.0)
 - #64632 (remove the extra comma after the match arm)
 - #64640 (No home directory on vxWorks)
 - #64641 (Exempt extern "Rust" from improper_ctypes)
 - #64642 (Fix the span used to suggest avoiding for-loop moves)

Failed merges:

r? @ghost
@bors bors merged commit 9f374da into rust-lang:master Sep 21, 2019
@cuviper cuviper deleted the extern-rust-ctypes branch April 3, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary improper_ctypes warning for extern "Rust"
3 participants