Override StepBy::{try_fold, try_rfold}
#64121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @KodrAus (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @scottmcm |
scottmcm
requested changes
Sep 4, 2019
src/libcore/iter/adapters/mod.rs
Outdated
| Some(x) => acc = f(acc, x)?, | ||
| } | ||
| } | ||
| from_fn(|| self.iter.nth(self.step)).try_fold(acc, f) |
There was a problem hiding this comment.
Can you just use a while let Some(x) = self.iter.nth(self.step) loop here instead? It'll do the same thing, but without introducing a new closure that would regress #62429.
There was a problem hiding this comment.
Thanks, I forgot about that. I turned the closures into functions instead, that should have the same benefits, correct? I figured this will make it easier to potentially undo these changes in the future.
scottmcm
added
S-waiting-on-author
|
@bors r+ rollup |
|
📌 Commit 78908f2 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 9, 2019
… r=scottmcm
Override `StepBy::{try_fold, try_rfold}`
Previous PR: rust-lang#51435
The previous PR was closed in favor of rust-lang#51601, which was later reverted. I don't think these implementations will make it harder to specialize `StepBy<Range<_>>` later, so we should be able to land this without any consequences.
This should fix rust-lang#57517 – in my benchmarks `iter` and `iter.step_by(1)` now perform equally well, provided internal iteration is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #51435
The previous PR was closed in favor of #51601, which was later reverted. I don't think these implementations will make it harder to specialize
StepBy<Range<_>>later, so we should be able to land this without any consequences.This should fix #57517 – in my benchmarks
iteranditer.step_by(1)now perform equally well, provided internal iteration is used.