Add Option<Span> to require_lang_item
#63961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
force-pushed
the
improve-require-lang-item
branch
from
04222b5
to
8c921be
Compare
JohnTitor
commented
Aug 27, 2019
src/test/ui/privacy/privacy2.stderr
Outdated
| --> $DIR/privacy2.rs:14:14 | ||
| | | ||
| LL | pub fn foo() {} | ||
| | ^ |
There was a problem hiding this comment.
@jonas-schievink This and privacy3 are expected?
There was a problem hiding this comment.
Probably, but yeah it's not a very good error span. Feel free to remove the spans for the Sized lang item, the compiler needs that lang item for all sorts of checks that don't really correspond to any language features.
There was a problem hiding this comment.
Hmm, okay, it may cause confusing so I'd like to remove their spans.
JohnTitor
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit ede7a77 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 29, 2019
…, r=estebank Add Option<Span> to `require_lang_item` Fixes rust-lang#63954 I'm not sure where to take `Some(span)` or something so I use `None` in many places. r? @estebank
bors
added a commit
that referenced
this pull request
Aug 29, 2019
Rollup of 11 pull requests Successful merges: - #63811 (Correctly suggest adding bounds to `impl Trait` argument) - #63933 (Resolve some small issues related to #63580) - #63938 (or-pattern: fix typo in error message) - #63945 (Recover `mut $pat` and other improvements) - #63958 (const_prop: only call error_to_const_error if we are actually showing something) - #63961 (Add Option<Span> to `require_lang_item`) - #63963 (remove the reference to __cxa_thread_atexit_impl) - #63965 (Prevent syntax error in LD linker version script) - #63968 (rustc_apfloat: make the crate #![no_std] explicitly.) - #63970 (Notify me (flip1995) when Clippy toolstate changes) - #63980 (add missing `#[repr(C)]` on the Slices union) Failed merges: - #63989 (Add Yaah to clippy toolstain notification list) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63954
I'm not sure where to take
Some(span)or something so I useNonein many places.r? @estebank