-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unsupported test case #63206
remove unsupported test case #63206
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@@ -404,66 +404,3 @@ impl ExitCode { | |||
} | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This blank line should be removed.
@BaoshanPang this is presumably an unsupported test case on vxworks, right? I think it's supported elsewhere though so could this only be excluded on vxworks? |
The test case is using 'cat' which is not existed on vxWorks. We maybe want to develop an equal test case in futcher, but for now just remove it. |
@bors: r+ rollup Oh oops sorry I forgot this was already in a vxworks-specific module |
📌 Commit 208672f has been approved by |
Thanks for the quick reivew as always. |
@BaoshanPang: 🔑 Insufficient privileges: Not in reviewers |
@BaoshanPang: 🔑 Insufficient privileges: not in try users |
remove unsupported test case r? @alexcrichton
Rollup of 7 pull requests Successful merges: - #63107 (Added support for armv7-unknown-linux-gnueabi/musleabi) - #63121 (On `format!()` arg count mismatch provide extra info) - #63196 (build_helper: try less confusing method names) - #63206 (remove unsupported test case) - #63208 (Round generator sizes to a multiple of their alignment) - #63212 (Pretty print attributes in `print_arg`) - #63215 (Clarify semantics of mem::zeroed) Failed merges: r? @ghost
r? @alexcrichton