Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unsupported test case #63206

Merged
merged 1 commit into from
Aug 3, 2019
Merged

remove unsupported test case #63206

merged 1 commit into from
Aug 3, 2019

Conversation

BaoshanPang
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 1, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-01T23:34:30.6978723Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-01T23:34:30.7170942Z ##[command]git config gc.auto 0
2019-08-01T23:34:30.7248443Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-01T23:34:31.4749937Z ##[command]git config --get-all http.proxy
2019-08-01T23:34:31.4756868Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63206/merge:refs/remotes/pull/63206/merge
---
2019-08-01T23:35:04.3953657Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-01T23:35:04.3954507Z 
2019-08-01T23:35:04.3955541Z   git checkout -b <new-branch-name>
2019-08-01T23:35:04.3956363Z 
2019-08-01T23:35:04.3956949Z HEAD is now at 8c870c33f Merge 6f16dc4d8fea444d8be6aff2b41bd36c36a7ab1b into 435236b8877cdb98c82eaebfb7887782277265c5
2019-08-01T23:35:04.4125845Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-01T23:35:04.4128844Z ==============================================================================
2019-08-01T23:35:04.4128904Z Task         : Bash
2019-08-01T23:35:04.4128950Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-01T23:38:35.6418303Z  ---> 5ee34b4b6e56
2019-08-01T23:38:35.6462453Z Successfully built 5ee34b4b6e56
2019-08-01T23:38:35.7081314Z Successfully tagged rust-ci:latest
2019-08-01T23:38:35.7670551Z Built container sha256:5ee34b4b6e56d04704cc85e34f55bed4b7db0312738b8ff65b183d4ffaabb1dd
2019-08-01T23:38:35.7688939Z Uploading finished image to https://rust-lang-ci-sccache2.s3.amazonaws.com/docker/1bcedfd0fd3b0e1f17865450d97c5f933a700734ac7e085679f2dabcb79f9aa8554228d95a4689fc65827d53828df5be9ba37c197505830ce93978e771921af3
2019-08-01T23:39:37.1503995Z upload failed: - to s3://rust-lang-ci-sccache2/docker/1bcedfd0fd3b0e1f17865450d97c5f933a700734ac7e085679f2dabcb79f9aa8554228d95a4689fc65827d53828df5be9ba37c197505830ce93978e771921af3 Unable to locate credentials
2019-08-01T23:39:38.0441118Z [CI_JOB_NAME=x86_64-gnu-llvm-6.0]
2019-08-01T23:39:38.0487180Z Starting sccache server...
2019-08-01T23:39:38.1392640Z configure: processing command line
2019-08-01T23:39:38.1392891Z configure: 
---
2019-08-01T23:43:01.9543566Z    Compiling serde_json v1.0.40
2019-08-01T23:43:06.3036417Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-08-01T23:43:14.7501125Z     Finished release [optimized] target(s) in 1m 27s
2019-08-01T23:43:14.7564149Z tidy check
2019-08-01T23:43:15.2520094Z tidy error: /checkout/src/libstd/sys/vxworks/process/process_common.rs: too many trailing newlines (2)
2019-08-01T23:43:16.5277296Z some tidy checks failed
2019-08-01T23:43:16.5277442Z 
2019-08-01T23:43:16.5277442Z 
2019-08-01T23:43:16.5278287Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-08-01T23:43:16.5278613Z 
2019-08-01T23:43:16.5278635Z 
2019-08-01T23:43:16.5282107Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-08-01T23:43:16.5282176Z Build completed unsuccessfully in 0:01:30
2019-08-01T23:43:16.5282176Z Build completed unsuccessfully in 0:01:30
2019-08-01T23:43:17.8155840Z ##[error]Bash exited with code '1'.
2019-08-01T23:43:17.8208266Z ##[section]Starting: Checkout
2019-08-01T23:43:17.8209768Z ==============================================================================
2019-08-01T23:43:17.8209815Z Task         : Get sources
2019-08-01T23:43:17.8210023Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@@ -404,66 +404,3 @@ impl ExitCode {
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blank line should be removed.

@alexcrichton
Copy link
Member

@BaoshanPang this is presumably an unsupported test case on vxworks, right? I think it's supported elsewhere though so could this only be excluded on vxworks?

@BaoshanPang
Copy link
Contributor Author

@BaoshanPang this is presumably an unsupported test case on vxworks, right? I think it's supported elsewhere though so could this only be excluded on vxworks?

The test case is using 'cat' which is not existed on vxWorks. We maybe want to develop an equal test case in futcher, but for now just remove it.

@alexcrichton
Copy link
Member

@bors: r+ rollup

Oh oops sorry I forgot this was already in a vxworks-specific module

@bors
Copy link
Contributor

bors commented Aug 2, 2019

📌 Commit 208672f has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2019
@BaoshanPang
Copy link
Contributor Author

@bors: r+ rollup

Oh oops sorry I forgot this was already in a vxworks-specific module

Thanks for the quick reivew as always.

@bors
Copy link
Contributor

bors commented Aug 2, 2019

@BaoshanPang: 🔑 Insufficient privileges: Not in reviewers

@bors
Copy link
Contributor

bors commented Aug 2, 2019

@BaoshanPang: 🔑 Insufficient privileges: not in try users

Centril added a commit to Centril/rust that referenced this pull request Aug 2, 2019
bors added a commit that referenced this pull request Aug 2, 2019
Rollup of 7 pull requests

Successful merges:

 - #63107 (Added support for armv7-unknown-linux-gnueabi/musleabi)
 - #63121 (On `format!()` arg count mismatch provide extra info)
 - #63196 (build_helper: try less confusing method names)
 - #63206 (remove unsupported test case)
 - #63208 (Round generator sizes to a multiple of their alignment)
 - #63212 (Pretty print attributes in `print_arg`)
 - #63215 (Clarify semantics of mem::zeroed)

Failed merges:

r? @ghost
@bors bors merged commit 208672f into rust-lang:master Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants