Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 6 pull requests #63176

Closed
wants to merge 22 commits into from
Closed

Rollup of 6 pull requests #63176

wants to merge 22 commits into from

Commits on Jul 25, 2019

  1. Add keywords item into the sidebar

    @GuillaumeGomez
    GuillaumeGomez committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    08a8de8 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2019

  1. Account for maybe_whole_expr in range patterns.

    @Centril
    Centril committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    f3a3290 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. Remove redundant method with const variable resolution

    @varkor
    varkor committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    87e73c1 View commit details
    Browse the repository at this point in the history

  2. Unify Github issue links in diagnostics 

    Co-authored-by: eupn <[email protected]>
Co-authored-by: Punit Singh Koura <[email protected]>
    @eupn @punitkoura
    eupn and punitkoura committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    01f97c3 View commit details
    Browse the repository at this point in the history

  3. Bless ui test files 

    Co-authored-by: eupn <[email protected]>
Co-authored-by: Punit Singh Koura <[email protected]>
    @eupn @punitkoura
    eupn and punitkoura committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    1ef1e7f View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from review by varkor 

    Co-Authored-By: varkor <[email protected]>
    @eupn @varkor
    eupn and varkor committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    7336626 View commit details
    Browse the repository at this point in the history

  5. Unify spanned and non-spanned Attribute ctors 

    There is no difference in the code/arguments, so go with the shorter
name throughout the code.
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    804f0f3 View commit details
    Browse the repository at this point in the history

  6. Remove AttrId from Attribute constructors

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    0a42bad View commit details
    Browse the repository at this point in the history

  7. Remove Span argument from ExtCtxt::attribute 

    MetaItem.span was always equivalent
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    b2c5065 View commit details
    Browse the repository at this point in the history

  8. Remove span argument from mk_attr_{inner,outer} 

    Always the same as the passed MetaItem
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    f78bf50 View commit details
    Browse the repository at this point in the history

  9. Replace a few Attribute constructors with mk_attr

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    c9bd4a0 View commit details
    Browse the repository at this point in the history

  10. Replace AstBuilder with inherent methods

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    0f98581 View commit details
    Browse the repository at this point in the history

  11. Use Ident::new over setting span position via builder

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    d4227f6 View commit details
    Browse the repository at this point in the history

  12. Decode AttrId via mk_attr_id

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    c146344 View commit details
    Browse the repository at this point in the history

  13. cleanup StringReader fields

    @matklad
    matklad committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    3f461f5 View commit details
    Browse the repository at this point in the history

  14. Address review comments.

    @Centril
    Centril committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    6551285 View commit details
    Browse the repository at this point in the history

  15. Rollup merge of rust-lang#62971 - GuillaumeGomez:keyword-sidebar, r=n… 

    …obody

Add keywords item into the sidebar

Fixes rust-lang#62939.

cc @pravic

screenshot of the result:

![Screenshot from 2019-07-25 14-29-48](https://user-images.githubusercontent.com/3050060/61874545-f9512080-aee8-11e9-8e8b-aa50216aec94.png)

r? @QuietMisdreavus
    @Centril
    Centril authored Jul 31, 2019
    Configuration menu
    Copy the full SHA
    49c9b22 View commit details
    Browse the repository at this point in the history

  16. Rollup merge of rust-lang#63008 - eupn:consistent-see-issue, r=varkor 

    Make "see issue" consistent

Fixes rust-lang#62976. h/t to @punitkoura for initial patterns search.

r? @varkor
    @Centril
    Centril authored Jul 31, 2019
    Configuration menu
    Copy the full SHA
    07675af View commit details
    Browse the repository at this point in the history

  17. Rollup merge of rust-lang#63122 - Centril:fix-63115, r=petrochenkov 

    Account for `maybe_whole_expr` in range patterns

Fixes rust-lang#63115 (fallout from rust-lang#62550).

r? @petrochenkov
    @Centril
    Centril authored Jul 31, 2019
    Configuration menu
    Copy the full SHA
    2955448 View commit details
    Browse the repository at this point in the history

  18. Rollup merge of rust-lang#63146 - Mark-Simulacrum:clean-attr, r=petro… 

    …chenkov

Cleanup syntax::attr

Mostly removing needless arguments to constructors

r? @petrochenkov
    @Centril
    Centril authored Jul 31, 2019
    Configuration menu
    Copy the full SHA
    7baf870 View commit details
    Browse the repository at this point in the history

  19. Rollup merge of rust-lang#63153 - varkor:remove-resolve_const_var, r=… 

    …cramertj

Remove redundant method with const variable resolution

I've also removed a `bug!()` in const value relation code and replaced it with a `FIXME`. Now `ConstValue::Slice` and `ConstValue::ByRef` will simply fail to unify rather than ICEing, which seems more user-friendly for testers.
    @Centril
    Centril authored Jul 31, 2019
    Configuration menu
    Copy the full SHA
    28461b6 View commit details
    Browse the repository at this point in the history

  20. Rollup merge of rust-lang#63170 - matklad:cleanup-fields, r=petrochenkov 

    cleanup StringReader fields

reduce visibility and replace `Lrc<SourceFile>` with `start_pos`: the single bit we actually *need* from the file.

r? @petrochenkov
    @Centril
    Centril authored Jul 31, 2019
    Configuration menu
    Copy the full SHA
    cb4c25b View commit details
    Browse the repository at this point in the history