ci: Skip installing SWIG/xz on OSX #63106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm relatively certain that SWIG was only needed for LLDB which is no longer built, and I'm hoping we can remove the xz install to remove the reliance on `brew` for our build (which is another point of failure for flaky networks).
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Looks like the Azure config is malformed? |
alexcrichton
force-pushed
the
remove-swig-osx
branch
3 times, most recently
from
1466de7
to
60680d4
Compare
|
Ok the test build is currently running but it made it through all the install phases which is where the xz dependency might have showed up, so I think we're good to go. |
|
@bors r+ p=1 rollup=never |
|
📌 Commit 60680d4 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 60680d4 with merge 8e1adc20e3d1b72e9c625e576826a3364c54ee19... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
@bors retry Agent lost connection with Azure Pipelines. |
bors
added
S-waiting-on-bors
|
@bors p=100 rollup All macOS builders were green, there are no issues landing this PR now. |
|
@bors rollup=maybe |
|
⌛ Testing commit 60680d4 with merge 2b47699f8385cb264a9e72dec0a4c04f7594a710... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 29, 2019
…troalbini ci: Skip installing SWIG/xz on OSX I'm relatively certain that SWIG was only needed for LLDB which is no longer built, and I'm hoping we can remove the xz install to remove the reliance on `brew` for our build (which is another point of failure for flaky networks).
|
@bors retry rolled up. |
|
⌛ Testing commit 60680d4 with merge 64128b688ebf8905f07db3e544725db22d6c26c0... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 30, 2019
…troalbini ci: Skip installing SWIG/xz on OSX I'm relatively certain that SWIG was only needed for LLDB which is no longer built, and I'm hoping we can remove the xz install to remove the reliance on `brew` for our build (which is another point of failure for flaky networks).
|
@bors retry rolled up. |
|
⌛ Testing commit 60680d4 with merge face7a5da937bcfac6caed54794d52290e89e7a9... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 30, 2019
…troalbini ci: Skip installing SWIG/xz on OSX I'm relatively certain that SWIG was only needed for LLDB which is no longer built, and I'm hoping we can remove the xz install to remove the reliance on `brew` for our build (which is another point of failure for flaky networks).
bors
added a commit
that referenced
this pull request
Jul 30, 2019
Rollup of 12 pull requests Successful merges: - #61965 (Remove mentions of removed `offset_to` method from `align_offset` docs) - #62928 (Syntax: Recover on `for ( $pat in $expr ) $block`) - #63000 (Impl Debug for Chars) - #63083 (Make generic parameters always use modern hygiene) - #63087 (Add very simple edition check to tidy.) - #63093 (Properly check the defining scope of existential types) - #63096 (Add tests for some `existential_type` ICEs) - #63099 (vxworks: Remove Linux-specific comments.) - #63106 (ci: Skip installing SWIG/xz on OSX ) - #63108 (Add links to None in Option doc) - #63109 (std: Fix a failing `fs` test on Windows) - #63111 (Add syntactic and semantic tests for rest patterns, i.e. `..`) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm relatively certain that SWIG was only needed for LLDB which is no
longer built, and I'm hoping we can remove the xz install to remove the
reliance on
brewfor our build (which is another point of failure forflaky networks).