libsyntax: Rename Mark into ExpnId
#62705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
petrochenkov
force-pushed
the
oh-bye-mark
branch
from
f4ccc29
to
5b656b4
Compare
|
r? @matthewjasper |
|
@bors r+ |
|
📌 Commit 5b656b456fef4690c07378728ef1b5449b981c72 has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #62684) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
petrochenkov
force-pushed
the
oh-bye-mark
branch
from
5b656b4
to
8f30d26
Compare
|
@bors r=matthewjasper |
|
📌 Commit 8f30d26 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 19, 2019
libsyntax: Rename `Mark` into `ExpnId` "`Mark`" is an ID that identifies both a macro invocation (`foo!()`), and expansion process, and expansion result of that macro invocation. The problem is that it's pretty hard to infer that from its name. This PR renames it into `ExpnId` reflecting its meaning in most contexts. (The contexts where it's meaning is closer to "macro invocation ID" are rarer.) I've kept "mark" in the names of functions that add or remove marks to/from syntactic contexts, those marks are not just expansion IDs, but something more complex.
|
☀️ Test successful - checks-azure |
This was referenced Jul 20, 2019
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jul 21, 2019
Fix breakage due to rust-lang/rust#62705 Also rename `OUTER_EXPN_INFO` to `OUTER_EXPN_EXPN_INFO` to match new function names. changelog: none
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 22, 2019
Changes: ```` Fix breakage due to rust-lang#60913 Fix breakage due to rust-lang#62705 rustup rust-lang#62679 Update pulldown-cmark to 0.5.3 rustup rust-lang#62764 Format code Decrease maximum length for stderr files Improved imports Fix "unkown clippy lint" error in UI test. Corrections for PR review. Implement lint for inherent to_string() method. UI Test Cleanup: Extract match_ref_pats tests Update UI tests Allow no_effect lint Remove comment cargo fmt UI Test Cleanup: Split up checked_unwrap tests Removed lintining on never type. UI Test Cleanup: Split out out_of_bounds_indexing false positives fixes of `implicit_return` ````
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 24, 2019
Changes: ```` update test stderr, not sure which rustc pull request caused this. rustup rust-lang#62859 Fix tests for edition 2018 compatibility Revert "Revert global fmt config and use `rustfmt::skip`" Fix breakage due to rust-lang#60913 Fix breakage due to rust-lang#62705 Revert global fmt config and use `rustfmt::skip` Fix fmt rustup rust-lang#62679 Update pulldown-cmark to 0.5.3 rustup rust-lang#62764 Add test Format code Decrease maximum length for stderr files Improved imports Fix "unkown clippy lint" error in UI test. Corrections for PR review. Implement lint for inherent to_string() method. UI Test Cleanup: Extract match_ref_pats tests Update UI tests Allow no_effect lint Remove comment cargo fmt UI Test Cleanup: Split up checked_unwrap tests Removed lintining on never type. UI Test Cleanup: Split out out_of_bounds_indexing false positives fixes of `implicit_return` Ignore generated fresh lifetimes in elision check. ````
bors
added a commit
that referenced
this pull request
Jul 24, 2019
submodules: update clippy from 164310d to f8e04ff Changes: ```` update test stderr, not sure which rustc pull request caused this. rustup #62859 Fix tests for edition 2018 compatibility Revert "Revert global fmt config and use `rustfmt::skip`" Fix breakage due to #60913 Fix breakage due to #62705 Revert global fmt config and use `rustfmt::skip` Fix fmt rustup #62679 Update pulldown-cmark to 0.5.3 rustup #62764 Add test Format code Decrease maximum length for stderr files Improved imports Fix "unkown clippy lint" error in UI test. Corrections for PR review. Implement lint for inherent to_string() method. UI Test Cleanup: Extract match_ref_pats tests Update UI tests Allow no_effect lint Remove comment cargo fmt UI Test Cleanup: Split up checked_unwrap tests Removed lintining on never type. UI Test Cleanup: Split out out_of_bounds_indexing false positives fixes of `implicit_return` Ignore generated fresh lifetimes in elision check. ```` fixes clippy toolstate r? @Manishearth
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 27, 2019
Changes: ```` ci: temporarily disable rustfmt checks/tetss since it's broken for nightly rustup rust-lang#62964 Bump version of clippy_dummy update test stderr, not sure which rustc pull request caused this. rustup rust-lang#62859 Fix tests for edition 2018 compatibility Revert "Revert global fmt config and use `rustfmt::skip`" Fix breakage due to rust-lang#60913 Fix breakage due to rust-lang#62705 Revert global fmt config and use `rustfmt::skip` Fix fmt rustup rust-lang#62679 Update pulldown-cmark to 0.5.3 rustup rust-lang#62764 Add test Format code Decrease maximum length for stderr files Improved imports Fix "unkown clippy lint" error in UI test. Corrections for PR review. Implement lint for inherent to_string() method. UI Test Cleanup: Extract match_ref_pats tests Update UI tests Allow no_effect lint Remove comment cargo fmt UI Test Cleanup: Split up checked_unwrap tests Removed lintining on never type. UI Test Cleanup: Split out out_of_bounds_indexing false positives fixes of `implicit_return` Ignore generated fresh lifetimes in elision check. ````
bors
added a commit
that referenced
this pull request
Jul 28, 2019
submodules: update clippy from 164310d to dc69a5c Changes: ```` ci: temporarily disable rustfmt checks/tetss since it's broken for nightly rustup #62964 Bump version of clippy_dummy update test stderr, not sure which rustc pull request caused this. rustup #62859 Fix tests for edition 2018 compatibility Revert "Revert global fmt config and use `rustfmt::skip`" Fix breakage due to #60913 Fix breakage due to #62705 Revert global fmt config and use `rustfmt::skip` Fix fmt rustup #62679 Update pulldown-cmark to 0.5.3 rustup #62764 Add test Format code Decrease maximum length for stderr files Improved imports Fix "unkown clippy lint" error in UI test. Corrections for PR review. Implement lint for inherent to_string() method. UI Test Cleanup: Extract match_ref_pats tests Update UI tests Allow no_effect lint Remove comment cargo fmt UI Test Cleanup: Split up checked_unwrap tests Removed lintining on never type. UI Test Cleanup: Split out out_of_bounds_indexing false positives fixes of `implicit_return` Ignore generated fresh lifetimes in elision check. ```` fixes clippy toolstate r? @Manishearth
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 5, 2020
Changes: ```` ci: temporarily disable rustfmt checks/tetss since it's broken for nightly rustup rust-lang/rust#62964 Bump version of clippy_dummy update test stderr, not sure which rustc pull request caused this. rustup rust-lang/rust#62859 Fix tests for edition 2018 compatibility Revert "Revert global fmt config and use `rustfmt::skip`" Fix breakage due to rust-lang/rust#60913 Fix breakage due to rust-lang/rust#62705 Revert global fmt config and use `rustfmt::skip` Fix fmt rustup rust-lang/rust#62679 Update pulldown-cmark to 0.5.3 rustup rust-lang/rust#62764 Add test Format code Decrease maximum length for stderr files Improved imports Fix "unkown clippy lint" error in UI test. Corrections for PR review. Implement lint for inherent to_string() method. UI Test Cleanup: Extract match_ref_pats tests Update UI tests Allow no_effect lint Remove comment cargo fmt UI Test Cleanup: Split up checked_unwrap tests Removed lintining on never type. UI Test Cleanup: Split out out_of_bounds_indexing false positives fixes of `implicit_return` Ignore generated fresh lifetimes in elision check. ````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"
Mark" is an ID that identifies both a macro invocation (foo!()), and expansion process, and expansion result of that macro invocation.The problem is that it's pretty hard to infer that from its name.
This PR renames it into
ExpnIdreflecting its meaning in most contexts.(The contexts where it's meaning is closer to "macro invocation ID" are rarer.)
I've kept "mark" in the names of functions that add or remove marks to/from syntactic contexts, those marks are not just expansion IDs, but something more complex.