-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta] Permit unwinding through FFI by default #62505
Conversation
|
I'm no longer in favor of postponing the stabilization of the |
I'm nominating this for T-lang since I think they should make the decision as to whether to merge this or not. I haven't done enough reading on the relevant issue(s) to have much of an opinion myself on what we should do here, so I won't weigh in. |
@Mark-Simulacrum Thank you for nominating. Speaking only for myself, I do feel we should merge this, or ideally merge it into trunk/nightly. Let's try to get this discussed in the lang team and sorted out. |
Discussed in @rust-lang/lang meeting -- general consensus that we should merge this PR to beta and we would also be happy to merge to master, as long as progress is being made on the RFC. |
@nikomatsakis Thanks for the summary! @cuviper Could you please prepare a version of this PR for master? |
Based on the consensus in the lang team meeting, merging this while we continue working on the RFC: @bors r+ |
📌 Commit f56bb3f has been approved by |
OK, the master PR is #62603. |
[beta] Permit unwinding through FFI by default This repeats #61569 for Rust 1.37, as #58794 is not yet resolved. cc @rust-lang/release r? @Mark-Simulacrum
☀️ Test successful - checks-azure, checks-travis, status-appveyor |
Permit unwinding through FFI by default This repeats #62505 for master (Rust 1.38+), as #58794 is not yet resolved. This is a stopgap until a stable alternative is available, like [RFC 2699](rust-lang/rfcs#2699), as long as progress is being made to that end. r? @joshtriplett
This repeats #61569 for Rust 1.37, as #58794 is not yet resolved.
cc @rust-lang/release
r? @Mark-Simulacrum