-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #62458
Rollup of 4 pull requests #62458
Commits on Jul 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ee05fc8 - Browse repository at this point
Copy the full SHA ee05fc8View commit details
Commits on Jul 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 02886e2 - Browse repository at this point
Copy the full SHA 02886e2View commit details
Commits on Jul 6, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b11757e - Browse repository at this point
Copy the full SHA b11757eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36a5aa8 - Browse repository at this point
Copy the full SHA 36a5aa8View commit details -
name the trait in ambiguous-associated-items fully qualified suggestion
We have the trait at this point, so we can name it in the error message, rather than using "Trait" as a (potentially confusing) placeholder. Thanks to Yuki "@JohnTitor" Okushi for pointing out where to look (in the same file) for a closely related issue for ambiguous associated types (as opposed to items; that was rust-lang#59225, except that one won't be quite as easy to resolve, because we actually don't have the trait `DefId` at that point).
Configuration menu - View commit details
-
Copy full SHA for 6bb60ef - Browse repository at this point
Copy the full SHA 6bb60efView commit details
Commits on Jul 7, 2019
-
Rollup merge of rust-lang#61990 - llogiq:questionmark-test, r=QuietMi…
…sdreavus First question mark in doctest We have had `?` for `Result`s in doctests for some time, but so far haven't used them in doctests. With this PR, I want to start the de-`unwrap`ping of doctests – and the discussion on where to do so. There is one downside, which is that the code can no longer be copied into a plain `main()` method, on the other hand, there should be a workable error if one does this.
Configuration menu - View commit details
-
Copy full SHA for 719eeb2 - Browse repository at this point
Copy the full SHA 719eeb2View commit details -
Rollup merge of rust-lang#62379 - GuillaumeGomez:option-doc-links, r=…
…QuietMisdreavus Add missing links in Option documentation r? @rust-lang/docs
Configuration menu - View commit details
-
Copy full SHA for c512829 - Browse repository at this point
Copy the full SHA c512829View commit details -
Rollup merge of rust-lang#62438 - petrochenkov:buildwarn, r=Mark-Simu…
…lacrum rustbuild: Cleanup global lint settings Lint settings do not depend on `if let Some(target) = target` in any way, so they are moved out of that clause. Internal lints now respect `RUSTC_DENY_WARNINGS`. Crate name treatment is cleaned up a bit. cc rust-lang#61545 @flip1995 r? @Mark-Simulacrum
Configuration menu - View commit details
-
Copy full SHA for 037f568 - Browse repository at this point
Copy the full SHA 037f568View commit details -
Rollup merge of rust-lang#62455 - zackmdavis:name_trait_for_ambiguous…
…_assoc_item, r=petrochenkov name the trait in ambiguous-associated-items fully qualified suggestion We have the trait at this point, so we can name it in the error message, rather than using "Trait" as a (potentially confusing) placeholder. Thanks to Yuki "@JohnTitor" Okushi for pointing out where to look (in the same file) for a closely related issue for ambiguous associated types (as opposed to items; that was rust-lang#59225, except that one won't be quite as easy to resolve, because we actually don't have the trait `DefId` at that point). r? @petrochenkov
Configuration menu - View commit details
-
Copy full SHA for fb01170 - Browse repository at this point
Copy the full SHA fb01170View commit details