Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #62458

Merged
merged 9 commits into from
Jul 7, 2019
Merged

Rollup of 4 pull requests #62458

merged 9 commits into from
Jul 7, 2019

Commits on Jul 3, 2019

  1. Configuration menu
    Copy the full SHA
    ee05fc8 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2019

  1. Configuration menu
    Copy the full SHA
    02886e2 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2019

  1. Configuration menu
    Copy the full SHA
    b11757e View commit details
    Browse the repository at this point in the history
  2. Address review comments

    petrochenkov committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    36a5aa8 View commit details
    Browse the repository at this point in the history
  3. name the trait in ambiguous-associated-items fully qualified suggestion

    We have the trait at this point, so we can name it in the error
    message, rather than using "Trait" as a (potentially confusing)
    placeholder.
    
    Thanks to Yuki "@JohnTitor" Okushi for pointing out where to look (in
    the same file) for a closely related issue for ambiguous associated
    types (as opposed to items; that was rust-lang#59225, except that one won't be
    quite as easy to resolve, because we actually don't have the trait
    `DefId` at that point).
    zackmdavis committed Jul 6, 2019
    Configuration menu
    Copy the full SHA
    6bb60ef View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2019

  1. Rollup merge of rust-lang#61990 - llogiq:questionmark-test, r=QuietMi…

    …sdreavus
    
    First question mark in doctest
    
    We have had `?` for `Result`s in doctests for some time, but so far haven't used them in doctests. With this PR, I want to start the de-`unwrap`ping of doctests – and the discussion on where to do so.
    
    There is one downside, which is that the code can no longer be copied into a plain `main()` method, on the other hand, there should be a workable error if one does this.
    Centril authored Jul 7, 2019
    Configuration menu
    Copy the full SHA
    719eeb2 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#62379 - GuillaumeGomez:option-doc-links, r=…

    …QuietMisdreavus
    
    Add missing links in Option documentation
    
    r? @rust-lang/docs
    Centril authored Jul 7, 2019
    Configuration menu
    Copy the full SHA
    c512829 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#62438 - petrochenkov:buildwarn, r=Mark-Simu…

    …lacrum
    
    rustbuild: Cleanup global lint settings
    
    Lint settings do not depend on `if let Some(target) = target` in any way, so they are moved out of that clause.
    
    Internal lints now respect `RUSTC_DENY_WARNINGS`.
    
    Crate name treatment is cleaned up a bit.
    
    cc rust-lang#61545 @flip1995
    r? @Mark-Simulacrum
    Centril authored Jul 7, 2019
    Configuration menu
    Copy the full SHA
    037f568 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#62455 - zackmdavis:name_trait_for_ambiguous…

    …_assoc_item, r=petrochenkov
    
    name the trait in ambiguous-associated-items fully qualified suggestion
    
    We have the trait at this point, so we can name it in the error message, rather than using "Trait" as a (potentially confusing) placeholder.
    
    Thanks to Yuki "@JohnTitor" Okushi for pointing out where to look (in the same file) for a closely related issue for ambiguous associated types (as opposed to items; that was rust-lang#59225, except that one won't be
    quite as easy to resolve, because we actually don't have the trait `DefId` at that point).
    
    r? @petrochenkov
    Centril authored Jul 7, 2019
    Configuration menu
    Copy the full SHA
    fb01170 View commit details
    Browse the repository at this point in the history