-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 14 pull requests #62413
Rollup of 14 pull requests #62413
Commits on May 30, 2019
-
Optimize pointer alignment in utf8 validation
This uses (and reuses) the u8 arrays's inherent block alignment when checking whether the current index is block aligned. I initially thought that this would just move the expensive `align_offset` call out of the while loop and replace it with a subtraction and bitwise AND. But it appears this optimizes much better, too... before: https://rust.godbolt.org/z/WIPvWl after: https://rust.godbolt.org/z/-jBPoW https://github.com/jridgewell/faster-from_utf8/tree/pointer-alignment ``` test from_utf8_2_bytes_fast ... bench: 310 ns/iter (+/- 42) = 1290 MB/s test from_utf8_2_bytes_regular ... bench: 309 ns/iter (+/- 24) = 1294 MB/s test from_utf8_3_bytes_fast ... bench: 1,027 ns/iter (+/- 62) = 1168 MB/s test from_utf8_3_bytes_regular ... bench: 1,513 ns/iter (+/- 611) = 793 MB/s test from_utf8_4_bytes_fast ... bench: 1,788 ns/iter (+/- 26) = 1342 MB/s test from_utf8_4_bytes_regular ... bench: 1,907 ns/iter (+/- 181) = 1258 MB/s test from_utf8_all_bytes_fast ... bench: 3,463 ns/iter (+/- 97) = 1155 MB/s test from_utf8_all_bytes_regular ... bench: 4,083 ns/iter (+/- 89) = 979 MB/s test from_utf8_ascii_fast ... bench: 88 ns/iter (+/- 4) = 28988 MB/s test from_utf8_ascii_regular ... bench: 88 ns/iter (+/- 8) = 28988 MB/s test from_utf8_cyr_fast ... bench: 7,707 ns/iter (+/- 531) = 665 MB/s test from_utf8_cyr_regular ... bench: 8,202 ns/iter (+/- 135) = 625 MB/s test from_utf8_enwik8_fast ... bench: 1,135,756 ns/iter (+/- 84,450) = 8804 MB/s test from_utf8_enwik8_regular ... bench: 1,145,468 ns/iter (+/- 79,601) = 8730 MB/s test from_utf8_jawik10_fast ... bench: 12,723,844 ns/iter (+/- 473,247) = 785 MB/s test from_utf8_jawik10_regular ... bench: 13,384,596 ns/iter (+/- 666,997) = 747 MB/s test from_utf8_mixed_fast ... bench: 2,321 ns/iter (+/- 123) = 2081 MB/s test from_utf8_mixed_regular ... bench: 2,702 ns/iter (+/- 408) = 1788 MB/s test from_utf8_mostlyasc_fast ... bench: 249 ns/iter (+/- 10) = 14666 MB/s test from_utf8_mostlyasc_regular ... bench: 276 ns/iter (+/- 5) = 13231 MB/s ```
Configuration menu - View commit details
-
Copy full SHA for 3d2c4ff - Browse repository at this point
Copy the full SHA 3d2c4ffView commit details
Commits on Jun 24, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7d0a952 - Browse repository at this point
Copy the full SHA 7d0a952View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37f09cb - Browse repository at this point
Copy the full SHA 37f09cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 084c829 - Browse repository at this point
Copy the full SHA 084c829View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65c81de - Browse repository at this point
Copy the full SHA 65c81deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08b81f2 - Browse repository at this point
Copy the full SHA 08b81f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7de6f54 - Browse repository at this point
Copy the full SHA 7de6f54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e087cd - Browse repository at this point
Copy the full SHA 8e087cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0625a3 - Browse repository at this point
Copy the full SHA d0625a3View commit details
Commits on Jun 26, 2019
-
This bumps our linked OpenSSL version from 1.1.1a to 1.1.1c, picking up some various bug fixes and minor security issue fixes.
Configuration menu - View commit details
-
Copy full SHA for 16b37b5 - Browse repository at this point
Copy the full SHA 16b37b5View commit details
Commits on Jun 29, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e475539 - Browse repository at this point
Copy the full SHA e475539View commit details -
Configuration menu - View commit details
-
Copy full SHA for e32b8eb - Browse repository at this point
Copy the full SHA e32b8ebView commit details
Commits on Jun 30, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0ffb643 - Browse repository at this point
Copy the full SHA 0ffb643View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4e7eb2 - Browse repository at this point
Copy the full SHA e4e7eb2View commit details
Commits on Jul 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2bad604 - Browse repository at this point
Copy the full SHA 2bad604View commit details -
Configuration menu - View commit details
-
Copy full SHA for 576369b - Browse repository at this point
Copy the full SHA 576369bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45e7ba9 - Browse repository at this point
Copy the full SHA 45e7ba9View commit details
Commits on Jul 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2e47fc3 - Browse repository at this point
Copy the full SHA 2e47fc3View commit details
Commits on Jul 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e45bbaf - Browse repository at this point
Copy the full SHA e45bbafView commit details -
Remove compile-pass from compiletest
Also change annotations in some tests
Configuration menu - View commit details
-
Copy full SHA for 6b75d08 - Browse repository at this point
Copy the full SHA 6b75d08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7987719 - Browse repository at this point
Copy the full SHA 7987719View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f7ba51 - Browse repository at this point
Copy the full SHA 4f7ba51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37d7e1f - Browse repository at this point
Copy the full SHA 37d7e1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6131b2 - Browse repository at this point
Copy the full SHA c6131b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01e0d83 - Browse repository at this point
Copy the full SHA 01e0d83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 675bfb6 - Browse repository at this point
Copy the full SHA 675bfb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6030ff - Browse repository at this point
Copy the full SHA a6030ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3fcf28 - Browse repository at this point
Copy the full SHA c3fcf28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3adad33 - Browse repository at this point
Copy the full SHA 3adad33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f035ba - Browse repository at this point
Copy the full SHA 7f035baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61ddf5e - Browse repository at this point
Copy the full SHA 61ddf5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4b30f4 - Browse repository at this point
Copy the full SHA f4b30f4View commit details -
Remove
solve_nll_region_constraints
measurements from `-Ztime-passe……s` output. Because it pollutes the output with hundreds or thousands of uninteresting lines for which the time duration is always(?) 0.000s.
Configuration menu - View commit details
-
Copy full SHA for 90419d3 - Browse repository at this point
Copy the full SHA 90419d3View commit details -
Add a "total" measurement to -Ztime-passes.
This is useful for getting the total compilation time at the end. To do this, the patch changes `print_time_passes_entry` to not increment the depth, which means that `print_time_passes_entry_internal` is no longer needed.
Configuration menu - View commit details
-
Copy full SHA for 87b103d - Browse repository at this point
Copy the full SHA 87b103dView commit details
Commits on Jul 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 050a71b - Browse repository at this point
Copy the full SHA 050a71bView commit details -
Lint on invalid values passed to x.py --warnings
This also introduces support for `--warnings allow` and fixes --warnings being overridden by the configuration file, config.toml.
Configuration menu - View commit details
-
Copy full SHA for f01e5e6 - Browse repository at this point
Copy the full SHA f01e5e6View commit details -
Rollup merge of rust-lang#61339 - jridgewell:pointer-alignment, r=Bur…
…ntSushi Optimize pointer alignment in utf8 validation This uses (and reuses) the u8 arrays's inherent block alignment when checking whether the current index is block aligned. I initially thought that this would just move the expensive `align_offset` call out of the while loop and replace it with a subtraction and bitwise AND. But it appears this optimizes much better, too... before: https://rust.godbolt.org/z/WIPvWl after: https://rust.godbolt.org/z/-jBPoW ## Benchmarks https://github.com/jridgewell/faster-from_utf8/tree/pointer-alignment ``` test from_utf8_2_bytes_fast ... bench: 310 ns/iter (+/- 42) = 1290 MB/s test from_utf8_2_bytes_regular ... bench: 309 ns/iter (+/- 24) = 1294 MB/s test from_utf8_3_bytes_fast ... bench: 1,027 ns/iter (+/- 62) = 1168 MB/s test from_utf8_3_bytes_regular ... bench: 1,513 ns/iter (+/- 611) = 793 MB/s test from_utf8_4_bytes_fast ... bench: 1,788 ns/iter (+/- 26) = 1342 MB/s test from_utf8_4_bytes_regular ... bench: 1,907 ns/iter (+/- 181) = 1258 MB/s test from_utf8_all_bytes_fast ... bench: 3,463 ns/iter (+/- 97) = 1155 MB/s test from_utf8_all_bytes_regular ... bench: 4,083 ns/iter (+/- 89) = 979 MB/s test from_utf8_ascii_fast ... bench: 88 ns/iter (+/- 4) = 28988 MB/s test from_utf8_ascii_regular ... bench: 88 ns/iter (+/- 8) = 28988 MB/s test from_utf8_cyr_fast ... bench: 7,707 ns/iter (+/- 531) = 665 MB/s test from_utf8_cyr_regular ... bench: 8,202 ns/iter (+/- 135) = 625 MB/s test from_utf8_enwik8_fast ... bench: 1,135,756 ns/iter (+/- 84,450) = 8804 MB/s test from_utf8_enwik8_regular ... bench: 1,145,468 ns/iter (+/- 79,601) = 8730 MB/s test from_utf8_jawik10_fast ... bench: 12,723,844 ns/iter (+/- 473,247) = 785 MB/s test from_utf8_jawik10_regular ... bench: 13,384,596 ns/iter (+/- 666,997) = 747 MB/s test from_utf8_mixed_fast ... bench: 2,321 ns/iter (+/- 123) = 2081 MB/s test from_utf8_mixed_regular ... bench: 2,702 ns/iter (+/- 408) = 1788 MB/s test from_utf8_mostlyasc_fast ... bench: 249 ns/iter (+/- 10) = 14666 MB/s test from_utf8_mostlyasc_regular ... bench: 276 ns/iter (+/- 5) = 13231 MB/s ```
Configuration menu - View commit details
-
Copy full SHA for c57637e - Browse repository at this point
Copy the full SHA c57637eView commit details -
Rollup merge of rust-lang#61545 - flip1995:internal_lints, r=oli-obk
Implement another internal lints cc rust-lang#49509 This adds ~~two~~ one internal lint~~s~~: 1. LINT_PASS_IMPL_WITHOUT_MACRO: Make sure, that the `{declare,impl}_lint_pass` macro is used to implement lint passes. cc rust-lang#59669 2. ~~USAGE_OF_TYCTXT_AND_SPAN_ARGS: item 2 on the list in rust-lang#49509~~ ~~With 2. I wasn't sure, if this lint should be applied everywhere. That means a careful review of 0955835 would be great. Also 73fb9b4 allows this lint on some functions. Should I also apply this lint there?~~ TODO (not directly relevant for review): - [ ] rust-lang#59316 (comment) (not sure yet, if this works or how to query for `rustc_private`, since it's not in [`Features`](https://doc.rust-lang.org/nightly/nightly-rustc/syntax/feature_gate/struct.Features.html) 🤔 cc @eddyb) - [x] rust-lang#61735 (comment) - [x] Check explicitly for the `{declare,impl}_lint_pass!` macros r? @oli-obk
Configuration menu - View commit details
-
Copy full SHA for cf5e9e5 - Browse repository at this point
Copy the full SHA cf5e9e5View commit details -
Rollup merge of rust-lang#62110 - nnethercote:improve-Ztime-passes, r…
…=Zoxc Improve -Ztime-passes Two improvements that make `-Ztime-passes` more useful. r? @Zoxc
Configuration menu - View commit details
-
Copy full SHA for 3ee2128 - Browse repository at this point
Copy the full SHA 3ee2128View commit details -
Rollup merge of rust-lang#62133 - petrochenkov:norustc, r=eddyb
Feature gate `rustc` attributes harder Fixes rust-lang#62116
Configuration menu - View commit details
-
Copy full SHA for de03018 - Browse repository at this point
Copy the full SHA de03018View commit details -
Rollup merge of rust-lang#62151 - alexcrichton:update-openssl, r=Mark…
…-Simulacrum Update linked OpenSSL version This bumps our linked OpenSSL version from 1.1.1a to 1.1.1c, picking up some various bug fixes and minor security issue fixes.
Configuration menu - View commit details
-
Copy full SHA for 1bd67c4 - Browse repository at this point
Copy the full SHA 1bd67c4View commit details -
Rollup merge of rust-lang#62158 - christianpoveda:ecx-memory-extra, r…
…=RalfJung Add MemoryExtra in InterpretCx constructor params This is to avoid modifying `MemoryExtra` inside `InterpretCx` after initialization. Related miri PR: rust-lang/miri#792 r? @RalfJung
Configuration menu - View commit details
-
Copy full SHA for b53ce9e - Browse repository at this point
Copy the full SHA b53ce9eView commit details -
Rollup merge of rust-lang#62168 - ljedrz:the_culmination_of_hiridific…
…ation, r=Zoxc The (almost) culmination of HirIdification It's finally over. This PR removes old `FIXME`s and renames some functions so that the `HirId` variant has the shorter name. All that remains (and rightfully so) is stuff in `resolve`, `save_analysis` and (as far as I can tell) in a few places where we can't replace `NodeId` with `HirId`.
Configuration menu - View commit details
-
Copy full SHA for 3525eff - Browse repository at this point
Copy the full SHA 3525effView commit details -
Rollup merge of rust-lang#62193 - matthewjasper:dynamic-drop-async, r…
…=Centril Create async version of the dynamic-drop test Some of the tests in dynamic-drop have been cut: * The tests that are just simpler versions of other tests - these tests are already fairly slow due to all of the unwinding and async functions have more control flow paths than normal functions. * The union test - it's for an unstable feature that has an RFC to remove it. * The generator test - there aren't async generators yet. * The tests that show values being leaked - these can be added once the issue is fixed. r? @Centril cc rust-lang#62121 @cramertj
Configuration menu - View commit details
-
Copy full SHA for 7a595ee - Browse repository at this point
Copy the full SHA 7a595eeView commit details -
Rollup merge of rust-lang#62296 - RalfJung:memalign, r=alexcrichton
request at least ptr-size alignment from posix_memalign Fixes rust-lang#62251
Configuration menu - View commit details
-
Copy full SHA for c2b89eb - Browse repository at this point
Copy the full SHA c2b89ebView commit details -
Rollup merge of rust-lang#62369 - JohnTitor:remove-compile-pass, r=pe…
…trochenkov Remove `compile-pass` from compiletest This is a part of rust-lang#62277. Removes `compile-pass` from compiletest (and modify some tests' annotations). r? @Centril
Configuration menu - View commit details
-
Copy full SHA for e142410 - Browse repository at this point
Copy the full SHA e142410View commit details -
Rollup merge of rust-lang#62380 - eddyb:x64-sysv-regs, r=nagisa
rustc_target: avoid negative register counts in the SysV x86_64 ABI. Because `needed_{int,sse}` and `{int,sse}_regs` were only used with integer literals, they were inferred to `i32` and `{int,sse}_regs` could therefore be negative. There was a check which prevented that, but *only* for aggregate arguments, not scalars. Fixes rust-lang#62350. r? @nagisa or @rkruppe
Configuration menu - View commit details
-
Copy full SHA for 65a2db3 - Browse repository at this point
Copy the full SHA 65a2db3View commit details -
Rollup merge of rust-lang#62381 - pawroman:fix_typo_in_write_vectored…
…, r=Centril Fix a typo in Write::write_vectored docs Fixed what seems like a typo. "Copy to from" is extremely confusing.
Configuration menu - View commit details
-
Copy full SHA for aacf5a8 - Browse repository at this point
Copy the full SHA aacf5a8View commit details -
Rollup merge of rust-lang#62390 - markebrooks:encourage, r=Centril
Update README.md Let's not discourage contributions.
Configuration menu - View commit details
-
Copy full SHA for 83ba37c - Browse repository at this point
Copy the full SHA 83ba37cView commit details -
Rollup merge of rust-lang#62406 - Mark-Simulacrum:warnings-lint, r=Ra…
…lfJung Lint on invalid values passed to x.py --warnings This also introduces support for `--warnings allow` and fixes --warnings being overridden by the configuration file, config.toml. Fixes rust-lang#62402 r? @RalfJung
Configuration menu - View commit details
-
Copy full SHA for 76f9f4f - Browse repository at this point
Copy the full SHA 76f9f4fView commit details