Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linkage diagnostic so it doesn't ICE for external crates #61231

Merged
merged 5 commits into from
May 30, 2019
Merged

Fix linkage diagnostic so it doesn't ICE for external crates #61231

merged 5 commits into from
May 30, 2019

Commits on May 27, 2019

  1. Move existing #[linkage] tests to a subdirectory where I can add mo… 

    …re tests.
    @pnkfelix
    pnkfelix committed May 27, 2019
    Configuration menu
    Copy the full SHA
    21aa149 View commit details
    Browse the repository at this point in the history

  2. Always supply span to check_and_apply_linkage, sidestepping need to a… 

    …dd `bug!`s to rustc.
    @pnkfelix
    pnkfelix committed May 27, 2019
    Configuration menu
    Copy the full SHA
    64edaec View commit details
    Browse the repository at this point in the history

  3. Refine the message to at least *mention* the attribute itself. 

    Update pre-existing test's diagnostic output accordingly.
    @pnkfelix
    pnkfelix committed May 27, 2019
    Configuration menu
    Copy the full SHA
    444f2ba View commit details
    Browse the repository at this point in the history

  4. Regression test for issue rust-lang#59548.

    @pnkfelix
    pnkfelix committed May 27, 2019
    Configuration menu
    Copy the full SHA
    4e60f53 View commit details
    Browse the repository at this point in the history

  5. Tests for external linkage symbol collision check. 

    Fix rust-lang#61232
    @pnkfelix
    pnkfelix committed May 27, 2019
    Configuration menu
    Copy the full SHA
    c8887ab View commit details
    Browse the repository at this point in the history