Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable] Fix an ICE that hid the related error message #61208

Closed
wants to merge 1 commit into from
Closed

[stable] Fix an ICE that hid the related error message #61208

wants to merge 1 commit into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 26, 2019

Opening as a separate PR because the master/beta fix won't apply cleanly

r? @pietroalbini

fixes #60989

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2019
@oli-obk oli-obk mentioned this pull request May 26, 2019
Merged
@Centril
Copy link
Contributor

Centril commented May 26, 2019

We already shipped 1.35.0 so why target stable?

@pietroalbini
Copy link
Member

This is for the stable-nominated I think. Blocked until a decision is made for an eventual point release.

@rustbot modify labels: S-blocked -S-waiting-on-review

@rustbot rustbot added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2019
@Centril Centril added T-release Relevant to the release subteam, which will review and decide on the PR/issue. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). stable-nominated Nominated for backporting to the compiler in the stable channel. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels May 26, 2019
@Centril
Copy link
Contributor

Centril commented May 26, 2019

Switching labels a bit to bring up on t-release's agenda. I think if we go ahead with a point release we'd also want to pack in other things.

@pietroalbini pietroalbini added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed T-release Relevant to the release subteam, which will review and decide on the PR/issue. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. stable-nominated Nominated for backporting to the compiler in the stable channel. labels May 26, 2019
@pietroalbini
Copy link
Member

The stable nomination is already in the original PR: #61189

@estebank
Copy link
Contributor

This hasn't landed in beta either, right @oli-obk?

@pietroalbini
Copy link
Member

@estebank this is already on beta -- #61602.

@pietroalbini
Copy link
Member

Closing this, realistically we won't make a point release this close to 1.36.

@oli-obk oli-obk deleted the stable_ice branch March 16, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pietroalbini pietroalbini

Labels
S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @rust-highfive @Centril @pietroalbini @estebank @rustbot