Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #60794

Merged
merged 12 commits into from
May 14, 2019
Merged

Rollup of 5 pull requests #60794

merged 12 commits into from
May 14, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented May 13, 2019

Successful merges:

Failed merges:

r? @ghost

matthewjasper and others added 12 commits April 22, 2019 18:50
Stops unavoidable `missing_docs` warning/error on proc-macro crates.
Resolves rust-lang#42008.
impl_trait_in_bindings is not yet complete and can lead to compiler crashes.

Fixes rust-lang#60764.
…=pnkfelix

Explain error when yielding a reference to a local variable

Closes rust-lang#56508
coretest: Downgrade deny to warn

The `deny` causes a build failure in https://github.com/RalfJung/miri-test-libstd. Since we use `-D warnings` for rustc builds, `warn` should be enough to lead to compile errors here, without impeding external builds.
…s, r=alexcrichton

Add #[doc(hidden)] attribute on compiler generated module.

Resolves unavoidable `missing_docs` warning/error on proc-macro crates.
Resolves rust-lang#42008.

Changes not yet tested locally, however I wanted to submit first since `rustc` takes forever to compile.
… r=matthewjasper

Use `delay_span_bug` for error cases when checking `AnonConst` parent

Fixes rust-lang#60704.
Fixes rust-lang#60650.
add impl_trait_in_bindings to INCOMPLETE_FEATURES

impl_trait_in_bindings is not yet complete and can lead to compiler crashes.

Fixes rust-lang#60764.
@Centril
Copy link
Contributor Author

Centril commented May 13, 2019

@bors r+ p=5 rollup=never

@bors
Copy link
Contributor

bors commented May 13, 2019

📌 Commit b698609 has been approved by Centril

@bors
Copy link
Contributor

bors commented May 13, 2019

🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 13, 2019
@Centril
Copy link
Contributor Author

Centril commented May 14, 2019

@bors treeclosed-

@bors
Copy link
Contributor

bors commented May 14, 2019

⌛ Testing commit b698609 with merge 80e7cde...

bors added a commit that referenced this pull request May 14, 2019
Rollup of 5 pull requests

Successful merges:

 - #60176 (Explain error when yielding a reference to a local variable)
 - #60201 (coretest: Downgrade deny to warn)
 - #60562 (Add #[doc(hidden)] attribute on compiler generated module.)
 - #60710 (Use `delay_span_bug` for error cases when checking `AnonConst` parent)
 - #60770 (add impl_trait_in_bindings to INCOMPLETE_FEATURES)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented May 14, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing 80e7cde to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 14, 2019
@bors bors merged commit b698609 into rust-lang:master May 14, 2019
@Centril Centril deleted the rollup-vlguvns branch May 14, 2019 06:10
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants