Expand dynamic drop tests for cases in #47949 #60729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
matthewjasper
force-pushed
the
leak-after-into
branch
from
c62bf96
to
85caf26
Compare
nikomatsakis
requested changes
May 17, 2019
| let q = loop { | ||
| a.alloc(); | ||
| let r = a.alloc(); | ||
| break a.alloc_leaked(exceptions); |
There was a problem hiding this comment.
I'd prefer to have a FIXME here too -- something like
// FIXME(#XXX) we should not be leaking this, but we are
| // Creates a `Ptr<'_>` and checks that the allocated value is leaked if the | ||
| // `failing_op` is in the list of exception. | ||
| // | ||
| // FIXME (#47949) We shouldn't need this, but we are sometimes leaking |
There was a problem hiding this comment.
For some reason, I found this kind of confusing. Maybe something like this:
FIXME(#47949) -- Each use of this indicates a bug: basically, a value that winds up getting leaked but shouldn't be.
nikomatsakis
added
S-waiting-on-author
|
r=me -- @matthewjasper did you want to "FIXUP" that commit, thogh? |
matthewjasper
force-pushed
the
leak-after-into
branch
from
49304b7
to
6a9e68a
Compare
|
@bors r=nikomatsakis |
|
📌 Commit 6a9e68a has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 1, 2019
…komatsakis Expand dynamic drop tests for cases in rust-lang#47949 Adds test cases for rust-lang#47949
bors
added a commit
that referenced
this pull request
Jun 1, 2019
Rollup of 8 pull requests Successful merges: - #60729 (Expand dynamic drop tests for cases in #47949) - #61263 (Don't generate div inside header (h4/h3/h...) elements) - #61364 (Stabilize reverse_bits feature) - #61375 (Make "panic did not include expected string" message consistent) - #61387 (Remove ty::BrFresh and RegionConstraintCollector::new_bound) - #61389 (Remove GlobalArenas and use Arena instead) - #61391 (Doc comment fixes for `rustc::mir::interpret::InterpretCx`) - #61403 (Remove unnecessary `-Z continue-parse-after-error` from tests) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test cases for #47949