build dist-aarch64-linux with --enable-profiler #60476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This change should enable PGO to be used for aarch64-linux. Fixes rust-lang#57257.
froydnj
changed the title
|
@bors: r+ |
|
📌 Commit 2c371b2 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 3, 2019
…ichton build dist-aarch64-linux with --enable-profiler This change should enable PGO to be used for aarch64-linux. Fixes rust-lang#57257.
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 3, 2019
…ichton build dist-aarch64-linux with --enable-profiler This change should enable PGO to be used for aarch64-linux. Fixes rust-lang#57257.
bors
added a commit
that referenced
this pull request
May 5, 2019
build dist-aarch64-linux with --enable-profiler This change should enable PGO to be used for aarch64-linux. Fixes #57257.
|
☀️ Test successful - checks-travis, status-appveyor |
tiagolam
added a commit
to tiagolam/rust
that referenced
this pull request
Aug 28, 2020
Trying to build a Rust project with `-Zprofile` for target x86_64-unknown-linux-musl using rustc 1.46.0-nightly (346aec9 2020-07-11), installed with rustup, results in the following error. ``` export RUSTFLAGS="-Zprofile -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests -Cpanic=abort"export CARGO_INCREMENTAL=0$ cargo build --target=x86_64-unknown-linux-muslCompiling hello_world v0.1.0 (…)error[E0463]: can't find crate for `profiler_builtins` | = note: the compiler may have been built without the profiler runtime error: aborting due to previous error For more information about this error, try `rustc --explain E0463`.error: could not compile `hello_world`. To learn more, run the command again with --verbose. ``` `-Zprofile` is required here to enable grcov profiling. This is similar in nature to issue rust-lang#57257, which has been fixed in asimilar way at rust-lang#60476 . A fix for Android has also landed not long ago: rust-lang#70054 . Signed-off-by: Tiago Lam <[email protected]>
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 28, 2020
Build dist-x86_64-musl with --enable-profiler. Trying to build a Rust project with `-Zprofile` for target x86_64-unknown-linux-musl using rustc 1.46.0-nightly (346aec9 2020-07-11), installed with rustup, results in the following error. ``` export RUSTFLAGS="-Zprofile -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests -Cpanic=abort"export CARGO_INCREMENTAL=0$ cargo build --target=x86_64-unknown-linux-muslCompiling hello_world v0.1.0 (…)error[E0463]: can't find crate for `profiler_builtins` | = note: the compiler may have been built without the profiler runtime error: aborting due to previous error For more information about this error, try `rustc --explain E0463`.error: could not compile `hello_world`. To learn more, run the command again with --verbose. ``` `-Zprofile` is required here to enable grcov profiling. This is similar in nature to issue rust-lang#57257, which has been fixed in asimilar way at rust-lang#60476 . A fix for Android has also landed not long ago: rust-lang#70054 . Signed-off-by: Tiago Lam <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should enable PGO to be used for aarch64-linux.
Fixes #57257.