Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Clippy #60158

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Update Clippy #60158

merged 1 commit into from
Apr 22, 2019

Conversation

Xanewok
Copy link
Member

@Xanewok Xanewok commented Apr 21, 2019

Fixes fallout from #60124.
Closes #60154.

r? @oli-obk
cc @matthiaskrgr

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2019
@matthiaskrgr
Copy link
Member

I would personally like to have rust-lang/rust-clippy#4013 included (it's waiting for CI right now) to prevent false positives.

with that included r=me if that is possible :p

@Xanewok
Copy link
Member Author

Xanewok commented Apr 21, 2019

Will do, please ping me when/if that lands

@matthiaskrgr
Copy link
Member

@Xanewok ping, rust-lang/rust-clippy#4013 was merged.

@Xanewok
Update Clippy
f01015d 
Fixes fallout from rust-lang#60124.
Closes rust-lang#60154.
@Xanewok
Copy link
Member Author

Xanewok commented Apr 21, 2019

That was fast, thanks!

@bors r=matthiaskrgr p=1

@bors
Copy link
Contributor

bors commented Apr 21, 2019

📌 Commit f01015d has been approved by matthiaskrgr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2019
@bors
Copy link
Contributor

bors commented Apr 21, 2019

⌛ Testing commit f01015d with merge 247b505...

bors added a commit that referenced this pull request Apr 21, 2019
@bors
Auto merge of #60158 - Xanewok:update-clippy, r=matthiaskrgr
247b505 
Update Clippy

Fixes fallout from #60124.
Closes #60154.

r? @oli-obk
cc @matthiaskrgr
@Xanewok Xanewok mentioned this pull request Apr 22, 2019
Merged
@bors
Copy link
Contributor

bors commented Apr 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: matthiaskrgr
Pushing 247b505 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 22, 2019
@bors bors merged commit f01015d into rust-lang:master Apr 22, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #60158!

Tested on commit 247b505.
Direct link to PR: #60158

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 22, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#60158!
6442cba 
Tested on commit rust-lang/rust@247b505.
Direct link to PR: <rust-lang/rust#60158>

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
@Xanewok Xanewok deleted the update-clippy branch April 22, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rls no longer builds after rust-lang/rust#60124
5 participants
@Xanewok @rust-highfive @matthiaskrgr @bors @oli-obk