Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #59942

Closed
wants to merge 30 commits into from
Closed

Commits on Apr 7, 2019

  1. Configuration menu
    Copy the full SHA
    442bef7 View commit details
    Browse the repository at this point in the history
  2. fix tests

    RalfJung committed Apr 7, 2019
    Configuration menu
    Copy the full SHA
    0c45546 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    83dcc96 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    be83bd5 View commit details
    Browse the repository at this point in the history
  5. Add test with current behaviour.

    This commit adds a test demonstrating the current behaviour when a macro
    defined in a module with the `#[macro_export]` is imported from the
    module rather than the crate root.
    davidtwco committed Apr 7, 2019
    Configuration menu
    Copy the full SHA
    126ac9e View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. Configuration menu
    Copy the full SHA
    724ca05 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a35b7e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8861232 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Configuration menu
    Copy the full SHA
    7b1df42 View commit details
    Browse the repository at this point in the history
  2. Suggest macro import from crate root.

    This commit suggests importing a macro from the root of a crate as the
    intent may have been to import a macro from the definition location that
    was annotated with `#[macro_export]`.
    davidtwco committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    d84907b View commit details
    Browse the repository at this point in the history
  3. Handle renamed imports.

    This commit extends the suggestion to handle imports that are aliased to
    another name.
    davidtwco committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    d589cf9 View commit details
    Browse the repository at this point in the history
  4. Handle edge cases.

    This commit introduces more dirty span manipulation into the compiler
    in order to handle the various edge cases in moving/renaming the macro
    import so it is at the root of the import.
    davidtwco committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    7c95540 View commit details
    Browse the repository at this point in the history
  5. Improve robustness of nested check.

    This commit removes the assumption that the start of a use statement
    will always be on one line with a single space - which was silly in the
    first place.
    davidtwco committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    137ffa1 View commit details
    Browse the repository at this point in the history
  6. Switch to multipart suggestions.

    This commit changes the suggestion so that it is split into multiple
    parts in an effort to reduce the impact the applied suggestion could
    have on formatting.
    davidtwco committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    5158063 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Revert PR rust-lang#59401 to fix issue rust-lang#59652 (a stable-to-b…

    …eta regression).
    
    This is result of squashing two revert commits:
    
    Revert "compile all crates under test w/ -Zemit-stack-sizes"
    
    This reverts commit 7d365cf.
    
    Revert "bootstrap: build compiler-builtins with -Z emit-stack-sizes"
    
    This reverts commit 8b8488c.
    pnkfelix committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    633fc9e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    796e6e3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4f28431 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7e62052 View commit details
    Browse the repository at this point in the history
  5. Make check_name generic

    Zoxc committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    0e26063 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9c63475 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    856c8a0 View commit details
    Browse the repository at this point in the history
  8. Use colon for keyword defs

    Zoxc committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    b5f246a View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2019

  1. Rollup merge of rust-lang#59655 - Zoxc:symbols, r=petrochenkov

    Use a proc macro to declare preallocated symbols
    
    r? @petrochenkov
    Centril authored Apr 13, 2019
    Configuration menu
    Copy the full SHA
    520f58a View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#59769 - RalfJung:compiletest-normalization,…

    … r=alexcrichton
    
    compiletest normalization: preserve non-JSON lines such as ICEs
    
    Currently, every non-JSON line from stderr gets normalized away when compiletest normalizes the output. In particular, ICEs get normalized to the empty output. That does not seem desirable, so this changes normalization to preserve non-JSON lines instead.
    
    Also see Manishearth/compiletest-rs#169: because of that bug, Miri currently *looks* green in the toolstate, but some tests ICE. That same bug is likely no longer present in latest compiletest because the error code gets checked separately, but it still seems like a good idea to also make sure that ICEs are considered stderr output:
    This change found an accidental user-visible `error!` in CTFE validation (fixed), and a non-deterministic panic when there are two `main` symbols (not fixed, no idea where this comes from). Both got missed before because non-JSON output got ignored.
    Centril authored Apr 13, 2019
    Configuration menu
    Copy the full SHA
    1d8905a View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#59776 - GuillaumeGomez:apply-resource-suffi…

    …x, r=QuietMisdreavus
    
    Apply resource-suffix to search-index and source-files scripts as well
    
    Fixes rust-lang#59771.
    
    r? @QuietMisdreavus
    Centril authored Apr 13, 2019
    Configuration menu
    Copy the full SHA
    93cfaab View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#59784 - davidtwco:issue-59764, r=estebank

    Suggest importing macros from the crate root
    
    Fixes rust-lang#59764.
    
    r? @estebank
    cc @varkor
    Centril authored Apr 13, 2019
    Configuration menu
    Copy the full SHA
    ae90d8d View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#59812 - michaelwoerister:profile-gen-msvc-i…

    …mp, r=alexcrichton
    
    Exclude profiler-generated symbols from MSVC __imp_-symbol workaround.
    
    LLVM's profiling instrumentation adds a few symbols that are used by the profiler runtime. Since these show up as globals in the LLVM IR, the compiler generates `dllimport`-related `__imp_` stubs for them. This can lead to linker errors because the instrumentation symbols have weak linkage or are in a comdat section, but the `__imp_` stubs aren't.
    
    Instead of trying to replicate the linkage/comdat setup for the stubs, this PR just excludes the profiler-related symbols from stub-generation since they aren't supposed to be referenced via `__declspec(dllimport)` anywhere anyway.
    
    r? @alexcrichton
    
    EDIT: I considered making this more general, i.e. inferring from the symbol name if it is a Rust symbol or not. But then I figured out that that would yield false negatives for `#[no_mangle]` et al, so I went with a blacklist approach.
    Centril authored Apr 13, 2019
    Configuration menu
    Copy the full SHA
    dbe8ea0 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#59874 - michaelwoerister:pgo-updates-1, r=c…

    …ramertj
    
    Clean up handling of `-Z pgo-gen` commandline option.
    
    This PR adapts the `-Z pgo-gen` flag to how Clang and GCC handle the corresponding `-fprofile-generate` flag. In particular, the flag now optionally takes a directory to place the profiling data in and allows to omit the argument (instead of having to pass an empty string).
    Centril authored Apr 13, 2019
    Configuration menu
    Copy the full SHA
    09dee29 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#59890 - GuillaumeGomez:empty-json-variables…

    …, r=QuietMisdreavus
    
    Don't generate empty json variables
    
    r? @rust-lang/rustdoc
    Centril authored Apr 13, 2019
    Configuration menu
    Copy the full SHA
    5518a19 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#59911 - pnkfelix:revert-pr-59401-to-fix-emi…

    …t-stack-sizes-gc-sections-ld-gold-bug, r=alexcrichton
    
    Revert "compile crates under test w/ -Zemit-stack-sizes"
    
    Revert PR rust-lang#59401 to fix issue rust-lang#59652 (a stable-to-beta regression).
    
    This is result of squashing two revert commits:
    
    Revert "compile all crates under test w/ -Zemit-stack-sizes"
    
    This reverts commit 7d365cf.
    
    Revert "bootstrap: build compiler-builtins with -Z emit-stack-sizes"
    
    This reverts commit 8b8488c.
    
    ----
    
    (My intention is that someone can re-add this code again later, either after the `ld.gold` issue itself is fixed, or with safe-guards to check whether `ld.gold` is in use and then issuing warnings about the problems here when they arise.)
    Centril authored Apr 13, 2019
    Configuration menu
    Copy the full SHA
    6319184 View commit details
    Browse the repository at this point in the history