-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #59942
Rollup of 8 pull requests #59942
Commits on Apr 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 442bef7 - Browse repository at this point
Copy the full SHA 442bef7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c45546 - Browse repository at this point
Copy the full SHA 0c45546View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83dcc96 - Browse repository at this point
Copy the full SHA 83dcc96View commit details -
Configuration menu - View commit details
-
Copy full SHA for be83bd5 - Browse repository at this point
Copy the full SHA be83bd5View commit details -
Add test with current behaviour.
This commit adds a test demonstrating the current behaviour when a macro defined in a module with the `#[macro_export]` is imported from the module rather than the crate root.
Configuration menu - View commit details
-
Copy full SHA for 126ac9e - Browse repository at this point
Copy the full SHA 126ac9eView commit details
Commits on Apr 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 724ca05 - Browse repository at this point
Copy the full SHA 724ca05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a35b7e - Browse repository at this point
Copy the full SHA 3a35b7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8861232 - Browse repository at this point
Copy the full SHA 8861232View commit details
Commits on Apr 11, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7b1df42 - Browse repository at this point
Copy the full SHA 7b1df42View commit details -
Suggest macro import from crate root.
This commit suggests importing a macro from the root of a crate as the intent may have been to import a macro from the definition location that was annotated with `#[macro_export]`.
Configuration menu - View commit details
-
Copy full SHA for d84907b - Browse repository at this point
Copy the full SHA d84907bView commit details -
This commit extends the suggestion to handle imports that are aliased to another name.
Configuration menu - View commit details
-
Copy full SHA for d589cf9 - Browse repository at this point
Copy the full SHA d589cf9View commit details -
This commit introduces more dirty span manipulation into the compiler in order to handle the various edge cases in moving/renaming the macro import so it is at the root of the import.
Configuration menu - View commit details
-
Copy full SHA for 7c95540 - Browse repository at this point
Copy the full SHA 7c95540View commit details -
Improve robustness of nested check.
This commit removes the assumption that the start of a use statement will always be on one line with a single space - which was silly in the first place.
Configuration menu - View commit details
-
Copy full SHA for 137ffa1 - Browse repository at this point
Copy the full SHA 137ffa1View commit details -
Switch to multipart suggestions.
This commit changes the suggestion so that it is split into multiple parts in an effort to reduce the impact the applied suggestion could have on formatting.
Configuration menu - View commit details
-
Copy full SHA for 5158063 - Browse repository at this point
Copy the full SHA 5158063View commit details
Commits on Apr 12, 2019
-
Revert PR rust-lang#59401 to fix issue rust-lang#59652 (a stable-to-b…
Configuration menu - View commit details
-
Copy full SHA for 633fc9e - Browse repository at this point
Copy the full SHA 633fc9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 796e6e3 - Browse repository at this point
Copy the full SHA 796e6e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f28431 - Browse repository at this point
Copy the full SHA 4f28431View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e62052 - Browse repository at this point
Copy the full SHA 7e62052View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e26063 - Browse repository at this point
Copy the full SHA 0e26063View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c63475 - Browse repository at this point
Copy the full SHA 9c63475View commit details -
Configuration menu - View commit details
-
Copy full SHA for 856c8a0 - Browse repository at this point
Copy the full SHA 856c8a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5f246a - Browse repository at this point
Copy the full SHA b5f246aView commit details
Commits on Apr 13, 2019
-
Rollup merge of rust-lang#59655 - Zoxc:symbols, r=petrochenkov
Use a proc macro to declare preallocated symbols r? @petrochenkov
Configuration menu - View commit details
-
Copy full SHA for 520f58a - Browse repository at this point
Copy the full SHA 520f58aView commit details -
Rollup merge of rust-lang#59769 - RalfJung:compiletest-normalization,…
… r=alexcrichton compiletest normalization: preserve non-JSON lines such as ICEs Currently, every non-JSON line from stderr gets normalized away when compiletest normalizes the output. In particular, ICEs get normalized to the empty output. That does not seem desirable, so this changes normalization to preserve non-JSON lines instead. Also see Manishearth/compiletest-rs#169: because of that bug, Miri currently *looks* green in the toolstate, but some tests ICE. That same bug is likely no longer present in latest compiletest because the error code gets checked separately, but it still seems like a good idea to also make sure that ICEs are considered stderr output: This change found an accidental user-visible `error!` in CTFE validation (fixed), and a non-deterministic panic when there are two `main` symbols (not fixed, no idea where this comes from). Both got missed before because non-JSON output got ignored.
Configuration menu - View commit details
-
Copy full SHA for 1d8905a - Browse repository at this point
Copy the full SHA 1d8905aView commit details -
Rollup merge of rust-lang#59776 - GuillaumeGomez:apply-resource-suffi…
…x, r=QuietMisdreavus Apply resource-suffix to search-index and source-files scripts as well Fixes rust-lang#59771. r? @QuietMisdreavus
Configuration menu - View commit details
-
Copy full SHA for 93cfaab - Browse repository at this point
Copy the full SHA 93cfaabView commit details -
Rollup merge of rust-lang#59784 - davidtwco:issue-59764, r=estebank
Suggest importing macros from the crate root Fixes rust-lang#59764. r? @estebank cc @varkor
Configuration menu - View commit details
-
Copy full SHA for ae90d8d - Browse repository at this point
Copy the full SHA ae90d8dView commit details -
Rollup merge of rust-lang#59812 - michaelwoerister:profile-gen-msvc-i…
…mp, r=alexcrichton Exclude profiler-generated symbols from MSVC __imp_-symbol workaround. LLVM's profiling instrumentation adds a few symbols that are used by the profiler runtime. Since these show up as globals in the LLVM IR, the compiler generates `dllimport`-related `__imp_` stubs for them. This can lead to linker errors because the instrumentation symbols have weak linkage or are in a comdat section, but the `__imp_` stubs aren't. Instead of trying to replicate the linkage/comdat setup for the stubs, this PR just excludes the profiler-related symbols from stub-generation since they aren't supposed to be referenced via `__declspec(dllimport)` anywhere anyway. r? @alexcrichton EDIT: I considered making this more general, i.e. inferring from the symbol name if it is a Rust symbol or not. But then I figured out that that would yield false negatives for `#[no_mangle]` et al, so I went with a blacklist approach.
Configuration menu - View commit details
-
Copy full SHA for dbe8ea0 - Browse repository at this point
Copy the full SHA dbe8ea0View commit details -
Rollup merge of rust-lang#59874 - michaelwoerister:pgo-updates-1, r=c…
…ramertj Clean up handling of `-Z pgo-gen` commandline option. This PR adapts the `-Z pgo-gen` flag to how Clang and GCC handle the corresponding `-fprofile-generate` flag. In particular, the flag now optionally takes a directory to place the profiling data in and allows to omit the argument (instead of having to pass an empty string).
Configuration menu - View commit details
-
Copy full SHA for 09dee29 - Browse repository at this point
Copy the full SHA 09dee29View commit details -
Rollup merge of rust-lang#59890 - GuillaumeGomez:empty-json-variables…
…, r=QuietMisdreavus Don't generate empty json variables r? @rust-lang/rustdoc
Configuration menu - View commit details
-
Copy full SHA for 5518a19 - Browse repository at this point
Copy the full SHA 5518a19View commit details -
Rollup merge of rust-lang#59911 - pnkfelix:revert-pr-59401-to-fix-emi…
…t-stack-sizes-gc-sections-ld-gold-bug, r=alexcrichton Revert "compile crates under test w/ -Zemit-stack-sizes" Revert PR rust-lang#59401 to fix issue rust-lang#59652 (a stable-to-beta regression). This is result of squashing two revert commits: Revert "compile all crates under test w/ -Zemit-stack-sizes" This reverts commit 7d365cf. Revert "bootstrap: build compiler-builtins with -Z emit-stack-sizes" This reverts commit 8b8488c. ---- (My intention is that someone can re-add this code again later, either after the `ld.gold` issue itself is fixed, or with safe-guards to check whether `ld.gold` is in use and then issuing warnings about the problems here when they arise.)
Configuration menu - View commit details
-
Copy full SHA for 6319184 - Browse repository at this point
Copy the full SHA 6319184View commit details