Revert "Auto merge of #57842 - gnzlbg:extract_libtest, r=gnzlbg" #59766
Conversation
|
r? @bluss (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @Manishearth cc @gnzlbg |
|
This LGTM. The change being reverted had many unforeseen consequences (EDIT: sysroot crates linkage, feature gates, the test crate being super special, ...), and while there are some paths to fix those, it is unclear whether those paths are the right thing to do. After hacking on-and-off on it for a couple of weeks, this is something that we definitely want to get right, and we won't be able to do so with confidence before the next release, so reverting the change is the best we can do. We probably want to try to do this again in the future, and come up with a solution that fixes everything that this one broke. But when doing so we should definitely involve the clippy maintainers in the process, so that we can make sure that landing this won't break clippy in an unrecoverable way like it happened here. And if it lands and clippy breaks, we should probably prioritize a revert right away to avoid clippy from being broken for weeks on nightly. |
|
@bors r+ p=10 high priority since we need to get this stuff through before the beta |
|
📌 Commit 28ea249 has been approved by |
bors
added
S-waiting-on-bors
|
I'll file an issue for moving libtest out that has a plan for doing this. |
Revert "Auto merge of #57842 - gnzlbg:extract_libtest, r=gnzlbg" This reverts commit 3eb4890, reversing changes made to 7a4df3b. This is, as best I can tell, a clean revert of #57842. It retains some interim changes, like moving `black_box`, and otherwise brings libtest back in as it was before removal.
|
☀️ Test successful - checks-travis, status-appveyor |
|
For the future, it would have been great to have this comment be part of the PR description so that it gets embedded into the git history. |
Revert compiletest hacks, use latest compiletest The libtest changes have been reverted, see rust-lang/rust#59766, Manishearth/compiletest-rs#174
This reverts commit 3eb4890, reversing
changes made to 7a4df3b.
This is, as best I can tell, a clean revert of #57842. It retains some interim changes, like moving
black_box, and otherwise brings libtest back in as it was before removal.