-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #59736
Rollup of 6 pull requests #59736
Conversation
This commit updates the wasi target with supported added in WebAssembly/wasi-libc#10. That function allows both C and Rust to cooperate in how preopened files are managed, enabling us to learn about propened files through the same interface. The `open_parent` function in the wasi `fs` module was updated to avoid its own initialization of a global preopened map and instead delegate to libc to perform this functionality. This should both be more robust into the future in terms of handling path logic as well as ensuring the propened map is correctly set up at process boot time. This does currently require some unfortunate allocations on our side, but if that becomes an issue we can always paper over those in time!
Co-Authored-By: XAMPPRocky <[email protected]>
Future-proof the Futures API cc rust-lang#59113, @carllerche, @rust-lang/libs r? @withoutboats
Updated RELEASES.md for 1.34.0 [Rendered](https://github.com/XAMPPRocky/rust/blob/master/RELEASES.md) This also corrects an omission in the previous 1.33.0 release. r? @Mark-Simulacrum cc @rust-lang/release
…crichton SGX target: Use linker option to avoid code CGU assignment kludge cc @VardhanThigle @faern
…=alexcrichton Remove invalid assertion back::link::from add_upstream_rust_crates(). This removes a misplaced assertion. The function containing the assertion is actually only ever called for upstream crates that are not considered for LTO, so we don't care whether upstream code has been merged in by LTO or not. Fixes rust-lang#59137 r? @alexcrichton
…-1, r=Centril Add missing tryfrom example r? @rust-lang/docs
wasi: Use shared API for preopened fds This commit updates the wasi target with supported added in WebAssembly/wasi-libc#10. That function allows both C and Rust to cooperate in how preopened files are managed, enabling us to learn about propened files through the same interface. The `open_parent` function in the wasi `fs` module was updated to avoid its own initialization of a global preopened map and instead delegate to libc to perform this functionality. This should both be more robust into the future in terms of handling path logic as well as ensuring the propened map is correctly set up at process boot time. This does currently require some unfortunate allocations on our side, but if that becomes an issue we can always paper over those in time!
@bors r+ p=6 |
📌 Commit 16fff93 has been approved by |
⌛ Testing commit 16fff93 with merge 317414facf606286f905e329c6185baac875a55e... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Successful merges:
Failed merges:
r? @ghost