Rollup of 11 pull requests #59513

Centril · 2019-03-29T01:41:03Z

Successful merges:

Combine all builtin late lints and make lint checking parallel #58019 (Combine all builtin late lints and make lint checking parallel)
Use track_errors instead of hand rolling #59358 (Use track_errors instead of hand rolling)
warn -> deny duplicate match bindings #59394 (warn -> deny duplicate match bindings)
bootstrap: build crates under libtest with -Z emit-stack-sizes #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes)
Visit path in walk_mac #59423 (Visit path in walk_mac)
musl: build toolchain libs with -fPIC #59468 (musl: build toolchain libs with -fPIC)
Use SmallVec in TokenStreamBuilder. #59476 (Use SmallVec in TokenStreamBuilder.)
Remove unnecessary with_globals calls #59496 (Remove unnecessary with_globals calls)
Use 'write_all' instead of 'write' in example code #59498 (Use 'write_all' instead of 'write' in example code)
Stablize {f32,f64}::copysign(). #59503 (Stablize {f32,f64}::copysign().)
Fix missed fn rename in #59284 #59511 (Fix missed fn rename in adjust MaybeUninit API to discussions #59284)

Failed merges:

This reduces by 12% the number of allocations done for a "clean incremental" of `webrender_api`, which reduces the instruction count by about 0.5%. It also reduces instruction counts by up to 1.4% across a range of rustc-perf benchmark runs.

@retep998

Combine all builtin late lints and make lint checking parallel Blocked on rust-lang#57293. Cuts runtime of late lint checking from 3.222s to 0.546s with 8 threads on `winapi` (@retep998 ;) ) r? @estebank

@oli-obk

Use `track_errors` instead of hand rolling Fixes rust-lang#59215 r? @oli-obk

@Centril

…Centril warn -> deny duplicate match bindings This is the next step of rust-lang#57742 r? @Centril - [x] Decide whether to go to deny-by-default or hard error. - My preference is to make this deny-by-default, rather than going straight to a hard error. The CI should fail because I haven't updated the ui test yet. I'll update it when we decide which to do. - [x] Update [test](https://github.com/mark-i-m/rust/blob/c25d6b83441e0c060ee0273193ef27b29e1318cd/src/test/ui/macros/macro-multiple-matcher-bindings.rs) - [ ] ~Crater run~ see rust-lang#59394 (comment)

@alexcrichton

…es, r=alexcrichton bootstrap: build crates under libtest with -Z emit-stack-sizes Please see the comment in the diff for the rationale. This change adds a `.stack_sizes` linker section to `libcompiler_builtins.rlib` but this section is discarded by the linker by default so it won't affect the binary size of most programs. It will, however, negatively affect the binary size of programs that link to a recent release of the `cortex-m-rt` crate because of the linker script that crate provides, but I have proposed a PR (rust-embedded/cortex-m-rt#186) to solve the problem (which I originally introduced :-)). This change does increase the size of the `libcompiler_builtins.rlib` artifact we distribute but the increase is in the order of (a few) KBs. r? @alexcrichton

…chenkov Visit path in `walk_mac` Fixes rust-lang#54110.

musl: build toolchain libs with -fPIC Fixes rust-lang#59411

@petrochenkov

…lVec, r=petrochenkov Use `SmallVec` in `TokenStreamBuilder`. This reduces by 12% the number of allocations done for a "clean incremental" of `webrender_api`, which reduces the instruction count by about 0.5%. r? @petrochenkov

Remove unnecessary with_globals calls

Use 'write_all' instead of 'write' in example code Using `write` without looping and checking the result can cause silent data loss. Example code should use `write_all` so that people don't copy this pattern. (Of course this does not include example code for docs that are specifically about the `write` method.)

…Sapin Stablize {f32,f64}::copysign(). Stablization PR for rust-lang#55169/rust-lang#58046. Please check if i'm doing it correctly. Is 1.35.0 good to go?

…=Centril Fix missed fn rename in rust-lang#59284 See rust-lang#59284 (comment)

Centril · 2019-03-29T01:41:21Z

@bors r+ p=11

bors · 2019-03-29T01:41:23Z

📌 Commit 456fa39 has been approved by Centril

bors · 2019-03-29T02:00:25Z

⌛ Testing commit 456fa39 with merge 41dee75...

@ghost

Rollup of 11 pull requests Successful merges: - #58019 (Combine all builtin late lints and make lint checking parallel) - #59358 (Use `track_errors` instead of hand rolling) - #59394 (warn -> deny duplicate match bindings) - #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes) - #59423 (Visit path in `walk_mac`) - #59468 (musl: build toolchain libs with -fPIC) - #59476 (Use `SmallVec` in `TokenStreamBuilder`.) - #59496 (Remove unnecessary with_globals calls) - #59498 (Use 'write_all' instead of 'write' in example code) - #59503 (Stablize {f32,f64}::copysign().) - #59511 (Fix missed fn rename in #59284) Failed merges: r? @ghost

fortanix-bot · 2019-03-29T02:12:46Z

Build failed for target x86_64-fortanix-unknown-sgx - status

cc @jethrogb

jethrogb · 2019-03-29T04:59:15Z

Disregard - SGX failure is a problem with the CI

bors · 2019-03-29T05:00:53Z

💔 Test failed - checks-travis

rust-highfive · 2019-03-29T05:00:55Z

The job dist-x86_64-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:01:41] + OUTPUT=/usr/local
[00:01:41] + shift
[00:01:41] + export 'CFLAGS=-fPIC -Wa,-mrelax-relocations=no'
[00:01:41] + CFLAGS='-fPIC -Wa,-mrelax-relocations=no'
[00:01:41] + git clone https://github.com/richfelker/musl-cross-make -b v0.9.7
[00:01:41] Cloning into 'musl-cross-make'...
[00:01:41] Note: checking out 'b85e29c00d35c8c8c196d6713505b837816ad47f'.
[00:01:41] 
[00:01:41] You are in 'detached HEAD' state. You can look around, make experimental
[00:01:41] changes and commit them, and you can discard any commits you make in this
[00:01:41] state without impacting any branches by performing another checkout.
[00:01:41] If you want to create a new branch to retain commits you create, you may
[00:01:41] If you want to create a new branch to retain commits you create, you may
[00:01:41] do so (now or later) by using -b with the checkout command again. Example:
[00:01:41] 
[00:01:41]   git checkout -b <new-branch-name>
[00:01:41] + cd musl-cross-make
[00:01:41] ++ nproc
[00:01:41] + hide_output make -j4 TARGET=x86_64-linux-musl
[00:01:41] + set +x
---
[00:11:17] + set +x
[00:11:32] /build
[00:11:32] musl-toolchain.sh: line 9: 29664 Terminated              bash -c "while true; do sleep 30; echo \$(date) - building ...; done"
[00:11:32] + cd -
[00:11:32] + ln -s /usr/local/x86_64-linux-musl/lib/libc.so /lib/ld-musl-x86_64.so.1
[00:11:32] + echo /usr/local/x86_64-linux-musl/lib
[00:11:32] + CC=x86_64-linux-musl-gcc
[00:11:32] + export CXX=x86_64-linux-musl-g++
[00:11:32] + CXX=x86_64-linux-musl-g++
[00:11:32] + LLVM=70

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Zoxc · 2019-03-29T05:01:49Z

@bors retry

bors · 2019-03-29T08:14:49Z

⌛ Testing commit 456fa39 with merge 003382e...

@ghost

Rollup of 11 pull requests Successful merges: - #58019 (Combine all builtin late lints and make lint checking parallel) - #59358 (Use `track_errors` instead of hand rolling) - #59394 (warn -> deny duplicate match bindings) - #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes) - #59423 (Visit path in `walk_mac`) - #59468 (musl: build toolchain libs with -fPIC) - #59476 (Use `SmallVec` in `TokenStreamBuilder`.) - #59496 (Remove unnecessary with_globals calls) - #59498 (Use 'write_all' instead of 'write' in example code) - #59503 (Stablize {f32,f64}::copysign().) - #59511 (Fix missed fn rename in #59284) Failed merges: r? @ghost

fortanix-bot · 2019-03-29T08:27:46Z

Build failed for target x86_64-fortanix-unknown-sgx - status

cc @jethrogb

bors · 2019-03-29T11:20:48Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing 003382e to master...

japaric and others added 30 commits March 24, 2019 17:49

bootstrap: build compiler-builtins with -Z emit-stack-sizes

8b8488c

compile all crates under test w/ -Zemit-stack-sizes

7d365cf

musl: build toolchain libs with -fPIC

c764890

Visit path in walk_mac

c6e3ea4

Combine all builtin late lints

41316f0

Remove LintSession and run incremental and whole crate lints in parallel

cd32f9b

Run module lint passes in parallel

dee389f

Remove unnecessary with_globals calls

e9a8bef

Use write_all instead of write in example code

8dbae79

Stablize {f32,f64}::copysign().

d9bdd01

deny duplicate matcher bindings by default

9f14e14

Use track_errors

3ba7454

Remove err_count

526b355

Set ok value

ee0e1b7

WIP: remove report_as_error

0e76b34

Return correct values

f0de8e8

Remove unused variable

6c8e3a5

Use ErrorReported

0778847

Use SmallVec in TokenStreamBuilder.

17a8aff

This reduces by 12% the number of allocations done for a "clean incremental" of `webrender_api`, which reduces the instruction count by about 0.5%. It also reduces instruction counts by up to 1.4% across a range of rustc-perf benchmark runs.

Fix missed fn rename in rust-lang#59284

93fb4d8

Rollup merge of rust-lang#58019 - Zoxc:combine-late-lints, r=estebank

8794e21

Combine all builtin late lints and make lint checking parallel Blocked on rust-lang#57293. Cuts runtime of late lint checking from 3.222s to 0.546s with 8 threads on `winapi` (@retep998 ;) ) r? @estebank

Rollup merge of rust-lang#59358 - JohnTitor:use-track-errors, r=oli-obk

97927da

Use `track_errors` instead of hand rolling Fixes rust-lang#59215 r? @oli-obk

Rollup merge of rust-lang#59423 - varkor:walk_mac-visit_path, r=petro…

0f4c87c

…chenkov Visit path in `walk_mac` Fixes rust-lang#54110.

Rollup merge of rust-lang#59468 - mati865:musl_toolchain, r=pnkfelix

c2d6c08

musl: build toolchain libs with -fPIC Fixes rust-lang#59411

Rollup merge of rust-lang#59496 - Zoxc:fix-globals, r=oli-obk

bf3e6c6

Remove unnecessary with_globals calls

Rollup merge of rust-lang#59503 - crlf0710:stablize_copysign, r=Simon…

18680ae

…Sapin Stablize {f32,f64}::copysign(). Stablization PR for rust-lang#55169/rust-lang#58046. Please check if i'm doing it correctly. Is 1.35.0 good to go?

Rollup merge of rust-lang#59511 - jethrogb:jb/maybeinit-deprecated, r…

456fa39

…=Centril Fix missed fn rename in rust-lang#59284 See rust-lang#59284 (comment)

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 29, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 29, 2019

This was referenced Mar 29, 2019

Stablize {f32,f64}::copysign(). #59503

Merged

Use 'write_all' instead of 'write' in example code #59498

Merged

bors merged commit 456fa39 into rust-lang:master Mar 29, 2019

Centril deleted the rollup branch March 29, 2019 11:22

Centril added the rollup A PR which is a rollup label Oct 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 11 pull requests #59513

Rollup of 11 pull requests #59513

Centril commented Mar 29, 2019

Centril commented Mar 29, 2019

bors commented Mar 29, 2019

bors commented Mar 29, 2019

fortanix-bot commented Mar 29, 2019

jethrogb commented Mar 29, 2019

bors commented Mar 29, 2019

rust-highfive commented Mar 29, 2019

Zoxc commented Mar 29, 2019

bors commented Mar 29, 2019

fortanix-bot commented Mar 29, 2019

bors commented Mar 29, 2019

Rollup of 11 pull requests #59513

Rollup of 11 pull requests #59513

Conversation

Centril commented Mar 29, 2019

Centril commented Mar 29, 2019

bors commented Mar 29, 2019

bors commented Mar 29, 2019

fortanix-bot commented Mar 29, 2019

jethrogb commented Mar 29, 2019

bors commented Mar 29, 2019

rust-highfive commented Mar 29, 2019

Zoxc commented Mar 29, 2019

bors commented Mar 29, 2019

fortanix-bot commented Mar 29, 2019

bors commented Mar 29, 2019