Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests #59459

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Add some tests #59459

merged 1 commit into from
Mar 28, 2019

Conversation

JohnTitor
Copy link
Member

close #52977

It seems that there are no tests for this issue, so I opened this PR.
off-topic: I noticed this test's indents are bad, could I include commit to fix this, or should I separate?

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2019
@Centril
Copy link
Contributor

Centril commented Mar 27, 2019

r? @Centril

r=me with green gravis

@rust-highfive rust-highfive assigned Centril and unassigned oli-obk Mar 27, 2019
@Centril
Copy link
Contributor

Centril commented Mar 27, 2019

off-topic: I noticed this test's indents are bad, could I include commit to fix this, or should I separate?

I wouldn't bother. This should hopefully be fixed when we start applying rustfmt all over the repo.

@Centril
Copy link
Contributor

Centril commented Mar 27, 2019

Apparently travis is already green...

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 27, 2019

📌 Commit 2368aa8 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019
Add some tests

close rust-lang#52977

It seems that there are no tests for this issue, so I opened this PR.
off-topic: I noticed [this test](https://github.com/rust-lang/rust/blob/master/src/test/ui/existential_types/nested_existential_types.rs)'s indents are bad, could I include commit to fix this, or should I separate?

r? @oli-obk
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019
Add some tests

close rust-lang#52977

It seems that there are no tests for this issue, so I opened this PR.
off-topic: I noticed [this test](https://github.com/rust-lang/rust/blob/master/src/test/ui/existential_types/nested_existential_types.rs)'s indents are bad, could I include commit to fix this, or should I separate?

r? @oli-obk
cuviper added a commit to cuviper/rust that referenced this pull request Mar 28, 2019
Add some tests

close rust-lang#52977

It seems that there are no tests for this issue, so I opened this PR.
off-topic: I noticed [this test](https://github.com/rust-lang/rust/blob/master/src/test/ui/existential_types/nested_existential_types.rs)'s indents are bad, could I include commit to fix this, or should I separate?

r? @oli-obk
bors added a commit that referenced this pull request Mar 28, 2019
Rollup of 18 pull requests

Successful merges:

 - #57293 (Make some lints incremental)
 - #57565 (syntax: Remove warning for unnecessary path disambiguators)
 - #58253 (librustc_driver => 2018)
 - #58837 (librustc_interface => 2018)
 - #59268 (Add suggestion to use `&*var` when `&str: From<String>` is expected)
 - #59283 (Make ASCII case conversions more than 4× faster)
 - #59284 (adjust MaybeUninit API to discussions)
 - #59372 (add rustfix-able suggestions to trim_{left,right} deprecations)
 - #59390 (Make `ptr::eq` documentation mention fat-pointer behavior)
 - #59393 (Refactor tuple comparison tests)
 - #59420 ([CI] record docker image info for reuse)
 - #59421 (Reject integer suffix when tuple indexing)
 - #59430 (Renames `EvalContext` to `InterpretCx`)
 - #59439 (Generalize diagnostic for `x = y` where `bool` is the expected type)
 - #59449 (fix: Make incremental artifact deletion more robust)
 - #59451 (Add `Default` to `std::alloc::System`)
 - #59459 (Add some tests)
 - #59460 (Include id in Thread's Debug implementation)

Failed merges:

r? @ghost
@bors bors merged commit 2368aa8 into rust-lang:master Mar 28, 2019
@JohnTitor JohnTitor deleted the add-tests branch March 28, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existential_type compiler stack overflow
5 participants