Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ongoing_codegen a query #59404

Closed
wants to merge 9 commits into from
Closed

Make ongoing_codegen a query #59404

wants to merge 9 commits into from

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Mar 24, 2019

Builds on #59338.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2019
@petrochenkov
Copy link
Contributor

r? @michaelwoerister

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@Zoxc Zoxc changed the title [WIP] Make ongoing_codegen a query Make ongoing_codegen a query Mar 26, 2019
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@Zoxc Zoxc mentioned this pull request Apr 12, 2019
Closed
@bors
Copy link
Contributor

bors commented Apr 12, 2019

☔ The latest upstream changes (presumably #59536) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Apr 13, 2019

☔ The latest upstream changes (presumably #59515) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC-zz
Copy link

ping from triage @michaelwoerister waiting for your review on this

@Mark-Simulacrum Mark-Simulacrum added S-blocked-closed and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2019
@Mark-Simulacrum
Copy link
Member

Visiting from triage, I'm closing the series of PRs here other than the first one since they will likely only make progress sequentially and it doesn't help to have all of them open. For reference, this is #59404, #59338, #59282, and #59205 which are (in that order) blocked on each other and eventually #59064.

Feel free to reopen as those PRs merge and/or make progress.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 18, 2019
Closed
@Zoxc Zoxc reopened this Jun 18, 2019
@bors
Copy link
Contributor

bors commented Jun 22, 2019

☔ The latest upstream changes (presumably #62041) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 22, 2019
@hdhoang
Copy link
Contributor

hdhoang commented Aug 2, 2019

ping from triage @Zoxc, any update on this PR and its series?

@JohnCSimon
Copy link
Member

Ping from triage again @michaelwoerister @Mark-Simulacrum this has sat idle for months. Can you please resolve the merge conflicts?
Thank you!

@JohnCSimon
Copy link
Member

@Zoxc @michaelwoerister @Mark-Simulacrum
Unfortunately I'm going to have to close this PR. I'm not sure what else can be done with this.

@JohnCSimon JohnCSimon closed this Aug 17, 2019
@JohnCSimon JohnCSimon added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Aug 17, 2019
@nnethercote nnethercote mentioned this pull request Sep 6, 2019
Merged
@pnkfelix pnkfelix mentioned this pull request Sep 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Zoxc @rust-highfive @petrochenkov @bors @Dylan-DPC-zz @Mark-Simulacrum @hdhoang @JohnCSimon @michaelwoerister