Elide object safety errors on non-existent trait function #58929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
zackmdavis
approved these changes
Mar 10, 2019
There was a problem hiding this comment.
I read the diff, but I don't quite understand why, fundamentally, we were outputting an object safety error for nonexistent methods? (It would be more elegant to just not do that in the first place, rather than save the spans of nonexistent methods and then use that to decide to not emit the object safety error at the last moment.) But if you can't see any other way to do this, then, yes, r=me
I agree, and indeed I couldn't find a more elegant way of not emitting the error in the first place. I feel this is a bit of a hack, but better than doing nothing. @bors r=zackmdavis |
|
📌 Commit 094f1e22fb2ca10f333e231e84620da129a85631 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
|
@bors r=zackmdavis |
|
📌 Commit d7bb98f has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit d7bb98f with merge f552bcb7382f870d0659cafa18213803f81e1fbe... |
|
💔 Test failed - checks-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 23, 2019
Elide object safety errors on non-existent trait function Fix #58734. r? @zackmdavis
|
☀️ Test successful - checks-travis, status-appveyor |
Zoxc
reviewed
Mar 29, 2019
| @@ -164,6 +164,9 @@ pub struct Session { | |||
|
|
|||
| /// Cap lint level specified by a driver specifically. | |||
| pub driver_lint_caps: FxHashMap<lint::LintId, lint::Level>, | |||
|
|
|||
| /// `Span`s of trait methods that weren't found to avoid emitting object safety errors | |||
| pub trait_methods_not_found: OneThread<RefCell<FxHashSet<Span>>>, | |||
There was a problem hiding this comment.
This is potentially used on multiple threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #58734.
r? @zackmdavis