Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test for #58813 #58912

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

pnkfelix
Copy link
Member

@pnkfelix pnkfelix commented Mar 4, 2019

Fix #58813

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:32d3cb16:start=1551704235150858969,finish=1551704236051714311,duration=900855342
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_incremental
Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:19:34] 
[01:19:34] running 99 tests
[01:19:50] ..............F....................................................................................
[01:19:50] 
[01:19:50] 
[01:19:50] ---- [incremental] incremental/cyclic-trait-hierarchy.rs stdout ----
[01:19:50] 
[01:19:50] error in revision `rpass2`: compilation failed!
[01:19:50] status: exit code: 1
[01:19:50] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/cyclic-trait-hierarchy.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "rpass2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/cyclic-trait-hierarchy/cyclic-trait-hierarchy.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/cyclic-trait-hierarchy/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/cyclic-trait-hierarchy/auxiliary"
[01:19:50] ------------------------------------------
[01:19:50] 
[01:19:50] ------------------------------------------
[01:19:50] stderr:
[01:19:50] stderr:
[01:19:50] ------------------------------------------
[01:19:50] {"message":"cycle detected when computing the supertraits of `T2`","code":{"code":"E0391","explanation":"\nThis error indicates that some types or traits depend on each other\nand therefore cannot be constructed.\n\nThe following example contains a circular dependency between two traits:\n\n```compile_fail,E0391\ntrait FirstTrait : SecondTrait {\n\n}\n\ntrait SecondTrait : FirstTrait {\n\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/incremental/cyclic-trait-hierarchy.rs","byte_start":167,"byte_end":169,"line_start":11,"line_end":11,"column_start":15,"column_end":17,"is_primary":true,"text":[{"text":"pub trait T2: T1 { }","highlight_start":15,"highlight_end":17}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"...which requires computing the supertraits of `T1`...","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/incremental/cyclic-trait-hierarchy.rs","byte_start":84,"byte_end":100,"line_start":6,"line_end":6,"column_start":1,"column_end":17,"is_primary":true,"text":[{"text":"pub trait T1: T2 { }","highlight_start":1,"highlight_end":17}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"...which again requires computing the supertraits of `T2`, completing the cycle","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"cycle used when running analysis passes on this crate","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/incremental/cyclic-trait-hierarchy.rs","byte_start":0,"byte_end":0,"line_start":1,"line_end":1,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"// Adapated from rust-lang/rust#58813","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0391]: cycle detected when computing the supertraits of `T2`\n  --> /checkout/src/test/incremental/cyclic-trait-hierarchy.rs:11:15\n   |\nLL | pub trait T2: T1 { }\n   |               ^^\n   |\nnote: ...which requires computing the supertraits of `T1`...\n  --> /checkout/src/test/incremental/cyclic-trait-hierarchy.rs:6:1\n   |\nLL | pub trait T1: T2 { }\n   | ^^^^^^^^^^^^^^^^\n   = note: ...which again requires computing the supertraits of `T2`, completing the cycle\n   = note: cycle used when running analysis passes on this crate\n\n"}
[01:19:50] {"message":"cycle detected when computing the supertraits of `T2`","code":{"code":"E0391","explanation":"\nThis error indicates that some types or traits depend on each other\nand therefore cannot be constructed.\n\nThe following example contains a circular dependency between two traits:\n\n```compile_fail,E0391\ntrait FirstTrait : SecondTrait {\n\n}\n\ntrait SecondTrait : FirstTrait {\n\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/incremental/cyclic-trait-hierarchy.rs","byte_start":167,"byte_end":169,"line_start":11,"line_end":11,"column_start":15,"column_end":17,"is_primary":true,"text":[{"text":"pub trait T2: T1 { }","highlight_start":15,"highlight_end":17}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"...which requires computing the supertraits of `T1`...","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/incremental/cyclic-trait-hierarchy.rs","byte_start":98,"byte_end":100,"line_start":6,"line_end":6,"column_start":15,"column_end":17,"is_primary":true,"text":[{"text":"pub trait T1: T2 { }","highlight_start":15,"highlight_end":17}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"...which again requires computing the supertraits of `T2`, completing the cycle","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"cycle used when running analysis passes on this crate","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/incremental/cyclic-trait-hierarchy.rs","byte_start":0,"byte_end":0,"line_start":1,"line_end":1,"column_start":1,"column_end":1,"is_primary":true,"text":[{"text":"// Adapated from rust-lang/rust#58813","highlight_start":1,"highlight_end":1}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"error[E0391]: cycle detected when computing the supertraits of `T2`\n  --> /checkout/src/test/incremental/cyclic-trait-hierarchy.rs:11:15\n   |\nLL | pub trait T2: T1 { }\n   |               ^^\n   |\nnote: ...which requires computing the supertraits of `T1`...\n  --> /checkout/src/test/incremental/cyclic-trait-hierarchy.rs:6:15\n   |\nLL | pub trait T1: T2 { }\n   |               ^^\n   = note: ...which again requires computing the supertraits of `T2`, completing the cycle\n   = note: cycle used when running analysis passes on this crate\n\n"}
[01:19:50] {"message":"For more information about this error, try `rustc --explain E0391`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0391`.\n"}
[01:19:50] 
[01:19:50] ------------------------------------------
[01:19:50] 
[01:19:50] 
[01:19:50] thread '[incremental] incremental/cyclic-trait-hierarchy.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:50] 
[01:19:50] 
[01:19:50] failures:
[01:19:50] failures:
[01:19:50]     [incremental] incremental/cyclic-trait-hierarchy.rs
[01:19:50] test result: FAILED. 98 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:19:50] 
[01:19:50] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:19:50] 
[01:19:50] 
[01:19:50] 
[01:19:50] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/incremental" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "incremental" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:19:50] 
[01:19:50] 
[01:19:50] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:19:50] Build completed unsuccessfully in 0:11:49
[01:19:50] Build completed unsuccessfully in 0:11:49
[01:19:50] make: *** [check] Error 1
[01:19:50] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:03bf16b2
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Mar  4 14:17:17 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@petrochenkov
Copy link
Contributor

The test is failing (not compile-pass).

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2019
@pnkfelix
Copy link
Member Author

pnkfelix commented Mar 5, 2019

The test is failing (not compile-pass).

🤦‍♂️

@pnkfelix pnkfelix force-pushed the issue-58813-incr-comp-regress-test branch from 7f8850d to c6a1015 Compare March 6, 2019 11:35
(Update: Fixed test; revision is meant to introduce compile-failure, w/o ICE.)
@pnkfelix pnkfelix force-pushed the issue-58813-incr-comp-regress-test branch from c6a1015 to c076701 Compare March 6, 2019 11:36
@pnkfelix pnkfelix added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2019
@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 6, 2019

📌 Commit c076701 has been approved by petrochenkov

@bors
Copy link
Contributor

bors commented Mar 6, 2019

🌲 The tree is currently closed for pull requests below priority 50, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2019
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Mar 8, 2019
bors added a commit that referenced this pull request Mar 9, 2019
Rollup of 24 pull requests

Successful merges:

 - #58080 (Add FreeBSD armv6 and armv7 targets)
 - #58204 (On return type `impl Trait` for block with no expr point at last semi)
 - #58269 (Add librustc and libsyntax to rust-src distribution.)
 - #58369 (Make the Entry API of HashMap<K, V> Sync and Send)
 - #58861 (Expand where negative supertrait specific error is shown)
 - #58877 (Suggest removal of `&` when borrowing macro and appropriate)
 - #58883 (Suggest appropriate code for unused field when destructuring pattern)
 - #58891 (Remove stray ` in the docs for the FromIterator implementation for Option)
 - #58893 (race condition in thread local storage example)
 - #58906 (Monomorphize generator field types for debuginfo)
 - #58911 (Regression test for #58435.)
 - #58912 (Regression test for #58813)
 - #58916 (Fix release note problems noticed after merging.)
 - #58918 (Regression test added for an async ICE.)
 - #58921 (Add an explicit test for issue #50582)
 - #58926 (Make the lifetime parameters of tcx consistent.)
 - #58931 (Elide invalid method receiver error when it contains TyErr)
 - #58940 (Remove JSBackend from config.toml)
 - #58950 (Add self to mailmap)
 - #58961 (On incorrect cfg literal/identifier, point at the right span)
 - #58963 (libstd: implement Error::source for io::Error)
 - #58970 (delay_span_bug in wfcheck's ty.lift_to_tcx unwrap)
 - #58984 (Teach `-Z treat-err-as-bug` to take a number of errors to emit)
 - #59007 (Add a test for invalid const arguments)

Failed merges:

 - #58959 (Add release notes for PR #56243)

r? @ghost
@bors bors merged commit c076701 into rust-lang:master Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants