Revert abort on unwinding through FFI on stable #58795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rust-highfive
added
the
S-waiting-on-review
|
cc @rust-lang/compiler -- would appreciate a review of this fairly quickly (we need it to land before tomorrow to avoid delaying stable) |
nikomatsakis
approved these changes
Feb 28, 2019
| @@ -51,8 +51,7 @@ Language | |||
| // Allowed as there is only one `Read` in the module. | |||
| pub trait Read {} | |||
| ``` | |||
| - [`extern` functions will now abort by default when panicking.][55982] | |||
| This was previously undefined behaviour. | |||
| - [You may now use `Rc`, `Arc`, and `Pin` as method receivers][56805]. | |||
There was a problem hiding this comment.
what's up with this? just an orthogonal change?
| @@ -109,27 +108,30 @@ Compatibility Notes | |||
| are now deprecated in the standard library, and their usage will now produce a warning. | |||
| Please use the `str::{trim_start, trim_end, trim_start_matches, trim_end_matches}` | |||
| methods instead. | |||
| - The `Error::cause` method has been deprecated in favor of `Error::source` which supports | |||
| downcasting. | |||
Mark-Simulacrum
added
S-waiting-on-author
See rust-lang#58794 for context.
Mark-Simulacrum
force-pushed
the
stable-next
branch
from
bae33e5 to
bd1f032
Compare
|
@bors r+ p=100 |
|
📌 Commit bd1f032 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Feb 28, 2019
Revert abort on unwinding through FFI on stable r? @alexcrichton
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
@bors retry - 259 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit bd1f032 with merge 6173377c8587a2e4589827aa0163f8322097aca4... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
macOS is time travelling again. @bors retry |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
@bors retry |
bors
added a commit
that referenced
this pull request
Feb 28, 2019
Revert abort on unwinding through FFI on stable This is entirely done to allow us more time for discussion about what behavior we want to specify here.
|
☀️ Test successful - checks-travis, status-appveyor |
RalfJung
reviewed
Mar 10, 2019
| @@ -4,10 +4,10 @@ Version 1.33.0 (2019-02-28) | |||
| Language | |||
| -------- | |||
| - [You can now use the `cfg(target_vendor)` attribute.][57465] E.g. | |||
| `#[cfg(target_vendor="linux")] fn main() { println!("Hello Linux!"); }` | |||
| `#[cfg(target_vendor="apple")] fn main() { println!("Hello Apple!"); }` | |||
There was a problem hiding this comment.
Looks like more spurious changes? Shouldn't this (have been) fixed before approving...?
There was a problem hiding this comment.
This was intentional (note the separate commit); we wanted to land some additional release notes and since we were merging this into stable combined it into one.
In hindsight, I should've mentioned this in the PR description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is entirely done to allow us more time for discussion about what behavior we want to specify here.