Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ExactSizeIterator for ToLowercase and ToUppercase #58778

Merged
merged 3 commits into from
Mar 19, 2019
Merged

Implement ExactSizeIterator for ToLowercase and ToUppercase #58778

merged 3 commits into from
Mar 19, 2019

Conversation

KamilaBorowska
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2019
@KamilaBorowska KamilaBorowska force-pushed the exact_size_case_mapping_iter branch from fe9ed7f to 7b4e267 Compare February 27, 2019 13:17
@KamilaBorowska KamilaBorowska force-pushed the exact_size_case_mapping_iter branch from 7b4e267 to 988b3d5 Compare February 27, 2019 13:30
ollie27
ollie27 reviewed Feb 27, 2019
View reviewed changes
src/libcore/tests/char.rs Outdated Show resolved Hide resolved
@Centril Centril added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. labels Feb 27, 2019
@Centril
Copy link
Contributor

Centril commented Feb 27, 2019

r? @SimonSapin

@rust-highfive rust-highfive assigned SimonSapin and unassigned kennytm Feb 27, 2019
@Dylan-DPC-zz
Copy link

ping from triage can anyone from @rust-lang/libs review this?

@SimonSapin
Copy link
Contributor

Looks good, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 18, 2019

📌 Commit 911a633 has been approved by SimonSapin

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2019
@Centril Centril added this to the 1.35 milestone Mar 18, 2019
@bors
Copy link
Contributor

bors commented Mar 19, 2019

⌛ Testing commit 911a633 with merge 3fa9e363313e5ba7c82943e26a852c4f48d18613...

@KamilaBorowska
Update since annotation for ExactSizeIterator for ToUppercase/Lowercase
8f261a6 
This functionality was added in 1.35.0, not 1.34.0.
@KamilaBorowska KamilaBorowska force-pushed the exact_size_case_mapping_iter branch from 86cc560 to 8f261a6 Compare March 19, 2019 07:50
@kennytm
Copy link
Member

kennytm commented Mar 19, 2019

r? @SimonSapin needs reapproval after force-push.

BTW does this PR still "needs-fcp"?

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 19, 2019
@SimonSapin SimonSapin removed the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Mar 19, 2019
@SimonSapin
Copy link
Contributor

We usually do FCP when adding new stable APIs. But in this case I’m gonna unilaterally declare this obvious enough. CC @rust-lang/libs

@bors r+

@bors
Copy link
Contributor

bors commented Mar 19, 2019

📌 Commit 8f261a6 has been approved by SimonSapin

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 19, 2019
@Centril
Rollup merge of rust-lang#58778 - xfix:exact_size_case_mapping_iter, …
fff8586 
…r=SimonSapin

Implement ExactSizeIterator for ToLowercase and ToUppercase
@Centril Centril mentioned this pull request Mar 19, 2019
Merged
bors added a commit that referenced this pull request Mar 19, 2019
@bors
Auto merge of #59293 - Centril:rollup, r=Centril
7a4df3b 
Rollup of 11 pull requests

Successful merges:

 - #56348 (Add todo!() macro)
 - #57729 (extra testing of how NLL handles wildcard type `_`)
 - #57847 (dbg!() without parameters)
 - #58778 (Implement ExactSizeIterator for ToLowercase and ToUppercase)
 - #58812 (Clarify distinction between floor() and trunc())
 - #58939 (Fix a tiny error in documentation of std::pin.)
 - #59116 (Be more discerning on when to attempt suggesting a comma in a macro invocation)
 - #59252 (add self to mailmap)
 - #59275 (Replaced self-reflective explicit types with clearer `Self` or `Self::…` in stdlib docs)
 - #59280 (Stabilize refcell_map_split feature)
 - #59290 (Run branch cleanup after copy prop)

Failed merges:

r? @ghost
@bors bors merged commit 8f261a6 into rust-lang:master Mar 19, 2019
@KamilaBorowska KamilaBorowska mentioned this pull request Apr 21, 2019
Closed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 31, 2019
@jperkin
rust: Update to 1.35.0.
6e0b39c 
Version 1.35.0 (2019-05-23)
==========================

Language
--------
- [`FnOnce`, `FnMut`, and the `Fn` traits are now implemented for `Box<FnOnce>`,
  `Box<FnMut>`, and `Box<Fn>` respectively.][59500]
- [You can now coerce closures into unsafe function pointers.][59580] e.g.
  ```rust
  unsafe fn call_unsafe(func: unsafe fn()) {
      func()
  }

  pub fn main() {
      unsafe { call_unsafe(|| {}); }
  }
  ```


Compiler
--------
- [Added the `armv6-unknown-freebsd-gnueabihf` and
  `armv7-unknown-freebsd-gnueabihf` targets.][58080]
- [Added the `wasm32-unknown-wasi` target.][59464]


Libraries
---------
- [`Thread` will now show its ID in `Debug` output.][59460]
- [`StdinLock`, `StdoutLock`, and `StderrLock` now implement `AsRawFd`.][59512]
- [`alloc::System` now implements `Default`.][59451]
- [Expanded `Debug` output (`{:#?}`) for structs now has a trailing comma on the
  last field.][59076]
- [`char::{ToLowercase, ToUppercase}` now
  implement `ExactSizeIterator`.][58778]
- [All `NonZero` numeric types now implement `FromStr`.][58717]
- [Removed the `Read` trait bounds
  on the `BufReader::{get_ref, get_mut, into_inner}` methods.][58423]
- [You can now call the `dbg!` macro without any parameters to print the file
  and line where it is called.][57847]
- [In place ASCII case conversions are now up to 4× faster.][59283]
  e.g. `str::make_ascii_lowercase`
- [`hash_map::{OccupiedEntry, VacantEntry}` now implement `Sync`
  and `Send`.][58369]

Stabilized APIs
---------------
- [`f32::copysign`]
- [`f64::copysign`]
- [`RefCell::replace_with`]
- [`RefCell::map_split`]
- [`ptr::hash`]
- [`Range::contains`]
- [`RangeFrom::contains`]
- [`RangeTo::contains`]
- [`RangeInclusive::contains`]
- [`RangeToInclusive::contains`]
- [`Option::copied`]

Cargo
-----
- [You can now set `cargo:rustc-cdylib-link-arg` at build time to pass custom
  linker arguments when building a `cdylib`.][cargo/6298] Its usage is highly
  platform specific.

Misc
----
- [The Rust toolchain is now available natively for musl based distros.][58575]

[59460]: rust-lang/rust#59460
[59464]: rust-lang/rust#59464
[59500]: rust-lang/rust#59500
[59512]: rust-lang/rust#59512
[59580]: rust-lang/rust#59580
[59283]: rust-lang/rust#59283
[59451]: rust-lang/rust#59451
[59076]: rust-lang/rust#59076
[58778]: rust-lang/rust#58778
[58717]: rust-lang/rust#58717
[58369]: rust-lang/rust#58369
[58423]: rust-lang/rust#58423
[58080]: rust-lang/rust#58080
[57847]: rust-lang/rust#57847
[58575]: rust-lang/rust#58575
[cargo/6298]: rust-lang/cargo#6298
[`f32::copysign`]: https://doc.rust-lang.org/stable/std/primitive.f32.html#method.copysign
[`f64::copysign`]: https://doc.rust-lang.org/stable/std/primitive.f64.html#method.copysign
[`RefCell::replace_with`]: https://doc.rust-lang.org/stable/std/cell/struct.RefCell.html#method.replace_with
[`RefCell::map_split`]: https://doc.rust-lang.org/stable/std/cell/struct.RefCell.html#method.map_split
[`ptr::hash`]: https://doc.rust-lang.org/stable/std/ptr/fn.hash.html
[`Range::contains`]: https://doc.rust-lang.org/std/ops/struct.Range.html#method.contains
[`RangeFrom::contains`]: https://doc.rust-lang.org/std/ops/struct.RangeFrom.html#method.contains
[`RangeTo::contains`]: https://doc.rust-lang.org/std/ops/struct.RangeTo.html#method.contains
[`RangeInclusive::contains`]: https://doc.rust-lang.org/std/ops/struct.RangeInclusive.html#method.contains
[`RangeToInclusive::contains`]: https://doc.rust-lang.org/std/ops/struct.RangeToInclusive.html#method.contains
[`Option::copied`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.copied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollie27 ollie27 ollie27 left review comments

Assignees

@SimonSapin SimonSapin

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.
8 participants
@KamilaBorowska @rust-highfive @Centril @Dylan-DPC-zz @SimonSapin @bors @kennytm @ollie27