[beta] Fix attempted .def_id() on invalid def: NonMacroAttr(Builtin)
#58501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
oli-obk
added
beta-nominated
|
@bors r+ I hit this as well and was stuck using the query stack printed on ICE (when |
|
📌 Commit 81571bf has been approved by |
bors
added
the
S-waiting-on-bors
oli-obk
removed
the
beta-nominated
yes
I guess. I removed the tag |
bors
added a commit
that referenced
this pull request
Feb 16, 2019
[beta] Fix `attempted .def_id() on invalid def: NonMacroAttr(Builtin)` backport of the fix so we can get update the bootstrap compiler to a compiler that has this fix. It's very hard to do development on stage 0/1 since resolve errors often end up with an ICE before outputting any useful diagnostics. cc @rust-lang/compiler @rust-lang/infra I would like to fast-track this backport as it severly hampers @varkor's and my rustc developments. The ICE never happens for successful compiles, only if there are errors. Since it is very minimalistic and can easily be reverted if desired I think/hope we can skip the usual beta nomination + beta accepted steps
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Feb 17, 2019
bors
added a commit
that referenced
this pull request
Feb 17, 2019
Bump the bootstrap compiler This compiler includes #58501, which fixes an annoying ICE while working on rustc itself. r? @pietroalbini
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 18, 2019
…albini Bump the bootstrap compiler This compiler includes rust-lang#58501, which fixes an annoying ICE while working on rustc itself. r? @pietroalbini
bors
added a commit
that referenced
this pull request
Feb 18, 2019
Bump the bootstrap compiler This compiler includes #58501, which fixes an annoying ICE while working on rustc itself. r? @pietroalbini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of the fix so we can get update the bootstrap compiler to a compiler that has this fix. It's very hard to do development on stage 0/1 since resolve errors often end up with an ICE before outputting any useful diagnostics.
cc @rust-lang/compiler @rust-lang/infra I would like to fast-track this backport as it severly hampers @varkor's and my rustc developments. The ICE never happens for successful compiles, only if there are errors.
Since it is very minimalistic and can easily be reverted if desired I think/hope we can skip the usual beta nomination + beta accepted steps