Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to debug 259 exit code on AppVeyor #57975

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Attempt to debug 259 exit code on AppVeyor #57975

merged 1 commit into from
Jan 30, 2019

Conversation

alexcrichton
Copy link
Member

Let's try to dig in a bit more and see where this is coming from, it
looks like AppVeyor is also unsure where this is coming from!

@alexcrichton
Attempt to debug 259 exit code on AppVeyor
ce279a8 
Let's try to dig in a bit more and see where this is coming from, it
looks like AppVeyor is also unsure where this is coming from!
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 29, 2019
@alexcrichton
Copy link
Member Author

This came out with some discussion I've been having with them.

@alexcrichton
Copy link
Member Author

r? @pietroalbini

@pietroalbini
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 29, 2019

📌 Commit ce279a8 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2019
@nagisa
Copy link
Member

nagisa commented Jan 29, 2019

NB: you can RDP directly into an appveyor machine, so perhaps setting that up would help?

@alexcrichton
Copy link
Member Author

Unfortunately we don't typically get a chance to see and debug these failures until hours after the build has finished. Additionally they're often spurious, and we can't be watching every single build.

@Centril
Copy link
Contributor

Centril commented Jan 30, 2019

@bors p=1

Adjusting queue order relative to rollup.

@bors
Copy link
Contributor

bors commented Jan 30, 2019

⌛ Testing commit ce279a8 with merge d3d0bf0...

bors added a commit that referenced this pull request Jan 30, 2019
@bors
Auto merge of #57975 - alexcrichton:debug-exit-appveyor, r=pietroalbini
d3d0bf0 
Attempt to debug 259 exit code on AppVeyor

Let's try to dig in a bit more and see where this is coming from, it
looks like AppVeyor is also unsure where this is coming from!
@bors
Copy link
Contributor

bors commented Jan 30, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: pietroalbini
Pushing d3d0bf0 to master...

@bors
Copy link
Contributor

bors commented Jan 30, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: pietroalbini
Pushing d3d0bf0 to master...

@bors bors merged commit ce279a8 into rust-lang:master Jan 30, 2019
@pietroalbini pietroalbini mentioned this pull request Feb 4, 2019
Closed
@pietroalbini
Copy link
Member

Still happening, opened a tracking issue in #58160.

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Feb 6, 2019
@pietroalbini
Revert "Auto merge of rust-lang#57975 - alexcrichton:debug-exit-appve…
9959924 
…yor, r=pietroalbini"

This reverts commit d3d0bf0, reversing
changes made to 40e6a0b.
@alexcrichton alexcrichton deleted the debug-exit-appveyor branch March 12, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pietroalbini pietroalbini

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alexcrichton @rust-highfive @pietroalbini @bors @nagisa @Centril @nikomatsakis