Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: Link LLVM as a dylib with ThinLTO (take 2) #57286

Merged
merged 5 commits into from
Jan 6, 2019
Merged

bootstrap: Link LLVM as a dylib with ThinLTO (take 2) #57286

merged 5 commits into from
Jan 6, 2019

Commits on Jan 2, 2019

  1. bootstrap: Link LLVM as a dylib with ThinLTO 

    When building a distributed compiler on Linux where we use ThinLTO to
create the LLVM shared object this commit switches the compiler to
dynamically linking that LLVM artifact instead of statically linking to
LLVM. The primary goal here is to reduce CI compile times, avoiding two+
ThinLTO builds of all of LLVM. By linking dynamically to LLVM we'll
reuse the one ThinLTO step done by LLVM's build itself.

Lots of discussion about this change can be found [here] and down. A
perf run will show whether this is worth it or not!

[here]: rust-lang#53245 (comment)
    @alexcrichton
    alexcrichton committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    ea7fef1 View commit details
    Browse the repository at this point in the history

  2. Avoid using open_global_now

    @alexcrichton
    alexcrichton committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    a175969 View commit details
    Browse the repository at this point in the history

  3. Remove no longer working test

    @alexcrichton
    alexcrichton committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    82a1bb3 View commit details
    Browse the repository at this point in the history

  4. Remove now stray comment

    @alexcrichton
    alexcrichton committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    fa4f014 View commit details
    Browse the repository at this point in the history

  5. Don't package up libLLVM.so with libstd 

    It's only meant for rustc, so we should only install it once!
    @alexcrichton
    alexcrichton committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    71fed3a View commit details
    Browse the repository at this point in the history