Remove Cycle::try_fold override #56904
Merged
+2
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
It was a incorrect optimization.
Contributor
Author
|
After fixing the bug, it no longer improves benchmark. So, now this PR just removes the override. |
Contributor
|
@bors r+ rollup Makes sense. Thanks! |
Collaborator
|
📌 Commit f0483f7 has been approved by |
bors
added
S-waiting-on-bors
Member
|
IMHO this should be p=1 and landed ASAP, @bluss, not as part of rollup, as it fixes invalid behaviour in valid code (i.e. problem as bad as soundness issues). |
Contributor
|
@bors p=1 rollup- Yes. Let's see if bors can do that. There are several bugfixes queued, but looks like we're not overtaking something more critical. |
Collaborator
bors
added a commit
that referenced
this pull request
Dec 17, 2018
Remove Cycle::try_fold override Fixes #56883
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56883