privacy: Use common `DefId` visiting infrastructure for all privacy visitors #56878

petrochenkov · 2018-12-16T15:30:45Z

One repeating pattern in privacy checking is going through a type, visiting all DefIds inside it and doing something with them.
This is the case because visibilities and reachabilities are attached to DefIds.

Previously various privacy visitors visited types slightly differently using their own methods, with most recently written TypePrivacyVisitor being the "gold standard".
This mostly worked okay, but differences could manifest in overly conservative reachability analysis, some errors being reported twice, some private-in-public lints (not errors) being wrongly reported or not reported.

This PR does something that I wanted to do since #32674 (comment) - factoring out the common visiting logic!
Now all the common logic is contained in struct DefIdVisitorSkeleton, with specific privacy visitors deciding only what to do with visited DefIds (via trait DefIdVisitor).

A bunch of cleanups is also applied in the process.
This area is somewhat tricky due to lots of easily miss-able details, but thankfully it's was well covered by tests in #46083 and previous PRs, so I'm relatively sure in the refactoring correctness.

Fixes #56837 (comment) in particular.
Also this will help with implementing #48054.

petrochenkov · 2018-12-16T15:30:56Z

r? @arielb1

arielb1 · 2018-12-16T18:18:24Z

I'll take a more detailed look tomorrow.

src/librustc_privacy/lib.rs

petrochenkov · 2018-12-22T12:14:45Z

So, I started to factor out the common "visit all def-ids in a type" functionality and it turned out a bit trickier than expected, I'll update the PR today hopefully.

petrochenkov · 2018-12-26T22:30:24Z

The PR is completely rewritten, see the new description.

cc people who reviewed previous PRs in this area (#46083 and friends)
@eddyb @nikomatsakis

petrochenkov · 2018-12-26T22:31:22Z

src/libstd/sys/windows/handle.rs

-        let mut me = self;
-        (&mut me).read_to_end(buf)
-    }
-


This is an unused function newly detected due to improved reachability analysis (which is based on privacy data).

src/librustc_privacy/lib.rs

petrochenkov · 2018-12-31T02:05:06Z

Updated.

petrochenkov · 2018-12-31T02:07:19Z

src/librustc_privacy/lib.rs

+/// The idea is to visit "all components of a type", as documented in
+/// https://github.com/rust-lang/rfcs/blob/master/text/2145-type-privacy.md#how-to-determine-visibility-of-a-type
+/// Default type visitor (`TypeVisitor`) does most of the job, but it has some shortcomings.
+/// First, it doesn't have overridable `fn visit_trait_ref`, so we have to catch trait def-ids


Actually, it would be good to support this in TypeVisitor itself, but I'm not sure this PR is the best place for that.

src/librustc_privacy/lib.rs

arielb1 · 2018-12-31T22:02:07Z

r=me with over-approximation comment

Say "trait" instead of "type" in diagnostics for `dyn Trait`

petrochenkov · 2018-12-31T23:00:55Z

@bors r=arielb1

bors · 2018-12-31T23:00:55Z

📌 Commit 60d1fa7 has been approved by arielb1

bors · 2018-12-31T23:31:04Z

⌛ Testing commit 60d1fa7 with merge fe6a54d...

privacy: Use common `DefId` visiting infrastructure for all privacy visitors One repeating pattern in privacy checking is going through a type, visiting all `DefId`s inside it and doing something with them. This is the case because visibilities and reachabilities are attached to `DefId`s. Previously various privacy visitors visited types slightly differently using their own methods, with most recently written `TypePrivacyVisitor` being the "gold standard". This mostly worked okay, but differences could manifest in overly conservative reachability analysis, some errors being reported twice, some private-in-public lints (not errors) being wrongly reported or not reported. This PR does something that I wanted to do since #32674 (comment) - factoring out the common visiting logic! Now all the common logic is contained in `struct DefIdVisitorSkeleton`, with specific privacy visitors deciding only what to do with visited `DefId`s (via `trait DefIdVisitor`). A bunch of cleanups is also applied in the process. This area is somewhat tricky due to lots of easily miss-able details, but thankfully it's was well covered by tests in #46083 and previous PRs, so I'm relatively sure in the refactoring correctness. Fixes #56837 (comment) in particular. Also this will help with implementing #48054.

bors · 2019-01-01T02:08:33Z

☀️ Test successful - status-appveyor, status-travis
Approved by: arielb1
Pushing fe6a54d to master...

privacy: Fix regression in impl reachability Rollback to pre-#56878 logic of determining reachability. `reachability(impl Trait<Substs> for Type<Substs>) = reachability(Trait & Type)`, substs are ignored. Fixes #57264

eddyb · 2019-01-08T12:23:28Z

src/librustc/util/ppaux.rs

@@ -709,6 +709,9 @@ define_print! {

 define_print! {
    ('tcx) ty::ExistentialTraitRef<'tcx>, (self, f, cx) {
+        display {
+            cx.parameterized(f, self.substs, self.def_id, &[])


This looks wrong. The substs are missing the Self type, which is why the debug {...} implementation below does through all of that trouble of creating a TraitRef.

I think the correct fix is moving the code from debug {...} to display {...} and changing debug {...} to contain just self.print_display(f, cx).

@arielb1

privacy: Fix private-in-public check for existential types Fixes rust-lang#53546 (regression from rust-lang#56878) r? @arielb1

@arielb1

privacy: Fix private-in-public check for existential types Fixes rust-lang#53546 (regression from rust-lang#56878) r? @arielb1

rust-highfive assigned arielb1 Dec 16, 2018

petrochenkov mentioned this pull request Dec 16, 2018

Add support for trait-objects without a principal #56837

Merged

arielb1 reviewed Dec 16, 2018

View reviewed changes

src/librustc_privacy/lib.rs Outdated Show resolved Hide resolved

arielb1 reviewed Dec 16, 2018

View reviewed changes

src/librustc_privacy/lib.rs Outdated Show resolved Hide resolved

petrochenkov added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 17, 2018

petrochenkov force-pushed the privdyn branch from 0a870ab to 829bfbf Compare December 22, 2018 21:49

rust-lang deleted a comment from rust-highfive Dec 22, 2018

petrochenkov force-pushed the privdyn branch from 829bfbf to fb1ef41 Compare December 22, 2018 22:28

This comment has been minimized.

Sign in to view

petrochenkov force-pushed the privdyn branch from fb1ef41 to 66265df Compare December 23, 2018 01:43

This comment has been minimized.

Sign in to view

petrochenkov force-pushed the privdyn branch from 66265df to b1b8db2 Compare December 25, 2018 01:56

This comment has been minimized.

Sign in to view

petrochenkov force-pushed the privdyn branch from b1b8db2 to 4c460ae Compare December 26, 2018 21:27

petrochenkov changed the title ~~privacy: Check non-principal components of trait object types~~ privacy: Use common DefId visiting infra for all privacy visitors Dec 26, 2018

petrochenkov changed the title ~~privacy: Use common DefId visiting infra for all privacy visitors~~ privacy: Use common DefId visiting infrastructure for all privacy visitors Dec 26, 2018

petrochenkov force-pushed the privdyn branch from 4c460ae to e7f3a59 Compare December 26, 2018 22:06

petrochenkov commented Dec 26, 2018

View reviewed changes

petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 26, 2018

arielb1 reviewed Dec 29, 2018

View reviewed changes

src/librustc_privacy/lib.rs Outdated Show resolved Hide resolved

arielb1 reviewed Dec 29, 2018

View reviewed changes

src/librustc_privacy/lib.rs Outdated Show resolved Hide resolved

arielb1 reviewed Dec 29, 2018

View reviewed changes

src/librustc_privacy/lib.rs Show resolved Hide resolved

arielb1 reviewed Dec 29, 2018

View reviewed changes

src/librustc_privacy/lib.rs Outdated Show resolved Hide resolved

arielb1 reviewed Dec 29, 2018

View reviewed changes

src/librustc_privacy/lib.rs Outdated Show resolved Hide resolved

petrochenkov commented Dec 31, 2018

View reviewed changes

petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 31, 2018

arielb1 reviewed Dec 31, 2018

View reviewed changes

src/librustc_privacy/lib.rs Show resolved Hide resolved

petrochenkov added 2 commits January 1, 2019 01:39

privacy: Use common DefId visiting infra for all privacy visitors

8b1c424

Address review comments

60d1fa7

Say "trait" instead of "type" in diagnostics for `dyn Trait`

petrochenkov force-pushed the privdyn branch from 16dfa1e to 60d1fa7 Compare December 31, 2018 23:00

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2018

bors merged commit 60d1fa7 into rust-lang:master Jan 1, 2019

bors mentioned this pull request Jan 1, 2019

Various cosmetic and minor changes #57016

Closed

cramertj mentioned this pull request Jan 2, 2019

rustc 1.33.0-nightly (b2b7a063a 2019-01-01) compiler unexpectedly panics #57264

Closed

petrochenkov mentioned this pull request Jan 4, 2019

privacy: Fix regression in impl reachability #57344

Merged

eddyb reviewed Jan 8, 2019

View reviewed changes

petrochenkov mentioned this pull request Jan 12, 2019

privacy: Fix private-in-public check for existential types #57556

Merged

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57556 - petrochenkov:privexist, r=arielb1

7453da1

privacy: Fix private-in-public check for existential types Fixes rust-lang#53546 (regression from rust-lang#56878) r? @arielb1

Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019

Rollup merge of rust-lang#57556 - petrochenkov:privexist, r=arielb1

4112aef

privacy: Fix private-in-public check for existential types Fixes rust-lang#53546 (regression from rust-lang#56878) r? @arielb1

petrochenkov mentioned this pull request Feb 14, 2019

"Cannot create local mono-item" ICE building cortex-m code on nightly #58323

Closed

petrochenkov deleted the privdyn branch June 5, 2019 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

privacy: Use common `DefId` visiting infrastructure for all privacy visitors #56878

privacy: Use common `DefId` visiting infrastructure for all privacy visitors #56878

petrochenkov commented Dec 16, 2018 •

edited

Loading

petrochenkov commented Dec 16, 2018

arielb1 commented Dec 16, 2018

petrochenkov commented Dec 22, 2018 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Dec 26, 2018

petrochenkov Dec 26, 2018

petrochenkov commented Dec 31, 2018

petrochenkov Dec 31, 2018

arielb1 Dec 31, 2018

arielb1 commented Dec 31, 2018

petrochenkov commented Dec 31, 2018

bors commented Dec 31, 2018

bors commented Dec 31, 2018

bors commented Jan 1, 2019

eddyb Jan 8, 2019

privacy: Use common DefId visiting infrastructure for all privacy visitors #56878

privacy: Use common DefId visiting infrastructure for all privacy visitors #56878

Conversation

petrochenkov commented Dec 16, 2018 • edited Loading

petrochenkov commented Dec 16, 2018

arielb1 commented Dec 16, 2018

petrochenkov commented Dec 22, 2018 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Dec 26, 2018

petrochenkov Dec 26, 2018

Choose a reason for hiding this comment

petrochenkov commented Dec 31, 2018

petrochenkov Dec 31, 2018

Choose a reason for hiding this comment

arielb1 Dec 31, 2018

Choose a reason for hiding this comment

arielb1 commented Dec 31, 2018

petrochenkov commented Dec 31, 2018

bors commented Dec 31, 2018

bors commented Dec 31, 2018

bors commented Jan 1, 2019

eddyb Jan 8, 2019

Choose a reason for hiding this comment

privacy: Use common `DefId` visiting infrastructure for all privacy visitors #56878

privacy: Use common `DefId` visiting infrastructure for all privacy visitors #56878

petrochenkov commented Dec 16, 2018 •

edited

Loading

petrochenkov commented Dec 22, 2018 •

edited

Loading