Add a method to the arena to promote objects to it if they implement LocalDrop #56448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
eddyb
added
S-blocked
|
Blocked on #56447. |
eddyb
reviewed
Dec 3, 2018
|
|
||
| /// A type which does not look at references in its destructor | ||
| /// but only owned data | ||
| pub unsafe trait LocalDrop { |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@Zoxc, can you give some explanation and reasoning of the concepts any changes here? What is |
|
Promotion would be allocating types with destructors on the dropless arena by deferring execution of their destructors to when the arena is dropped. We can only allow that for types which do not access other promoted objects during destruction, since those promoted object may have been destroyed earlier. Such allowed types implement |
|
The point of the dropless arena is that, well, it has no destructors, simplifying a few things. You can add separate regular typed arenas for things you can't make dropless. |
|
☔ The latest upstream changes (presumably #56502) made this pull request unmergeable. Please resolve the merge conflicts. |
|
To be honest, that sounds a bit too magical for my taste. cc @rust-lang/compiler |
|
@eddyb wrote:
I want to clarify the point eddyb is making here. @eddyb, are you asking for @Zoxc to revise this PR to get rid of Or is your point just to explain what the purpose of |
|
@pnkfelix The former, except it's not a |
bors
added a commit
that referenced
this pull request
Mar 31, 2019
Introduce an arena type which may be used to allocate a list of types with destructors You can also specify that you want deserializers for `&'tcx [T]` and `&'tcx T` for a type in the list, which will allocate those using the arena. Based on #59517 and #59533. Look at the last commit for the interesting changes. An alternative to #56448. cc @michaelwoerister @eddyb r? @oli-obk
bors
added a commit
that referenced
this pull request
Apr 12, 2019
Introduce an arena type which may be used to allocate a list of types with destructors You can also specify that you want deserializers for `&'tcx [T]` and `&'tcx T` for a type in the list, which will allocate those using the arena. Based on #59517 and #59533. Look at the last commit for the interesting changes. An alternative to #56448. cc @michaelwoerister @eddyb r? @oli-obk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cleaned up part from #56382.
Uses PROC MACROS! cc @eddyb
r? @michaelwoerister