-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change untagged_unions to not allow union fields with drop #56440
Closed
Commits on Jan 12, 2019
-
Change untagged_unions to not allow union fields with drop
Union fields may now never have a type with attached destructor. This for example allows unions to use arbitrary field types only by wrapping them in ManuallyDrop. The stable rule remains, that union fields must be Copy. We use the new rule for the `untagged_union` feature. See RFC 2514.
Configuration menu - View commit details
-
Copy full SHA for acf82c7 - Browse repository at this point
Copy the full SHA acf82c7View commit details -
Update libcore/std for union fields with drop
We now use ManuallyDrop for equivalent effect.
Configuration menu - View commit details
-
Copy full SHA for bfac2f7 - Browse repository at this point
Copy the full SHA bfac2f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d17e54f - Browse repository at this point
Copy the full SHA d17e54fView commit details
Commits on Jan 13, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 776d5d4 - Browse repository at this point
Copy the full SHA 776d5d4View commit details -
Update ui tests for union fields with drop rule change
Note: We can't test move out through Box's deref-move since we can't have a Box in a union anymore.
Configuration menu - View commit details
-
Copy full SHA for 0950bdf - Browse repository at this point
Copy the full SHA 0950bdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4b2d71 - Browse repository at this point
Copy the full SHA f4b2d71View commit details -
Add note to TyS::needs_drop about union dependency on it
For now, part of unstable feature untagged_unions.
Configuration menu - View commit details
-
Copy full SHA for 87c66a8 - Browse repository at this point
Copy the full SHA 87c66a8View commit details
Commits on Jan 14, 2019
-
Configuration menu - View commit details
-
Copy full SHA for acd71e9 - Browse repository at this point
Copy the full SHA acd71e9View commit details
Commits on Jan 20, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0eda54f - Browse repository at this point
Copy the full SHA 0eda54fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.