Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo the docs for Vec::set_len #56425

Merged
merged 5 commits into from
Jan 12, 2019
Merged

Conversation

scottmcm
Copy link
Member

@scottmcm scottmcm commented Dec 2, 2018

Inspired by the recent conversation on IRLO.

This is just my first stab at this; suggestions welcome.

Inspired by the recent conversation on IRLO.
@rust-highfive
Copy link
Collaborator

r? @bluss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 2, 2018
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvement suggestions. :)

src/liballoc/vec.rs Outdated Show resolved Hide resolved
src/liballoc/vec.rs Outdated Show resolved Hide resolved
src/liballoc/vec.rs Show resolved Hide resolved
src/liballoc/vec.rs Outdated Show resolved Hide resolved
src/liballoc/vec.rs Outdated Show resolved Hide resolved
src/liballoc/vec.rs Outdated Show resolved Hide resolved
src/liballoc/vec.rs Outdated Show resolved Hide resolved
src/liballoc/vec.rs Show resolved Hide resolved
src/liballoc/vec.rs Show resolved Hide resolved
src/liballoc/vec.rs Outdated Show resolved Hide resolved
@Dylan-DPC-zz
Copy link

ping from triage @scottmcm can you update this with the changes suggested above?
r?@Centril

@rust-highfive rust-highfive assigned Centril and unassigned bluss Dec 10, 2018
Add @Centril's comment

Co-Authored-By: scottmcm <[email protected]>
@scottmcm
Copy link
Member Author

scottmcm commented Jan 3, 2019

@Centril I'm still on vacation without access to my computer. Can you make proposed changes here so I can apply them from my phone, like I just did your other one?

@Centril
Copy link
Contributor

Centril commented Jan 3, 2019

@scottmcm sure, I'll get to it in a bit.

@Centril
Copy link
Contributor

Centril commented Jan 9, 2019

@scottmcm made a PR instead: scottmcm#1

@bors delegate+

@bors
Copy link
Contributor

bors commented Jan 9, 2019

✌️ @scottmcm can now approve this pull request

@Centril
Copy link
Contributor

Centril commented Jan 9, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 9, 2019

📌 Commit 986e49d has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2019
@bors
Copy link
Contributor

bors commented Jan 10, 2019

⌛ Testing commit 986e49d with merge 5d0a33d1dc1ad0dec2dfed9680ae3633ec84ad6f...

@bors
Copy link
Contributor

bors commented Jan 10, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 10, 2019
@pietroalbini
Copy link
Member

@bors retry
AppVeyor... what's wrong with you today?

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 12, 2019
…entril

Redo the docs for Vec::set_len

Inspired by the [recent conversation on IRLO](https://internals.rust-lang.org/t/make-vec-set-len-enforce-the-len-cap-invariant/8927/23?u=scottmcm).

This is just my first stab at this; suggestions welcome.
bors added a commit that referenced this pull request Jan 12, 2019
Rollup of 26 pull requests

Successful merges:

 - #56425 (Redo the docs for Vec::set_len)
 - #56906 (Issue #56905)
 - #57042 (Don't call `FieldPlacement::count` when count is too large)
 - #57175 (Stabilize `let` bindings and destructuring in constants and const fn)
 - #57192 (Change std::error::Error trait documentation to talk about `source` instead of `cause`)
 - #57296 (Fixed the link to the ? operator)
 - #57368 (Use CMAKE_{C,CXX}_COMPILER_LAUNCHER for ccache)
 - #57400 (Rustdoc: update Source Serif Pro and replace Heuristica italic)
 - #57417 (rustdoc: use text-based doctest parsing if a macro is wrapping main)
 - #57433 (Add link destination for `read-ownership`)
 - #57434 (Remove `CrateNum::Invalid`.)
 - #57441 (Supporting backtrace for x86_64-fortanix-unknown-sgx.)
 - #57450 (actually take a slice in this example)
 - #57459 (Reference tracking issue for inherent associated types in diagnostic)
 - #57463 (docs: Fix some 'second-edition' links)
 - #57466 (Remove outdated comment)
 - #57493 (use structured suggestion when casting a reference)
 - #57498 (make note of one more normalization that Paths do)
 - #57499 (note that FromStr does not work for borrowed types)
 - #57505 (Remove submodule step from README)
 - #57510 (Add a profiles section to the manifest)
 - #57511 (Fix undefined behavior)
 - #57519 (Correct RELEASES.md for 1.32.0)
 - #57522 (don't unwrap unexpected tokens in `format!`)
 - #57530 (Fixing a typographical error.)
 - #57535 (Stabilise irrefutable if-let and while-let patterns)

Failed merges:

r? @ghost
@bors bors merged commit 986e49d into rust-lang:master Jan 12, 2019
@scottmcm scottmcm deleted the redo-vec-set_len-docs branch January 14, 2019 07:15
ExpHP added a commit to ExpHP/perm-vec that referenced this pull request Feb 3, 2021
In the time since this code was originally written, an update to the
Vec docs clarified the rules of safety for Vec::set_len and require
that the newly-accessible elements are already initialized.

rust-lang/rust#56425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants