Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "appveyor: Use VS2017 for all our images" #56201

Merged
merged 1 commit into from
Nov 24, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Nov 24, 2018

This reverts commit 008e5dc (#55935)

We suspect this causes the spurious failure in #55906 (comment) and #55915 (comment).

r? @alexcrichton

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 24, 2018
@alexcrichton
Copy link
Member

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Nov 24, 2018

📌 Commit 91f8e37 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2018
@bors
Copy link
Contributor

bors commented Nov 24, 2018

⌛ Testing commit 91f8e37 with merge edaac35...

bors added a commit that referenced this pull request Nov 24, 2018
Revert "appveyor: Use VS2017 for all our images"

This reverts commit 008e5dc (#55935)

We suspect this causes the spurious failure in #55906 (comment) and #55915 (comment).

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Nov 24, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing edaac35 to master...

@bors bors merged commit 91f8e37 into rust-lang:master Nov 24, 2018
@kennytm kennytm deleted the revert-55935 branch November 25, 2018 03:31
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 1, 2019
Originally added in rust-lang#55935 to test build times, this was reverted
in rust-lang#56201 due to a belief that it caused the exit code 259 spurious
errors. We've since learned, however, that the 259 exit code is likely
not related to this image update as we're getting it in a number of
locations now.

VS2017 looks like it may be required to compile LLVm in the near future,
notably discovered by rust-lang#58408 where we attempted to update LLVM.
kennytm added a commit to kennytm/rust that referenced this pull request Mar 11, 2019
…-Simulacrum

appveyor: Use VS2017 for all our images

Originally added in rust-lang#55935 to test build times, this was reverted
in rust-lang#56201 due to a belief that it caused the exit code 259 spurious
errors. We've since learned, however, that the 259 exit code is likely
not related to this image update as we're getting it in a number of
locations now.

VS2017 looks like it may be required to compile LLVm in the near future,
notably discovered by rust-lang#58408 where we attempted to update LLVM.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Mar 12, 2019
…-Simulacrum

appveyor: Use VS2017 for all our images

Originally added in rust-lang#55935 to test build times, this was reverted
in rust-lang#56201 due to a belief that it caused the exit code 259 spurious
errors. We've since learned, however, that the 259 exit code is likely
not related to this image update as we're getting it in a number of
locations now.

VS2017 looks like it may be required to compile LLVm in the near future,
notably discovered by rust-lang#58408 where we attempted to update LLVM.
kennytm added a commit to kennytm/rust that referenced this pull request Mar 15, 2019
…-Simulacrum

appveyor: Use VS2017 for all our images

Originally added in rust-lang#55935 to test build times, this was reverted
in rust-lang#56201 due to a belief that it caused the exit code 259 spurious
errors. We've since learned, however, that the 259 exit code is likely
not related to this image update as we're getting it in a number of
locations now.

VS2017 looks like it may be required to compile LLVm in the near future,
notably discovered by rust-lang#58408 where we attempted to update LLVM.
kennytm added a commit to kennytm/rust that referenced this pull request Mar 16, 2019
…-Simulacrum

appveyor: Use VS2017 for all our images

Originally added in rust-lang#55935 to test build times, this was reverted
in rust-lang#56201 due to a belief that it caused the exit code 259 spurious
errors. We've since learned, however, that the 259 exit code is likely
not related to this image update as we're getting it in a number of
locations now.

VS2017 looks like it may be required to compile LLVm in the near future,
notably discovered by rust-lang#58408 where we attempted to update LLVM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants