Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] backport rollup (typeck match arms eagerly; add rustc_promotable to unsigneds) #55893

Merged
merged 2 commits into from
Nov 13, 2018
Merged

[beta] backport rollup (typeck match arms eagerly; add rustc_promotable to unsigneds) #55893

merged 2 commits into from
Nov 13, 2018

Conversation

pnkfelix
Copy link
Member

@pnkfelix pnkfelix commented Nov 12, 2018 •
edited
Loading

Backport of 5f91373 from (beta-accepted) PR #55819

Fix #55810
Fix #55806

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2018
@pnkfelix pnkfelix changed the title Typecheck patterns of all match arms first, so we get types for bindings [beta] Typecheck patterns of all match arms first, so we get types for bindings Nov 12, 2018
@pnkfelix
Copy link
Member Author

This was beta-accepted by @estebank so I'm going to treat that as the r+ here

@pnkfelix
Copy link
Member Author

@bors r=estebank

@bors
Copy link
Contributor

bors commented Nov 12, 2018

📌 Commit 1c0cc97 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2018
@pietroalbini
Copy link
Member

Can you also include #55828 in this?

@pnkfelix
Copy link
Member Author

pnkfelix commented Nov 12, 2018 •
edited
Loading

as requested, cherry-picked the commit from #55828 into this PR

@pnkfelix
Copy link
Member Author

@bors r=estebank

@bors
Copy link
Contributor

bors commented Nov 12, 2018

📌 Commit 1e145d1 has been approved by estebank

@pnkfelix pnkfelix changed the title [beta] Typecheck patterns of all match arms first, so we get types for bindings [beta] backport rollup (typeck match arms eagerly; add rustc_promotable to unsigneds) Nov 12, 2018
@pietroalbini
Copy link
Member

@bors p=10 (beta backports)

@bors
Copy link
Contributor

bors commented Nov 12, 2018

⌛ Testing commit 1e145d1 with merge c341a59...

bors added a commit that referenced this pull request Nov 12, 2018
@bors
Auto merge of #55893 - pnkfelix:issue-55810-beta-backport-of-pr-55819…
c341a59 
…, r=estebank

[beta] backport rollup (typeck match arms eagerly; add rustc_promotable to unsigneds)

Backport of 5f91373 from (beta-accepted) PR #55819

Fix #55810
Fix #55806
@bors
Copy link
Contributor

bors commented Nov 13, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: estebank
Pushing c341a59 to beta...

@bors bors merged commit 1e145d1 into rust-lang:beta Nov 13, 2018
@goffrie goffrie mentioned this pull request Nov 14, 2018
Closed
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pnkfelix @rust-highfive @bors @pietroalbini @Centril @estebank @oli-obk