Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore target folders #55213

Merged
merged 1 commit into from
Oct 21, 2018
Merged

ignore target folders #55213

merged 1 commit into from
Oct 21, 2018

Conversation

qmx
Copy link
Member

@qmx qmx commented Oct 19, 2018

when you try to edit a crate inside the compiler tree using rls, it
generates it's assets under target/rls, then tidy is trying to validate
line lenghts for C headers, etc

when you try to edit a crate inside the compiler tree using rls, it
generates it's assets under target/rls, then tidy is trying to validate
line lenghts for C headers, etc
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2018
@euclio
Copy link
Contributor

euclio commented Oct 19, 2018

Fixes #52158 🎉

@tmandry
Copy link
Member

tmandry commented Oct 19, 2018

It's worth noting that rustfmt actually has real code under directories named target..

$ find . -name target
./src/tools/rustfmt/tests/target
./src/tools/rustfmt/tests/writemode/target
./src/tools/rustfmt/tests/coverage/target
./src/target
./src/llvm/bindings/ocaml/target

...but we ignore code from submodules anyway, so this should be ok.

Thanks 😄
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 19, 2018

📌 Commit cf90f72 has been approved by tmandry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2018
Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 20, 2018
when you try to edit a crate inside the compiler tree using rls, it
generates it's assets under target/rls, then tidy is trying to validate
line lenghts for C headers, etc
bors added a commit that referenced this pull request Oct 20, 2018
Rollup of 5 pull requests

Successful merges:

 - #55156 (Fixed: Multiple errors on single typo in match pattern)
 - #55189 (update books for the next release)
 - #55193 (make asm diagnostic instruction optional)
 - #55203 (Write an initial version of the `program_clauses` callback)
 - #55213 (ignore target folders)

Failed merges:

r? @ghost
@bors bors merged commit cf90f72 into rust-lang:master Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants