Rollup of 14 pull requests #54990

Mark-Simulacrum · 2018-10-11T14:32:32Z

Successful merges:

Documents reference equality by address (#54197) #54755 (Documents reference equality by address (Cover reference equality in primitive.reference API docs #54197))
During rustc bootstrap, make default for optimize independent of debug #54811 (During rustc bootstrap, make default for optimize independent of debug)
NLL says "borrowed content" instead of more precise "dereference of raw pointer" #54825 (NLL says "borrowed content" instead of more precise "dereference of raw pointer")
Add doc comments about safest way to initialize a vector of zeros #54860 (Add doc comments about safest way to initialize a vector of zeros)
Fix tracking issue for Once::is_completed #54891 (Fix tracking issue for Once::is_completed)
doc fix: it's auto traits that make for automatic implementations #54913 (doc fix: it's auto traits that make for automatic implementations)
submodules: update clippy, rls and cargo, fix toolstate #54916 (submodules: update clippy, rls and cargo, fix toolstate)
Unused result warning: "X which must" ↦ "X that must" #54917 (Unused result warning: "X which must" ↦ "X that must")
Fix handling of #[must_use] on unit and uninhabited types #54920 (Fix handling of #[must_use] on unit and uninhabited types)
A handful of random string-related improvements #54932 (A handful of random string-related improvements)
impl Eq+Hash for TyLayout #54936 (impl Eq+Hash for TyLayout)
"(using ..." doesn't have the matching ")" #54956 ("(using ..." doesn't have the matching ")")
add a macro for static (compile-time) assertions #54958 (add a macro for static (compile-time) assertions)
Remove incorrect span for second label inner macro invocation #54967 (Remove incorrect span for second label inner macro invocation)

Failed merges:

Clarification of the use of `ptr::eq` to test equality of references via address by pointer coercion

…g` setting in `Cargo.toml`.

Previously, move errors involving the dereference of a raw pointer would say "borrowed content". This commit changes it to say "dereference of raw pointer".

and to briefly touch on the theory of debugging rustc versus the practice of such.

Fixes rust-lang#54948.

Changes: Remove now-useless `allow(unknown_lints)` Stabilize tool lints Use `impl Iterator` in arg position in clippy_dev Fix fn_to_numeric_cast_with_truncation suppression Limit commutative assign op lint to primitive types Clarify code Fix rust-lang#2937 Fix cast_possible_wrap and cast_sign_loss warnings Fix cast_possible_truncation warnings Fixes rust-lang#2925 cmp_owned false positive if_let_redundant_pattern_matching: use Span.to() instead of Span.with_hi() to fix crash. Improve diagnostics in case of lifetime elision (closes rust-lang#3284) Fix items_after_statements for `const`s Fix items_after_statements for sub-functions Fix items_after_statements for `use` statements Don't suggest cloned() for map Box deref Fix excessive_precision false positive Fix FP in `fn_to_numeric_cast_with_truncation` new_without_default should not warn about unsafe new fix command to manually test an example Add license to README Adding more detail to filter_map lint documentation. additional people Add license header to other files Add license header to Rust files Relicense clippy Document relicensing process Fix util/export.py to include lints from methods

Changes: Apply Clippy lints Respect build_dir when creating external build plans Fix Windows tests Implement external build plan Detect manifest diagnostic position for toml::de::Error Fix std::sync hover doc expectation Apply CI specific long timeout Propagate cargo errors as manifest diagnostics Add test for use statement function completions Refactor cmd test `within_timeout` Avoid stdout-writer/rls process exit race Improve cmd test "no shutdown response" error message Add RUST_BACKTRACE=1 to ci env Improve cmd test timeout reliability Fix use statement function suggestions Revert "Revert "Remove "edition" Cargo feature (it's stable now)"" Add build_wait() tests Automatically tune wait_to_build Rework cmd tests Fixes rust-lang#54697

Changes: Switch to use crates-io as the registry name and don't include publish when registry is not specified fix redundant pkgid generation validate some basic properties of a valid resolve Detail dep name in invalid version error Fix dashes in rename dependencies. Bump flate2 to 1.0.3 Add default in config document Add support for providing a default registry Add support for registry to new and init use impl Iterator instead of custom types in `source` let jetbrains reorder some impls to match the definition use impl Iterator instead of custom types in resolver and graph remove Graph::sort as it is unused fmt Bump libgit2-sys to 0.7.9 Switch to use registry Allow registry option for cargo install. Second attempt at fixing msys terminal width. Try to improve "version not found" error Fix typo

…ss-eq, r=QuietMisdreavus Documents reference equality by address (rust-lang#54197) Clarification of the use of `ptr::eq` to test equality of references via address by pointer coercion, regarding issue rust-lang#54197 . The same example as in `ptr::eq` docs is shown here to clarify that `PartialEq` compares values pointed-to instead of via address (which can be desired in some cases)

…trap-default-for-optimize-from-debug-setting, r=nikomatsakis During rustc bootstrap, make default for `optimize` independent of `debug` It may have taken me three and a half years, but I'm following through on my ["threat"](rust-lang#24840 (comment)) Fix rust-lang#24840

@nikomatsakis

…nter, r=pnkfelix NLL says "borrowed content" instead of more precise "dereference of raw pointer" Part of rust-lang#52663. Previously, move errors involving the dereference of a raw pointer would say "borrowed content". This commit changes it to say "dereference of raw pointer". r? @nikomatsakis cc @pnkfelix

Add doc comments about safest way to initialize a vector of zeros This adds more information about the vec! macro as discussed in rust-lang#54628. I think this is a good starting point, but I think additional detail is needed so that we can explain why vec! is safer than the alternatives.

@matklad

Fix tracking issue for Once::is_completed rust-lang#53027 was merged without a tracking issue. I just filed rust-lang#54890. CC @matklad

@alexcrichton

doc fix: it's auto traits that make for automatic implementations Being a marker trait is not good enough (that just means "no items in the trait"). r? @alexcrichton who [originally wrote these docs](RalfJung@0a13f1a).

…li-obk submodules: update clippy, rls and cargo, fix toolstate rustfmt update failed because of different rustc-ap-syntax versions. fix clippy toolstate failure Fixes rust-lang#54697

Unused result warning: "X which must" ↦ "X that must" Address a little grammatical faux pas in the unused result warning.

Fix handling of #[must_use] on unit and uninhabited types Fixes rust-lang#54828.

…ents, r=alexcrichton A handful of random string-related improvements - remove a few allocations in `errors/diagnostic` - make `build_helper::gnu_target` return `Cow<str>`

@eddyb

impl Eq+Hash for TyLayout As proposed by @eddyb at rust-lang#53671 (review). I have an upcoming PR that would also significantly benefit from this.

"(using ..." doesn't have the matching ")" Fixes rust-lang#54948.

@oli-obk

add a macro for static (compile-time) assertions Cc @oli-obk

Remove incorrect span for second label inner macro invocation A fix for issue rust-lang#54841

Mark-Simulacrum · 2018-10-11T14:34:16Z

@bors r+ p=5

bors · 2018-10-11T14:34:17Z

📌 Commit e5ed251 has been approved by Mark-Simulacrum

bors · 2018-10-11T15:08:42Z

⌛ Testing commit e5ed251 with merge 6a804aeae500b44a0c9703b1ea8e377bece39005...

rust-highfive · 2018-10-11T15:29:45Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:51:04] .................................................................................................... 300/4592
[00:51:07] .................................................................................................... 400/4592
[00:51:10] .................................................................................................... 500/4592
[00:51:14] ........i........................................................................................... 600/4592
[00:51:19] ....F............................................................................................... 700/4592
[00:51:28] ..........................................................iiiii..................................... 900/4592
[00:51:31] .................................................................................................... 1000/4592
[00:51:33] .................................................................................................... 1100/4592
[00:51:36] .................................................................................................... 1200/4592
---
[00:52:22] .................................................................................................... 2500/4592
[00:52:27] .................................................................................................... 2600/4592
[00:52:31] .................................................................................................... 2700/4592
[00:52:34] .................................................................................................... 2800/4592
[00:52:38] .............................................................................F...................... 2900/4592
[00:52:45] .................................................................................................... 3100/4592
[00:52:48] .......i.i..ii...................................................................................... 3200/4592
[00:52:53] .................................................................................................... 3300/4592
[00:52:56] ...........................................................i........................................ 3400/4592
---
[00:53:38] 
[00:53:38] ---- [ui] ui/conditional-compilation/cfg-attr-multi-true.rs stdout ----
[00:53:38] diff of stderr:
[00:53:38] 
[00:53:38] 24 LL |         MustUseDeprecated {} //~ warning: use of deprecated item
[00:53:38] 26 
[00:53:38] 26 
[00:53:38] - warning: unused `MustUseDeprecated` which must be used
[00:53:38] + warning: unused `MustUseDeprecated` that must be used
[00:53:38] 29    |
[00:53:38] 29    |
[00:53:38] 30 LL |     MustUseDeprecated::new(); //~ warning: use of deprecated item
[00:53:38] 
[00:53:38] The actual stderr differed from the expected stderr.
[00:53:38] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/conditional-compilation/cfg-attr-multi-true/cfg-attr-multi-true.stderr
[00:53:38] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/conditional-compilation/cfg-attr-multi-true/cfg-attr-multi-true.stderr
[00:53:38] To update references, rerun the tests and pass the `--bless` flag
[00:53:38] To only update this specific test, also pass `--test-args conditional-compilation/cfg-attr-multi-true.rs`
[00:53:38] error: 1 errors occurred comparing output.
[00:53:38] status: exit code: 0
[00:53:38] status: exit code: 0
[00:53:38] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/conditional-compilation/cfg-attr-multi-true/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/conditional-compilation/cfg-attr-multi-true/auxiliary" "-A" "unused"
[00:53:38] ------------------------------------------
[00:53:38] 
[00:53:38] ------------------------------------------
[00:53:38] stderr:
[00:53:38] stderr:
[00:53:38] ------------------------------------------
[00:53:38] {"message":"use of deprecated item 'MustUseDeprecated'","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs","byte_start":334,"byte_end":351,"line_start":13,"line_end":13,"column_start":6,"column_end":23,"is_primary":true,"text":[{"text":"impl MustUseDeprecated { //~ warning: use of deprecated item","highlight_start":6,"highlight_end":23}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"#[warn(deprecated)] on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: use of deprecated item 'MustUseDeprecated'\n  --> /checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs:13:6\n   |\nLL | impl MustUseDeprecated { //~ warning: use of deprecated item\n   |      ^^^^^^^^^^^^^^^^^\n   |\n   = note: #[warn(deprecated)] on by default\n\n"}
[00:53:38] {"message":"use of deprecated item 'MustUseDeprecated'","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs","byte_start":552,"byte_end":574,"line_start":20,"line_end":20,"column_start":5,"column_end":27,"is_primary":true,"text":[{"text":"    MustUseDeprecated::new(); //~ warning: use of deprecated item","highlight_start":5,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: use of deprecated item 'MustUseDeprecated'\n  --> /checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs:20:5\n   |\nLL |     MustUseDeprecated::new(); //~ warning: use of deprecated item\n   |     ^^^^^^^^^^^^^^^^^^^^^^\n\n"}
[00:53:38] {"message":"use of deprecated item 'MustUseDeprecated'","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs","byte_start":406,"byte_end":423,"line_start":14,"line_end":14,"column_start":17,"column_end":34,"is_primary":true,"text":[{"text":"    fn new() -> MustUseDeprecated { //~ warning: use of deprecated item","highlight_start":17,"highlight_end":34}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: use of deprecated item 'MustUseDeprecated'\n  --> /checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs:14:17\n   |\nLL |     fn new() -> MustUseDeprecated { //~ warning: use of deprecated item\n   |                 ^^^^^^^^^^^^^^^^^\n\n"}
[00:53:38] {"message":"use of deprecated item 'MustUseDeprecated'","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs","byte_start":470,"byte_end":487,"line_start":15,"line_end":15,"column_start":9,"column_end":26,"is_primary":true,"text":[{"text":"        MustUseDeprecated {} //~ warning: use of deprecated item","highlight_start":9,"highlight_end":26}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: use of deprecated item 'MustUseDeprecated'\n  --> /checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs:15:9\n   |\nLL |         MustUseDeprecated {} //~ warning: use of deprecated item\n   |         ^^^^^^^^^^^^^^^^^\n\n"}
[00:53:38] {"message":"unused `MustUseDeprecated` that must be used","code":{"code":"unused_must_use","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs","byte_start":552,"byte_end":577,"line_start":20,"line_end":20,"column_start":5,"column_end":30,"is_primary":true,"text":[{"text":"    MustUseDeprecated::new(); //~ warning: use of deprecated item","highlight_start":5,"highlight_end":30}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"lint level defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs","byte_start":212,"byte_end":227,"line_start":7,"line_end":7,"column_start":9,"column_end":24,"is_primary":true,"text":[{"text":"#![warn(unused_must_use)]","highlight_start":9,"highlight_end":24}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"warning: unused `MustUseDeprecated` that must be used\n  --> /checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs:20:5\n   |\nLL |     MustUseDeprecated::new(); //~ warning: use of deprecated item\n   |     ^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\nnote: lint level defined here\n  --> /checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs:7:9\n   |\nLL | #![warn(unused_must_use)]\n   |         ^^^^^^^^^^^^^^^\n\n"}
[00:53:38] ------------------------------------------
[00:53:38] 
[00:53:38] thread '[ui] ui/conditional-compilation/cfg-attr-multi-true.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3277:9
[00:53:38] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:53:38] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:53:38] 
[00:53:38] ---- [ui] ui/lint/must_use-unit.rs stdout ----
[00:53:38] diff of stderr:
[00:53:38] 
[00:53:38] - error: unused return value of `foo` which must be used
[00:53:38] + error: unused return value of `foo` that must be used
[00:53:38] 3    |
[00:53:38] 3    |
[00:53:38] 4 LL |     foo(); //~ unused return value of `foo`
[00:53:38] 
[00:53:38] 10 LL | #![deny(unused_must_use)]
[00:53:38] 12 
[00:53:38] 12 
[00:53:38] - error: unused return value of `bar` which must be used
[00:53:38] + error: unused return value of `bar` that must be used
[00:53:38] 15    |
[00:53:38] 15    |
[00:53:38] 16 LL |     bar(); //~ unused return value of `bar`
[00:53:38] 
[00:53:38] The actual stderr differed from the expected stderr.
[00:53:38] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/must_use-unit/must_use-unit.stderr
[00:53:38] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/must_use-unit/must_use-unit.stderr
[00:53:38] To update references, rerun the tests and pass the `--bless` flag
[00:53:38] To only update this specific test, also pass `--test-args lint/must_use-unit.rs`
[00:53:38] error: 1 errors occurred comparing output.
[00:53:38] status: exit code: 1
[00:53:38] status: exit code: 1
[00:53:38] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/must_use-unit.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/must_use-unit/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/must_use-unit/auxiliary" "-A" "unused"
[00:53:38] ------------------------------------------
[00:53:38] 
[00:53:38] ------------------------------------------
[00:53:38] stderr:
[00:53:38] stderr:
[00:53:38] ------------------------------------------
[00:53:38] {"message":"unused return value of `foo` that must be used","code":{"code":"unused_must_use","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/lint/must_use-unit.rs","byte_start":145,"byte_end":151,"line_start":14,"line_end":14,"column_start":5,"column_end":11,"is_primary":true,"text":[{"text":"    foo(); //~ unused return value of `foo`","highlight_start":5,"highlight_end":11}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"lint level defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/lint/must_use-unit.rs","byte_start":33,"byte_end":48,"line_start":3,"line_end":3,"column_start":9,"column_end":24,"is_primary":true,"text":[{"text":"#![deny(unused_must_use)]","highlight_start":9,"highlight_end":24}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"error: unused return value of `foo` that must be used\n  --> /checkout/src/test/ui/lint/must_use-unit.rs:14:5\n   |\nLL |     foo(); //~ unused return value of `foo`\n   |     ^^^^^^\n   |\nnote: lint level defined here\n  --> /checkout/src/test/ui/lint/must_use-unit.rs:3:9\n   |\nLL | #![deny(unused_must_use)]\n   |         ^^^^^^^^^^^^^^^\n\n"}
[00:53:38] {"message":"unused return value of `bar` that must be used","code":{"code":"unused_must_use","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/lint/must_use-unit.rs","byte_start":190,"byte_end":196,"line_start":16,"line_end":16,"column_start":5,"column_end":11,"is_primary":true,"text":[{"text":"    bar(); //~ unused return value of `bar`","highlight_start":5,"highlight_end":11}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: unused return value of `bar` that must be used\n  --> /checkout/src/test/ui/lint/must_use-unit.rs:16:5\n   |\nLL |     bar(); //~ unused return value of `bar`\n   |     ^^^^^^\n\n"}
[00:53:38] {"message":"aborting due to 2 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 2 previous errors\n\n"}
[00:53:38] ------------------------------------------
[00:53:38] 
[00:53:38] thread '[ui] ui/lint/must_use-unit.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3277:9
[00:53:38] 
---
[00:53:38] 
[00:53:38] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:501:22
[00:53:38] 
[00:53:38] 
[00:53:38] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:53:38] 
[00:53:38] 
[00:53:38] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:53:38] Build completed unsuccessfully in 0:03:52
[00:53:38] Build completed unsuccessfully in 0:03:52
[00:53:38] Makefile:58: recipe for target 'check' failed
[00:53:38] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:03ef7a80
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:267dad98:start=1539271774933487866,finish=1539271774938203014,duration=4715148
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:06e31c00
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1a4b9d2b
travis_time:start:1a4b9d2b
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:005d3a64
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2018-10-11T16:00:13Z

💔 Test failed - status-travis

rust-highfive · 2018-10-11T16:00:14Z

The job dist-x86_64-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:45:23] 
[00:45:23] ---- [ui] ui/conditional-compilation/cfg-attr-multi-true.rs stdout ----
[00:45:23] diff of stderr:
[00:45:23] 
[00:45:23] 24 LL |         MustUseDeprecated {} //~ warning: use of deprecated item
[00:45:23] 26 
[00:45:23] 26 
[00:45:23] - warning: unused `MustUseDeprecated` which must be used
[00:45:23] + warning: unused `MustUseDeprecated` that must be used
[00:45:23] 29    |
[00:45:23] 29    |
[00:45:23] 30 LL |     MustUseDeprecated::new(); //~ warning: use of deprecated item
[00:45:23] 
[00:45:23] The actual stderr differed from the expected stderr.
[00:45:23] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/conditional-compilation/cfg-attr-multi-true/cfg-attr-multi-true.stderr
[00:45:23] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/conditional-compilation/cfg-attr-multi-true/cfg-attr-multi-true.stderr
[00:45:23] To update references, rerun the tests and pass the `--bless` flag
[00:45:23] To only update this specific test, also pass `--test-args conditional-compilation/cfg-attr-multi-true.rs`
[00:45:23] error: 1 errors occurred comparing output.
[00:45:23] status: exit code: 0
[00:45:23] status: exit code: 0
[00:45:23] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs" "--target=x86_64-unknown-linux-musl" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/conditional-compilation/cfg-attr-multi-true/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-musl/native/rust-test-helpers" "-Clinker=/musl-x86_64/bin/musl-gcc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/conditional-compilation/cfg-attr-multi-true/auxiliary" "-A" "unused"
[00:45:23] ------------------------------------------
[00:45:23] 
[00:45:23] ------------------------------------------
[00:45:23] stderr:
[00:45:23] stderr:
[00:45:23] ------------------------------------------
[00:45:23] {"message":"use of deprecated item 'MustUseDeprecated'","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs","byte_start":334,"byte_end":351,"line_start":13,"line_end":13,"column_start":6,"column_end":23,"is_primary":true,"text":[{"text":"impl MustUseDeprecated { //~ warning: use of deprecated item","highlight_start":6,"highlight_end":23}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"#[warn(deprecated)] on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: use of deprecated item 'MustUseDeprecated'\n  --> /checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs:13:6\n   |\nLL | impl MustUseDeprecated { //~ warning: use of deprecated item\n   |      ^^^^^^^^^^^^^^^^^\n   |\n   = note: #[warn(deprecated)] on by default\n\n"}
[00:45:23] {"message":"use of deprecated item 'MustUseDeprecated'","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs","byte_start":552,"byte_end":574,"line_start":20,"line_end":20,"column_start":5,"column_end":27,"is_primary":true,"text":[{"text":"    MustUseDeprecated::new(); //~ warning: use of deprecated item","highlight_start":5,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: use of deprecated item 'MustUseDeprecated'\n  --> /checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs:20:5\n   |\nLL |     MustUseDeprecated::new(); //~ warning: use of deprecated item\n   |     ^^^^^^^^^^^^^^^^^^^^^^\n\n"}
[00:45:23] {"message":"use of deprecated item 'MustUseDeprecated'","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs","byte_start":406,"byte_end":423,"line_start":14,"line_end":14,"column_start":17,"column_end":34,"is_primary":true,"text":[{"text":"    fn new() -> MustUseDeprecated { //~ warning: use of deprecated item","highlight_start":17,"highlight_end":34}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: use of deprecated item 'MustUseDeprecated'\n  --> /checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs:14:17\n   |\nLL |     fn new() -> MustUseDeprecated { //~ warning: use of deprecated item\n   |                 ^^^^^^^^^^^^^^^^^\n\n"}
[00:45:23] {"message":"use of deprecated item 'MustUseDeprecated'","code":{"code":"deprecated","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs","byte_start":470,"byte_end":487,"line_start":15,"line_end":15,"column_start":9,"column_end":26,"is_primary":true,"text":[{"text":"        MustUseDeprecated {} //~ warning: use of deprecated item","highlight_start":9,"highlight_end":26}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"warning: use of deprecated item 'MustUseDeprecated'\n  --> /checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs:15:9\n   |\nLL |         MustUseDeprecated {} //~ warning: use of deprecated item\n   |         ^^^^^^^^^^^^^^^^^\n\n"}
[00:45:23] {"message":"unused `MustUseDeprecated` that must be used","code":{"code":"unused_must_use","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs","byte_start":552,"byte_end":577,"line_start":20,"line_end":20,"column_start":5,"column_end":30,"is_primary":true,"text":[{"text":"    MustUseDeprecated::new(); //~ warning: use of deprecated item","highlight_start":5,"highlight_end":30}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"lint level defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs","byte_start":212,"byte_end":227,"line_start":7,"line_end":7,"column_start":9,"column_end":24,"is_primary":true,"text":[{"text":"#![warn(unused_must_use)]","highlight_start":9,"highlight_end":24}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"warning: unused `MustUseDeprecated` that must be used\n  --> /checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs:20:5\n   |\nLL |     MustUseDeprecated::new(); //~ warning: use of deprecated item\n   |     ^^^^^^^^^^^^^^^^^^^^^^^^^\n   |\nnote: lint level defined here\n  --> /checkout/src/test/ui/conditional-compilation/cfg-attr-multi-true.rs:7:9\n   |\nLL | #![warn(unused_must_use)]\n   |         ^^^^^^^^^^^^^^^\n\n"}
[00:45:23] ------------------------------------------
[00:45:23] 
[00:45:23] thread '[ui] ui/conditional-compilation/cfg-attr-multi-true.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3277:9
[00:45:23] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:45:23] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:45:23] 
[00:45:23] ---- [ui] ui/lint/must_use-unit.rs stdout ----
[00:45:23] diff of stderr:
[00:45:23] 
[00:45:23] - error: unused return value of `foo` which must be used
[00:45:23] + error: unused return value of `foo` that must be used
[00:45:23] 3    |
[00:45:23] 3    |
[00:45:23] 4 LL |     foo(); //~ unused return value of `foo`
[00:45:23] 
[00:45:23] 10 LL | #![deny(unused_must_use)]
[00:45:23] 12 
[00:45:23] 12 
[00:45:23] - error: unused return value of `bar` which must be used
[00:45:23] + error: unused return value of `bar` that must be used
[00:45:23] 15    |
[00:45:23] 15    |
[00:45:23] 16 LL |     bar(); //~ unused return value of `bar`
[00:45:23] 
[00:45:23] The actual stderr differed from the expected stderr.
[00:45:23] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/must_use-unit/must_use-unit.stderr
[00:45:23] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/must_use-unit/must_use-unit.stderr
[00:45:23] To update references, rerun the tests and pass the `--bless` flag
[00:45:23] To only update this specific test, also pass `--test-args lint/must_use-unit.rs`
[00:45:23] error: 1 errors occurred comparing output.
[00:45:23] status: exit code: 1
[00:45:23] status: exit code: 1
[00:45:23] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/must_use-unit.rs" "--target=x86_64-unknown-linux-musl" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/must_use-unit/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-musl/native/rust-test-helpers" "-Clinker=/musl-x86_64/bin/musl-gcc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/must_use-unit/auxiliary" "-A" "unused"
[00:45:23] ------------------------------------------
[00:45:23] 
[00:45:23] ------------------------------------------
[00:45:23] stderr:
[00:45:23] stderr:
[00:45:23] ------------------------------------------
[00:45:23] {"message":"unused return value of `foo` that must be used","code":{"code":"unused_must_use","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/lint/must_use-unit.rs","byte_start":145,"byte_end":151,"line_start":14,"line_end":14,"column_start":5,"column_end":11,"is_primary":true,"text":[{"text":"    foo(); //~ unused return value of `foo`","highlight_start":5,"highlight_end":11}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"lint level defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/lint/must_use-unit.rs","byte_start":33,"byte_end":48,"line_start":3,"line_end":3,"column_start":9,"column_end":24,"is_primary":true,"text":[{"text":"#![deny(unused_must_use)]","highlight_start":9,"highlight_end":24}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"error: unused return value of `foo` that must be used\n  --> /checkout/src/test/ui/lint/must_use-unit.rs:14:5\n   |\nLL |     foo(); //~ unused return value of `foo`\n   |     ^^^^^^\n   |\nnote: lint level defined here\n  --> /checkout/src/test/ui/lint/must_use-unit.rs:3:9\n   |\nLL | #![deny(unused_must_use)]\n   |         ^^^^^^^^^^^^^^^\n\n"}
[00:45:23] {"message":"unused return value of `bar` that must be used","code":{"code":"unused_must_use","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/lint/must_use-unit.rs","byte_start":190,"byte_end":196,"line_start":16,"line_end":16,"column_start":5,"column_end":11,"is_primary":true,"text":[{"text":"    bar(); //~ unused return value of `bar`","highlight_start":5,"highlight_end":11}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: unused return value of `bar` that must be used\n  --> /checkout/src/test/ui/lint/must_use-unit.rs:16:5\n   |\nLL |     bar(); //~ unused return value of `bar`\n   |     ^^^^^^\n\n"}
[00:45:23] {"message":"aborting due to 2 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 2 previous errors\n\n"}
[00:45:23] ------------------------------------------
[00:45:23] 
[00:45:23] thread '[ui] ui/lint/must_use-unit.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3277:9
[00:45:23] 
---
[00:45:23] test result: FAILED. 4567 passed; 2 failed; 23 ignored; 0 measured; 0 filtered out
[00:45:23] 
[00:45:23] 
[00:45:23] 
[00:45:23] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-musl/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-musl" "--mode" "ui" "--target" "x86_64-unknown-linux-musl" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--linker" "/musl-x86_64/bin/musl-gcc" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-musl/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "8.0.0svn\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:45:23] 
[00:45:23] 
[00:45:23] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target x86_64-unknown-linux-musl
[00:45:23] Build completed unsuccessfully in 0:42:25
---
travis_time:end:240fca00:start=1539273540965673459,finish=1539273540971640363,duration=5966904
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:149c9685
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1c93e9d8
travis_time:start:1c93e9d8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:10069d3a
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

lucasloisp and others added 30 commits October 2, 2018 13:31

Documents reference equality by address (rust-lang#54197)

74bf59e

Clarification of the use of `ptr::eq` to test equality of references via address by pointer coercion

Cleans trailing whitespace

68236e0

Fix rust-lang#24840: make default for optimize independent of `debu…

ac4945c

…g` setting in `Cargo.toml`.

Add doc comments about safest way to initialize a vector of zeros

82444aa

Fix tracking issue for Once::is_completed

9a9894a

Move errors specify "dereference of raw pointer".

fe8ace8

Previously, move errors involving the dereference of a raw pointer would say "borrowed content". This commit changes it to say "dereference of raw pointer".

Added text explaining the (new) relative roles of optimize+debug

40e20e2

and to briefly touch on the theory of debugging rustc versus the practice of such.

it's auto traits that make for automatic implementations

54a3583

Unused result warning: "X which must" ↦ "X that must"

dd0f5e5

Fix handling of #[must_use] on unit and uninhabited types

be88961

Refactor macro comment and add resize with zeros example

1e584bf

"(using ..." doesn't have the matching ")"

da17e07

Fixes rust-lang#54948.

A handful of random string-related improvements

a01a994

add a macro for static assertions

a332387

Remove incorrect span for second label inner macro invocation

05bb22d

impl Eq+Hash for TyLayout

99db3e9

Rollup merge of rust-lang#54891 - rust-lang:SimonSapin-patch-1, r=nagisa

f64e28e

Fix tracking issue for Once::is_completed rust-lang#53027 was merged without a tracking issue. I just filed rust-lang#54890. CC @matklad

Rollup merge of rust-lang#54916 - matthiaskrgr:submodules_update, r=o…

8ce7ce2

…li-obk submodules: update clippy, rls and cargo, fix toolstate rustfmt update failed because of different rustc-ap-syntax versions. fix clippy toolstate failure Fixes rust-lang#54697

Rollup merge of rust-lang#54917 - varkor:unused-which, r=cramertj

fecbfad

Unused result warning: "X which must" ↦ "X that must" Address a little grammatical faux pas in the unused result warning.

Rollup merge of rust-lang#54920 - varkor:must_use-unit, r=estebank

c0b88c7

Fix handling of #[must_use] on unit and uninhabited types Fixes rust-lang#54828.

Rollup merge of rust-lang#54932 - ljedrz:a_handful_of_string_improvem…

9943961

…ents, r=alexcrichton A handful of random string-related improvements - remove a few allocations in `errors/diagnostic` - make `build_helper::gnu_target` return `Cow<str>`

Rollup merge of rust-lang#54936 - RalfJung:layout-hash, r=oli-obk

f432741

impl Eq+Hash for TyLayout As proposed by @eddyb at rust-lang#53671 (review). I have an upcoming PR that would also significantly benefit from this.

Mark-Simulacrum added 3 commits October 11, 2018 08:32

Rollup merge of rust-lang#54956 - kzys:close-paren, r=varkor

e0b9d49

"(using ..." doesn't have the matching ")" Fixes rust-lang#54948.

Rollup merge of rust-lang#54958 - RalfJung:static-assert, r=oli-obk

dc62e1d

add a macro for static (compile-time) assertions Cc @oli-obk

Rollup merge of rust-lang#54967 - holmgr:master, r=estebank

e5ed251

Remove incorrect span for second label inner macro invocation A fix for issue rust-lang#54841

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 11, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 11, 2018

kennytm closed this Oct 12, 2018

Centril added the rollup A PR which is a rollup label Oct 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 14 pull requests #54990

Rollup of 14 pull requests #54990

Mark-Simulacrum commented Oct 11, 2018

Mark-Simulacrum commented Oct 11, 2018

bors commented Oct 11, 2018

bors commented Oct 11, 2018

rust-highfive commented Oct 11, 2018

bors commented Oct 11, 2018

rust-highfive commented Oct 11, 2018

Rollup of 14 pull requests #54990

Rollup of 14 pull requests #54990

Conversation

Mark-Simulacrum commented Oct 11, 2018

Mark-Simulacrum commented Oct 11, 2018

bors commented Oct 11, 2018

bors commented Oct 11, 2018

rust-highfive commented Oct 11, 2018

bors commented Oct 11, 2018

rust-highfive commented Oct 11, 2018