Search box #54281
Merged
Search box #54281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
QuietMisdreavus
suggested changes
Sep 17, 2018
src/doc/index.md
Outdated
| <input type="search" name="search"/> | ||
| <button>Search</button> | ||
| <input id="search-input" type="search" name="search" | ||
| placeholder="Search into the standard library!"/> |
There was a problem hiding this comment.
I'd prefer something like "Search through the standard library" (without the exclamation mark), though i'm welcome to a second opinion from @rust-lang/docs.
src/librustdoc/lib.rs
Outdated
| @@ -404,8 +404,11 @@ fn main_args(args: &[String]) -> isize { | |||
| `short` (instead was `{}`)", arg)); | |||
| } | |||
| }; | |||
| let treat_err_as_bug = matches.opt_strs("Z").iter().any(|x| { | |||
| *x == "treat-err-as-bug" | |||
| }); | |||
There was a problem hiding this comment.
This branch includes your -Z treat-err-as-bug branch as well. Please remove that commit from this branch.
GuillaumeGomez
force-pushed
the
search-box
branch
from
dbf4e9c
to
9d5ca39
Compare
|
Updated. |
QuietMisdreavus
approved these changes
Sep 17, 2018
|
Unless someone from docs comes up with a better search-box placeholder text, r=me if travis is green. |
|
@bors: r=QuietMisdreavus rollup |
|
📌 Commit 9d5ca39 has been approved by |
bors
added
S-waiting-on-bors
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Sep 25, 2018
…isdreavus Search box Follow up of rust-lang#54244. r? @QuietMisdreavus <img width="1440" alt="screen shot 2018-09-16 at 21 23 05" src="https://user-images.githubusercontent.com/3050060/45600056-cbf93380-b9f6-11e8-904a-d76ddbc5ed69.png">
bors
added a commit
that referenced
this pull request
Sep 25, 2018
Rollup of 12 pull requests Successful merges: - #53518 (Add doc for impl From in char_convert) - #54058 (Introduce the partition_dedup/by/by_key methods for slices) - #54281 (Search box) - #54368 (Reduce code block sides padding) - #54498 (The project moved under the Mozilla umbrella) - #54518 (resolve: Do not block derive helper resolutions on single import resolutions) - #54522 (Fixed three small typos.) - #54529 (aarch64-pc-windows-msvc: Don't link libpanic_unwind to libtest.) - #54537 (Rename slice::exact_chunks() to slice::chunks_exact()) - #54539 (Fix js error) - #54557 (incr.comp.: Don't automatically enable -Zshare-generics for incr. comp. builds.) - #54558 (Improvements to finding LLVM's FileCheck) Failed merges: r? @ghost
|
☔ The latest upstream changes (presumably #54575) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #54244.
r? @QuietMisdreavus