Regression test for rust-lang/rust#53675. #54225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
| // rust-lang/rust#53675: At one point the compiler errored when a test | ||
| // named `panic` used the `assert!` macro in expression position. | ||
|
|
||
| // compile-flags: --test |
There was a problem hiding this comment.
Missing compile-pass.
There was a problem hiding this comment.
(Well, I did make it work as a run-pass test I think. But I don’t mind it being compile-pass.)
|
r=me rollup with |
(Includes a couple variations on the theme. I confirmed that the ones in `in_expression_position` and `what_if_we_use_panic_directly_in_expr` both failed back on "rustc 1.30.0-nightly (0f063ae 2018-09-03)".)
pnkfelix
force-pushed
the
issue-53675-add-test-called-panic
branch
from
bbf290c
to
fc6e1ed
Compare
|
@bors r=petrochenkov rollup |
|
📌 Commit fc6e1ed has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 18, 2018
…d-panic, r=petrochenkov Regression test for rust-lang#53675. (Includes a couple variations on the theme. I confirmed that the ones in `in_expression_position` and `what_if_we_use_panic_directly_in_expr` both failed back on "rustc 1.30.0-nightly (0f063ae 2018-09-03)".) Fix rust-lang#53675
bors
added a commit
that referenced
this pull request
Sep 18, 2018
Rollup of 9 pull requests Successful merges: - #53522 (Add doc for impl From for Addr) - #54097 (rustdoc: Remove namespace for keywords) - #54205 (Add treat-err-as-bug flag in rustdoc) - #54225 (Regression test for #53675.) - #54232 (add `-Z dont-buffer-diagnostics`) - #54273 (Suggest to change numeric literal instead of casting) - #54299 (Issue 54246) - #54311 (Remove README with now-out-of-date docs about docs.) - #54313 (OsStr: Document that it's not NUL terminated) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Includes a couple variations on the theme. I confirmed that the ones
in
in_expression_positionandwhat_if_we_use_panic_directly_in_exprboth failed back on "rustc 1.30.0-nightly (0f063ae 2018-09-03)".)
Fix #53675