Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use NonZeroU32 in newtype_index!macro, change syntax #53315

Merged
merged 12 commits into from
Sep 8, 2018
Merged

use NonZeroU32 in newtype_index!macro, change syntax #53315

merged 12 commits into from
Sep 8, 2018

Commits on Sep 7, 2018

  1. change syntax of newtype_index to look like a struct decl

    @nikomatsakis
    nikomatsakis committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    1242639 View commit details
    Browse the repository at this point in the history

  2. add a comment

    @nikomatsakis
    nikomatsakis committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    c46f185 View commit details
    Browse the repository at this point in the history

  3. make field always private, add From impls

    @nikomatsakis
    nikomatsakis committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    5aee959 View commit details
    Browse the repository at this point in the history

  4. change from tuple struct to brace struct

    @nikomatsakis
    nikomatsakis committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    6ccf9b8 View commit details
    Browse the repository at this point in the history

  5. remove all references to private from outside the macro

    @nikomatsakis
    nikomatsakis committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    24ab375 View commit details
    Browse the repository at this point in the history

  6. add various #[inline] directives

    @nikomatsakis
    nikomatsakis committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    c67d518 View commit details
    Browse the repository at this point in the history

  7. rewrite constants to use NewType::MAX instead of u32::MAX 

    Also, adjust the MAX to be `u32::MAX - 1`, leaving room for `u32::MAX`
to become a sentinel value in the future.
    @nikomatsakis
    nikomatsakis committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    f702bd6 View commit details
    Browse the repository at this point in the history

  8. switch to using NonZeroU32 to represent indices

    @nikomatsakis
    nikomatsakis committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    3b6361d View commit details
    Browse the repository at this point in the history

  9. remove use of from_u32_unchecked

    @nikomatsakis
    nikomatsakis committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    3805ebe View commit details
    Browse the repository at this point in the history

  10. use a BTreeSet for a more stable error message order

    @nikomatsakis
    nikomatsakis committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    ec0ad09 View commit details
    Browse the repository at this point in the history

  11. switch back to using a plain u32, not NonZeroU32 

    This reverts (part of) commit cb9a336ae2cf6a75fdcc130853286349cb424c96.
    @nikomatsakis
    nikomatsakis committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    e5e72f6 View commit details
    Browse the repository at this point in the history

  12. add const_fn feature

    @nikomatsakis
    nikomatsakis committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    ab43c1e View commit details
    Browse the repository at this point in the history