Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] break codegen test #52826

Closed
wants to merge 1 commit into from

Conversation

RalfJung
Copy link
Member

This is just to see if I can reproduce the problem I noticed in #51361 where a codegen test was failing for pre-bors CI did not catch it.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2018
@bjorn3
Copy link
Member

bjorn3 commented Jul 29, 2018

Travis is green!!!

@eddyb
Copy link
Member

eddyb commented Jul 29, 2018

There's a // min-llvm-version 6.0 at the top of the file, that's why.

@RalfJung
Copy link
Member Author

But why does the CI runner not use the same LLVM version as x.py?

Cc @rust-lang/infra

@Mark-Simulacrum
Copy link
Member

We have different CI runners; one of them tests against the baseline LLVM (currently 5.0) whereas the rest test against the in-tree LLVM, which is ~7.0 at this point (well, master at some recent date) I believe.

@eddyb
Copy link
Member

eddyb commented Jul 29, 2018

@RalfJung It's intentional (IIRC it avoids building LLVM ourselves by using the system one):

rust/.travis.yml

Lines 18 to 20 in 75af9df

# Images used in testing PR and try-build should be run first.
- env: IMAGE=x86_64-gnu-llvm-5.0 RUST_BACKTRACE=1
if: type = pull_request OR branch = auto

@RalfJung
Copy link
Member Author

I see. Probably we were just unlucky then, with this bug slipping through until main bors time?

Anyway, if there's no bug, I guess we can close this?

@eddyb eddyb closed this Jul 29, 2018
@RalfJung RalfJung deleted the codegen-fail branch August 16, 2018 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants