-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for ICEs which no longer repro #52558
Conversation
r? @estebank Could you move the |
@estebank Sure! How's that look? |
@wesleywiser it looks great! Thank you for taking the time! I'll check back in an hour when travis is done and approve if it's ok (which I'm sure it is). |
@bors r+ rollup |
📌 Commit 3e0cb23 has been approved by |
Add tests for ICEs which no longer repro Adds tests for some ICEs which no longer repro and closes the associated issues.
Add tests for ICEs which no longer repro Adds tests for some ICEs which no longer repro and closes the associated issues.
Rebased |
@bors r+ |
📌 Commit f2bc03f has been approved by |
Add tests for ICEs which no longer repro Adds tests for some ICEs which no longer repro and closes the associated issues.
@bors r- rollup- The test case for 33264 is using inline assembly which is not supported by Please add Test log: #52616 (comment) |
Fixed. Thanks @kennytm! |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@wesleywiser did you mean to update |
Umm... no. I must have accidentally committed those when rebasing. |
@wesleywiser it happens :) |
I think this is good to go. |
@bors r+ |
📌 Commit 715005c has been approved by |
🌲 The tree is currently closed for pull requests below priority 99, this pull request will be tested once the tree is reopened |
@bors treeclosed- |
⌛ Testing commit 715005c with merge 717fb61465faa98c1fc1afc962b07a9261fce5d6... |
@bors retry treeclosed=99 |
@Mark-Simulacrum What does "treeclosed" mean? I've never seen that bors status before. |
@wesleywiser "treeclosed" prevents PRs lower than the specified priority from being tested. Currently Travis has broken our macOS builders, so we cannot run any tests until this is fixed. |
@kennytm Gotcha |
Add tests for ICEs which no longer repro Adds tests for some ICEs which no longer repro and closes the associated issues.
Rollup of 16 pull requests Successful merges: - #52558 (Add tests for ICEs which no longer repro) - #52610 (Clarify what a task is) - #52617 (Don't match on region kinds when reporting NLL errors) - #52635 (Fix #[linkage] propagation though generic functions) - #52647 (Suggest to take and ignore args while closure args count mismatching) - #52649 (Point spans to inner elements of format strings) - #52654 (Format linker args in a way that works for gcc and ld) - #52667 (update the stdsimd submodule) - #52674 (Impl Executor for Box<E: Executor>) - #52690 (ARM: expose `rclass` and `dsp` target features) - #52692 (Improve readability in a few sorts) - #52695 (Hide some lints which are not quite right the way they are reported to the user) - #52718 (State default capacity for BufReader/BufWriter) - #52721 (std::ops::Try impl for std::task::Poll) - #52723 (rustc: Register crates under their real names) - #52734 (sparc ABI issue - structure returning from function is returned in 64bit registers (with tests)) Failed merges: - #52678 ([NLL] Use better spans in some errors) r? @ghost
Adds tests for some ICEs which no longer repro and closes the associated issues.