-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the amdgpu-kernel
ABI.
#52032
Add the amdgpu-kernel
ABI.
#52032
Conversation
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
d317256
to
77b2485
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
r? @eddyb |
Since custom ABIs are unsafe, it is fine to leave it up to the end users to enforce the requirements of the ABI somehow. |
☔ The latest upstream changes (presumably #52191) made this pull request unmergeable. Please resolve the merge conflicts. |
LGTM, r? @alexcrichton |
77b2485
to
1253b51
Compare
@bors: r+ |
📌 Commit 1253b519c53612082cf08363392e888fd888996a has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors: r- |
Is there a quick way to update those line numbers? (sorry, I forgot that I needed to fix that before this got accepted...) |
Actually, nvm. Just Use The Diff, Richard. |
Technically, there are requirements imposed by the LLVM `AMDGPUTargetMachine` on functions with this ABI (eg, the return type must be void), but I'm unsure exactly where this should be enforced.
1253b51
to
6332bb1
Compare
@alexcrichton Fixed |
@bors: r+ |
📌 Commit 6332bb1 has been approved by |
Add the `amdgpu-kernel` ABI. Technically, there are requirements imposed by the LLVM `AMDGPUTargetMachine` on functions with this ABI (eg, the return type must be void), but I'm unsure exactly where this should be enforced.
☀️ Test successful - status-appveyor, status-travis |
Technically, there are requirements imposed by the LLVM
AMDGPUTargetMachine
on functions with this ABI (eg, the return typemust be void), but I'm unsure exactly where this should be enforced.