Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize Iterator::flatten in 1.29, fixes #48213. #51511

Merged
merged 1 commit into from
Jul 1, 2018

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jun 11, 2018

This PR stabilizes Iterator::flatten in version 1.29 (1.28 goes to beta in 10 days, I don't think there's enough time to land it in that time, but let's see...).

Tracking issue is: #48213.

cc @bluss re. itertools.
r? @SimonSapin
ping @pietroalbini -- let's do a crater run when this passes CI :)

@Centril Centril added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. A-iterators Area: Iterators labels Jun 11, 2018
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2018
@pietroalbini pietroalbini added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jun 11, 2018
@Centril Centril changed the title Stabilize Iterator::flatten in 1.29, fixes #48115. Stabilize Iterator::flatten in 1.29, fixes #48213. Jun 11, 2018
@SimonSapin
Copy link
Contributor

@bors try

There was some concern on the tracking issue about colliding with the itertools crate, so let’s so a check-only crater run before landing.

@bors
Copy link
Contributor

bors commented Jun 11, 2018

⌛ Trying commit 85796dd with merge b534f2e...

bors added a commit that referenced this pull request Jun 11, 2018
…<try>

Stabilize Iterator::flatten in 1.29, fixes #48213.

This PR stabilizes [`Iterator::flatten`](https://doc.rust-lang.org/nightly/std/iter/trait.Iterator.html#method.flatten) in *version 1.29* (1.28 goes to beta in 10 days, I don't think there's enough time to land it in that time, but let's see...).

Tracking issue is:  #48213.

cc @bluss re. itertools.
r? @SimonSapin
ping @pietroalbini -- let's do a crater run when this passes CI :)
@bors
Copy link
Contributor

bors commented Jun 11, 2018

☀️ Test successful - status-travis
State: approved= try=True

@pietroalbini
Copy link
Member

Check-only crater run started on crater-2. It should be done in ~3 days.

@pietroalbini
Copy link
Member

Hi @Centril (crater requester), @SimonSapin (PR reviewer)! Crater results are at: http://cargobomb-reports.s3.amazonaws.com/pr-51511/index.html. 'Blacklisted' crates (spurious failures etc) can be found here. If you see any spurious failures not on the list, please make a PR against that file.

(interested observers: Crater is a tool for testing the impact of changes on the crates.io ecosystem. You can find out more at the repo if you're curious)

@pietroalbini pietroalbini removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jun 14, 2018
@pietroalbini
Copy link
Member

pietroalbini commented Jun 14, 2018

Only 11 top level regressions (and 29 counting dependencies), I expected worse. Note that crater detects only crates that build in the crater environment successfully, so this is not the whole ecosystem.

Failure dependency graph

Note: all the libimag* failures seems to be caused by libimagrt, the tool I use to generate the graph is a bit flacky though so the tree is not properly ordered.

bolt11
libimagref
| imag-documentation
rust-bio-tools
libimagrt
| libimagentryedit
| | libimagentryview
| | | libimagdiary
| | | | libimaglog
| | libimagnotes
| | libimaghabit
| imag-counter
libimagentryref
| libimagmail
libimagcontact
irc-bot
mhost
httptin
git-checks
difference_engine
gurobi
github:lukaspustina/mhost
github:vwilliewillus/advent_of_code_2017

@Centril
Copy link
Contributor Author

Centril commented Jun 14, 2018

Doesn't seem insurmountable :) I'll start writing up PRs against the regressing crates.

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2018
@Centril
Copy link
Contributor Author

Centril commented Jun 14, 2018

imag fixed the regression in https://github.com/matthiasbeyer/imag/pull/1491 but hasn't made a 0.9 release yet.

The same applies to irc-bot 0.2, 8573/irc-bot.rs@dfebfd4.

I've notified the authors of this.

@Centril
Copy link
Contributor Author

Centril commented Jun 14, 2018

@Centril
Copy link
Contributor Author

Centril commented Jun 14, 2018

The regression in https://github.com/williewillus/advent_of_code_2017 was due to a regression in pathfinding which was fixed in evenfurther/pathfinding@eb7a947.

This was the last regressing crate.

@bors
Copy link
Contributor

bors commented Jun 30, 2018

@Centril: 🔑 Insufficient privileges: Not in reviewers

@Mark-Simulacrum
Copy link
Member

@bors r=SimonSapin

@bors
Copy link
Contributor

bors commented Jun 30, 2018

📌 Commit 85796dd has been approved by SimonSapin

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2018
@bors
Copy link
Contributor

bors commented Jun 30, 2018

⌛ Testing commit 85796dd with merge 9b704901f62cf0cf4fadba4ae8aa7b6de5f64f30...

@bors
Copy link
Contributor

bors commented Jun 30, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 30, 2018
@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Jun 30, 2018

@bors retry rollup

Travis failed to schedule several macOS builders.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Jun 30, 2018
…flatten, r=SimonSapin

Stabilize Iterator::flatten in 1.29, fixes rust-lang#48213.

This PR stabilizes [`Iterator::flatten`](https://doc.rust-lang.org/nightly/std/iter/trait.Iterator.html#method.flatten) in *version 1.29* (1.28 goes to beta in 10 days, I don't think there's enough time to land it in that time, but let's see...).

Tracking issue is:  rust-lang#48213.

cc @bluss re. itertools.
r? @SimonSapin
ping @pietroalbini -- let's do a crater run when this passes CI :)
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jul 1, 2018
…flatten, r=SimonSapin

Stabilize Iterator::flatten in 1.29, fixes rust-lang#48213.

This PR stabilizes [`Iterator::flatten`](https://doc.rust-lang.org/nightly/std/iter/trait.Iterator.html#method.flatten) in *version 1.29* (1.28 goes to beta in 10 days, I don't think there's enough time to land it in that time, but let's see...).

Tracking issue is:  rust-lang#48213.

cc @bluss re. itertools.
r? @SimonSapin
ping @pietroalbini -- let's do a crater run when this passes CI :)
bors added a commit that referenced this pull request Jul 1, 2018
Rollup of 7 pull requests

Successful merges:

 - #51511 (Stabilize Iterator::flatten in 1.29, fixes #48213.)
 - #51853 (Fix some doc links)
 - #51890 (Fix inconsequential typo in GlobalAlloc doc example)
 - #51920 (use literal span for concrete type suggestion)
 - #51922 (rename the llvm-tools component to llvm-tools-preview and tweak its image)
 - #51936 (rename rustc's lld to rust-lld)
 - #51961 (Fix typo in /src/librustc_resolve/lib.rs)

Failed merges:

r? @ghost
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jul 1, 2018
…flatten, r=SimonSapin

Stabilize Iterator::flatten in 1.29, fixes rust-lang#48213.

This PR stabilizes [`Iterator::flatten`](https://doc.rust-lang.org/nightly/std/iter/trait.Iterator.html#method.flatten) in *version 1.29* (1.28 goes to beta in 10 days, I don't think there's enough time to land it in that time, but let's see...).

Tracking issue is:  rust-lang#48213.

cc @bluss re. itertools.
r? @SimonSapin
ping @pietroalbini -- let's do a crater run when this passes CI :)
bors added a commit that referenced this pull request Jul 1, 2018
Rollup of 7 pull requests

Successful merges:

 - #51511 (Stabilize Iterator::flatten in 1.29, fixes #48213.)
 - #51853 (Fix some doc links)
 - #51890 (Fix inconsequential typo in GlobalAlloc doc example)
 - #51920 (use literal span for concrete type suggestion)
 - #51921 (improve the error message when `#[panic_implementation]` is missing)
 - #51922 (rename the llvm-tools component to llvm-tools-preview and tweak its image)
 - #51961 (Fix typo in /src/librustc_resolve/lib.rs)

Failed merges:

r? @ghost
@bors bors merged commit 85796dd into rust-lang:master Jul 1, 2018
@Centril Centril deleted the feature/stabilize_iterator_flatten branch July 3, 2018 01:18
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 14, 2018
Version 1.29.0 (2018-09-13)
==========================

Compiler
--------
- [Bumped minimum LLVM version to 5.0.][51899]
- [Added `powerpc64le-unknown-linux-musl` target.][51619]
- [Added `aarch64-unknown-hermit` and `x86_64-unknown-hermit` targets.][52861]

Libraries
---------
- [`Once::call_once` now no longer requires `Once` to be `'static`.][52239]
- [`BuildHasherDefault` now implements `PartialEq` and `Eq`.][52402]
- [`Box<CStr>`, `Box<OsStr>`, and `Box<Path>` now implement `Clone`.][51912]
- [Implemented `PartialEq<&str>` for `OsString` and `PartialEq<OsString>`
  for `&str`.][51178]
- [`Cell<T>` now allows `T` to be unsized.][50494]
- [`SocketAddr` is now stable on Redox.][52656]

Stabilized APIs
---------------
- [`Arc::downcast`]
- [`Iterator::flatten`]
- [`Rc::downcast`]

Cargo
-----
- [Cargo can silently fix some bad lockfiles ][cargo/5831] You can use
  `--locked` to disable this behaviour.
- [`cargo-install` will now allow you to cross compile an install
  using `--target`][cargo/5614]
- [Added the `cargo-fix` subcommand to automatically move project code from
  2015 edition to 2018.][cargo/5723]

Misc
----
- [`rustdoc` now has the `--cap-lints` option which demotes all lints above
  the specified level to that level.][52354] For example `--cap-lints warn`
  will demote `deny` and `forbid` lints to `warn`.
- [`rustc` and `rustdoc` will now have the exit code of `1` if compilation
  fails, and `101` if there is a panic.][52197]
- [A preview of clippy has been made available through rustup.][51122]
  You can install the preview with `rustup component add clippy-preview`

Compatibility Notes
-------------------
- [`str::{slice_unchecked, slice_unchecked_mut}` are now deprecated.][51807]
  Use `str::get_unchecked(begin..end)` instead.
- [`std::env::home_dir` is now deprecated for its unintuitive behaviour.][51656]
  Consider using the `home_dir` function from
  https://crates.io/crates/dirs instead.
- [`rustc` will no longer silently ignore invalid data in target spec.][52330]

[52861]: rust-lang/rust#52861
[52656]: rust-lang/rust#52656
[52239]: rust-lang/rust#52239
[52330]: rust-lang/rust#52330
[52354]: rust-lang/rust#52354
[52402]: rust-lang/rust#52402
[52103]: rust-lang/rust#52103
[52197]: rust-lang/rust#52197
[51807]: rust-lang/rust#51807
[51899]: rust-lang/rust#51899
[51912]: rust-lang/rust#51912
[51511]: rust-lang/rust#51511
[51619]: rust-lang/rust#51619
[51656]: rust-lang/rust#51656
[51178]: rust-lang/rust#51178
[51122]: rust-lang/rust#51122
[50494]: rust-lang/rust#50494
[cargo/5614]: rust-lang/cargo#5614
[cargo/5723]: rust-lang/cargo#5723
[cargo/5831]: rust-lang/cargo#5831
[`Arc::downcast`]: https://doc.rust-lang.org/std/sync/struct.Arc.html#method.downcast
[`Iterator::flatten`]: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.flatten
[`Rc::downcast`]: https://doc.rust-lang.org/std/rc/struct.Rc.html#method.downcast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-iterators Area: Iterators relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants